Change an existing method from another project

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Change an existing method from another project

Miguel Moquillon
Hi,

I'm going to provide a new way to write unit tests without having
prefixed test methods with the word 'test'. As I don't want to write
another unit test framework, I need to change some methods of SUnit (as
well of Autotest).
Is there any way to do that from an external project without creating a
specific fork of theses projects?

Mig

Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Stéphane Ducasse
Miguel

please do the following:
        - Fork and copy and past SUnit and extend it
        - In the past I modified SUnit and after people complained that it was not the right version and my extensions got
        lost when we reloaded the latest version of SUnit.
So let us invent some new way to write tests :).

Stef


> Hi,
>
> I'm going to provide a new way to write unit tests without having prefixed test methods with the word 'test'. As I don't want to write another unit test framework, I need to change some methods of SUnit (as well of Autotest).
> Is there any way to do that from an external project without creating a specific fork of theses projects?
>
> Mig
>


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

laurent laffont
In reply to this post by Miguel Moquillon

On Sat, Jun 11, 2011 at 6:33 PM, Miguel Moquillon <[hidden email]> wrote:
Hi,

I'm going to provide a new way to write unit tests without having prefixed test methods with the word 'test'. As I don't want to write another unit test framework, I need to change some methods of SUnit (as well of Autotest).

Cool Miguel ! Will you use a pragma like <test> <before> <after> ?  I want it :)  

For Autotest don't hesitate to commit directly in Autotest repository.

Laurent
 
Is there any way to do that from an external project without creating a specific fork of theses projects?

Mig


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Benjamin Van Ryseghem (Pharo)
Jannik and I were discussing of that 2 days ago :)


No more behavior based on strings ;)
(we should also find a real way to declare extensions)


So good luck Miguel, I am waiting for your project ;)

Ben

On Jun 11, 2011, at 8:22 PM, laurent laffont wrote:


On Sat, Jun 11, 2011 at 6:33 PM, Miguel Moquillon <[hidden email]> wrote:
Hi,

I'm going to provide a new way to write unit tests without having prefixed test methods with the word 'test'. As I don't want to write another unit test framework, I need to change some methods of SUnit (as well of Autotest).

Cool Miguel ! Will you use a pragma like <test> <before> <after> ?  I want it :)  

For Autotest don't hesitate to commit directly in Autotest repository.

Laurent
 
Is there any way to do that from an external project without creating a specific fork of theses projects?

Mig



Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Miguel Moquillon
In reply to this post by laurent laffont
Yes. You're right ;-) it will be based on pragmas

Mig



Le 11 juin 2011 à 20:23, laurent laffont <[hidden email]> a écrit :


On Sat, Jun 11, 2011 at 6:33 PM, Miguel Moquillon <[hidden email]> wrote:
Hi,

I'm going to provide a new way to write unit tests without having prefixed test methods with the word 'test'. As I don't want to write another unit test framework, I need to change some methods of SUnit (as well of Autotest).

Cool Miguel ! Will you use a pragma like <test> <before> <after> ?  I want it :)  

For Autotest don't hesitate to commit directly in Autotest repository.

Laurent
 
Is there any way to do that from an external project without creating a specific fork of theses projects?

Mig


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Miguel Moquillon
In reply to this post by Stéphane Ducasse
Ok,

I will extend SUnit to integrate my extensions.
(It is unfortunate because there is just only one or two methods to change.)

Le 11/06/2011 19:17, Stéphane Ducasse a écrit :

> Miguel
>
> please do the following:
> - Fork and copy and past SUnit and extend it
> - In the past I modified SUnit and after people complained that it was not the right version and my extensions got
> lost when we reloaded the latest version of SUnit.
> So let us invent some new way to write tests :).
>
> Stef
>
>
>> Hi,
>>
>> I'm going to provide a new way to write unit tests without having prefixed test methods with the word 'test'. As I don't want to write another unit test framework, I need to change some methods of SUnit (as well of Autotest).
>> Is there any way to do that from an external project without creating a specific fork of theses projects?
>>
>> Mig
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

laurent laffont

On Mon, Jun 13, 2011 at 9:09 AM, Miguel Moquillon <[hidden email]> wrote:
Ok,

I will extend SUnit to integrate my extensions.
(It is unfortunate because there is just only one or two methods to change.)


Or just open an issue and publish a slice.

Laurent.

 

Le 11/06/2011 19:17, Stéphane Ducasse a écrit :

Miguel

please do the following:
       - Fork and copy and past SUnit and extend it
       - In the past I modified SUnit and after people complained that it was not the right version and my extensions got
       lost when we reloaded the latest version of SUnit.
So let us invent some new way to write tests :).

Stef


Hi,

I'm going to provide a new way to write unit tests without having prefixed test methods with the word 'test'. As I don't want to write another unit test framework, I need to change some methods of SUnit (as well of Autotest).
Is there any way to do that from an external project without creating a specific fork of theses projects?

Mig






Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Stéphane Ducasse
In reply to this post by Miguel Moquillon

On Jun 13, 2011, at 9:09 AM, Miguel Moquillon wrote:

> Ok,
>
> I will extend SUnit to integrate my extensions.
> (It is unfortunate because there is just only one or two methods to change.)

so be ready that your code will not work when the next version of Sunit show up.
I really think that this is better to fork one version where we can do what we want.

Stef

>
> Le 11/06/2011 19:17, Stéphane Ducasse a écrit :
>> Miguel
>>
>> please do the following:
>> - Fork and copy and past SUnit and extend it
>> - In the past I modified SUnit and after people complained that it was not the right version and my extensions got
>> lost when we reloaded the latest version of SUnit.
>> So let us invent some new way to write tests :).
>>
>> Stef
>>
>>
>>> Hi,
>>>
>>> I'm going to provide a new way to write unit tests without having prefixed test methods with the word 'test'. As I don't want to write another unit test framework, I need to change some methods of SUnit (as well of Autotest).
>>> Is there any way to do that from an external project without creating a specific fork of theses projects?
>>>
>>> Mig
>>>
>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Miguel Moquillon
Le 13/06/2011 17:57, Stéphane Ducasse a écrit :

>
> On Jun 13, 2011, at 9:09 AM, Miguel Moquillon wrote:
>
>> Ok,
>>
>> I will extend SUnit to integrate my extensions.
>> (It is unfortunate because there is just only one or two methods to change.)
>
> so be ready that your code will not work when the next version of Sunit show up.
> I really think that this is better to fork one version where we can do what we want.
Thus I have two possible solutions:
- provide a direct contribution to the SUnit project with my code,
- or fork SUnit to a new project (PharoUnit?) so that anybody can
enhance the unit test framework for Pharo.

In fact, I don't know if the Pragma implementation in Pharo is specific
to the Squeak/Pharo smalltalk dialect. In that case, I think it would be
better to fork SUnit as my changes will be based upon pragmas.

Mig

Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

laurent laffont
On Tue, Jun 14, 2011 at 9:06 AM, Miguel Moquillon <[hidden email]> wrote:
Le 13/06/2011 17:57, Stéphane Ducasse a écrit :


On Jun 13, 2011, at 9:09 AM, Miguel Moquillon wrote:

Ok,

I will extend SUnit to integrate my extensions.
(It is unfortunate because there is just only one or two methods to change.)

so be ready that your code will not work when the next version of Sunit show up.
I really think that this is better to fork one version where we can do what we want.
Thus I have two possible solutions:
- provide a direct contribution to the SUnit project with my code,
- or fork SUnit to a new project (PharoUnit?) so that anybody can enhance the unit test framework for Pharo.

In fact, I don't know if the Pragma implementation in Pharo is specific to the Squeak/Pharo smalltalk dialect. In that case, I think it would be better to fork SUnit as my changes will be based upon pragmas.


Indeed http://squeaksource.com/SUnit is global Read / Write, creator/admin = Marcus Denker, so I suppose you can submit a package/branch in this repo safely.

Laurent

 
Mig


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Marcus Denker-4
In reply to this post by Miguel Moquillon

On Jun 14, 2011, at 9:30 AM, laurent laffont wrote:

> On Tue, Jun 14, 2011 at 9:06 AM, Miguel Moquillon <[hidden email]> wrote:
> Le 13/06/2011 17:57, Stéphane Ducasse a écrit :
>
>
> On Jun 13, 2011, at 9:09 AM, Miguel Moquillon wrote:
>
> Ok,
>
> I will extend SUnit to integrate my extensions.
> (It is unfortunate because there is just only one or two methods to change.)
>
> so be ready that your code will not work when the next version of Sunit show up.
> I really think that this is better to fork one version where we can do what we want.
> Thus I have two possible solutions:
> - provide a direct contribution to the SUnit project with my code,
> - or fork SUnit to a new project (PharoUnit?) so that anybody can enhance the unit test framework for Pharo.
>
> In fact, I don't know if the Pragma implementation in Pharo is specific to the Squeak/Pharo smalltalk dialect. In that case, I think it would be better to fork SUnit as my changes will be based upon pragmas.
>
>
> Indeed http://squeaksource.com/SUnit is global Read / Write, creator/admin = Marcus Denker, so I suppose you can submit a package/branch in this repo safely.
>
But keep in mind that the SUnit from Pharo is not regularly saved there... maybe it should? But than, without automatisation this is too much work.



--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

laurent laffont
On Tue, Jun 14, 2011 at 9:33 AM, Marcus Denker <[hidden email]> wrote:

On Jun 14, 2011, at 9:30 AM, laurent laffont wrote:

> On Tue, Jun 14, 2011 at 9:06 AM, Miguel Moquillon <[hidden email]> wrote:
> Le 13/06/2011 17:57, Stéphane Ducasse a écrit :
>
>
> On Jun 13, 2011, at 9:09 AM, Miguel Moquillon wrote:
>
> Ok,
>
> I will extend SUnit to integrate my extensions.
> (It is unfortunate because there is just only one or two methods to change.)
>
> so be ready that your code will not work when the next version of Sunit show up.
> I really think that this is better to fork one version where we can do what we want.
> Thus I have two possible solutions:
> - provide a direct contribution to the SUnit project with my code,
> - or fork SUnit to a new project (PharoUnit?) so that anybody can enhance the unit test framework for Pharo.
>
> In fact, I don't know if the Pragma implementation in Pharo is specific to the Squeak/Pharo smalltalk dialect. In that case, I think it would be better to fork SUnit as my changes will be based upon pragmas.
>
>
> Indeed http://squeaksource.com/SUnit is global Read / Write, creator/admin = Marcus Denker, so I suppose you can submit a package/branch in this repo safely.
>
But keep in mind that the SUnit from Pharo is not regularly saved there... maybe it should? But than, without automatisation this is too much work.

ok. Miguel, the right process may be:
- fork SUnit in your own repo.
- develop
- once satisfied 
    - open an issue 
    - merge your SUnit in PharoCore
    - submit the slice in PharoInbox
 
?


Laurent




--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.


Reply | Threaded
Open this post in threaded view
|

Re: Change an existing method from another project

Marcus Denker-4
In reply to this post by Marcus Denker-4

On Jun 14, 2011, at 9:41 AM, laurent laffont wrote:

> On Tue, Jun 14, 2011 at 9:33 AM, Marcus Denker <[hidden email]> wrote:
>
> On Jun 14, 2011, at 9:30 AM, laurent laffont wrote:
>
> > On Tue, Jun 14, 2011 at 9:06 AM, Miguel Moquillon <[hidden email]> wrote:
> > Le 13/06/2011 17:57, Stéphane Ducasse a écrit :
> >
> >
> > On Jun 13, 2011, at 9:09 AM, Miguel Moquillon wrote:
> >
> > Ok,
> >
> > I will extend SUnit to integrate my extensions.
> > (It is unfortunate because there is just only one or two methods to change.)
> >
> > so be ready that your code will not work when the next version of Sunit show up.
> > I really think that this is better to fork one version where we can do what we want.
> > Thus I have two possible solutions:
> > - provide a direct contribution to the SUnit project with my code,
> > - or fork SUnit to a new project (PharoUnit?) so that anybody can enhance the unit test framework for Pharo.
> >
> > In fact, I don't know if the Pragma implementation in Pharo is specific to the Squeak/Pharo smalltalk dialect. In that case, I think it would be better to fork SUnit as my changes will be based upon pragmas.
> >
> >
> > Indeed http://squeaksource.com/SUnit is global Read / Write, creator/admin = Marcus Denker, so I suppose you can submit a package/branch in this repo safely.
> >
> But keep in mind that the SUnit from Pharo is not regularly saved there... maybe it should? But than, without automatisation this is too much work.
>
> ok. Miguel, the right process may be:
> - fork SUnit in your own repo.

You can use the existing repo for that... no problem.



--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.