Cleaned random

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Cleaned random

stepharo
Hi

I
     renamed all the classes
     renamed attributes when necessary
     clean protocols
     removed duplicated methods
     factored out methods

Then I also use the latest version of DHB numerical serge. 69

Everything is green except one failing test same as before.

Stef

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

SergeStinckwich
Great ! I will have a look fail this test is failing.

Sent from my iPhone

> On 23 avr. 2016, at 18:29, stepharo <[hidden email]> wrote:
>
> Hi
>
> I
>    renamed all the classes
>    renamed attributes when necessary
>    clean protocols
>    removed duplicated methods
>    factored out methods
>
> Then I also use the latest version of DHB numerical serge. 69
>
> Everything is green except one failing test same as before.
>
> Stef
>
> --
> You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

Alexey Cherkaev
Hi,

Which test is failing? I've loaded version 59 of PolyMath and all 642 tests in Math-* packages are passing. (BTW, should the version be updated on github?)

Cheers,
Alexey

On Sunday, April 24, 2016 at 4:38:49 AM UTC+2, Serge Stinckwich wrote:
Great ! I will have a look fail this test is failing.

Sent from my iPhone

> On 23 avr. 2016, at 18:29, stepharo <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="ay_1bLeDLwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">step...@...> wrote:
>
> Hi
>
> I
>    renamed all the classes
>    renamed attributes when necessary
>    clean protocols
>    removed duplicated methods
>    factored out methods
>
> Then I also use the latest version of DHB numerical serge. 69
>
> Everything is green except one failing test same as before.
>
> Stef
>
> --
> You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="ay_1bLeDLwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">scismalltalk...@googlegroups.com.
> For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

SergeStinckwich
On Thu, Apr 28, 2016 at 7:29 PM, Alexey Cherkaev
<[hidden email]> wrote:
> Hi,
>
> Which test is failing? I've loaded version 59 of PolyMath and all 642 tests
> in Math-* packages are passing. (BTW, should the version be updated on
> github?)

Always the same test:
https://travis-ci.org/PolyMathOrg/PolyMath/jobs/126367821#L1974


> Cheers,
> Alexey
>
> On Sunday, April 24, 2016 at 4:38:49 AM UTC+2, Serge Stinckwich wrote:
>>
>> Great ! I will have a look fail this test is failing.
>>
>> Sent from my iPhone
>>
>> > On 23 avr. 2016, at 18:29, stepharo <[hidden email]> wrote:
>> >
>> > Hi
>> >
>> > I
>> >    renamed all the classes
>> >    renamed attributes when necessary
>> >    clean protocols
>> >    removed duplicated methods
>> >    factored out methods
>> >
>> > Then I also use the latest version of DHB numerical serge. 69
>> >
>> > Everything is green except one failing test same as before.
>> >
>> > Stef
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups "SciSmalltalk" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an email to [hidden email].
>> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "SciSmalltalk" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [hidden email].
> For more options, visit https://groups.google.com/d/optout.



--
Serge Stinckwich
UCBN & UMI UMMISCO 209 (IRD/UPMC)
Every DSL ends up being Smalltalk
http://www.doesnotunderstand.org/

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

Alexey Cherkaev


On 28 April 2016 at 14:41, Serge Stinckwich <[hidden email]> wrote:
On Thu, Apr 28, 2016 at 7:29 PM, Alexey Cherkaev
<[hidden email]> wrote:
> Hi,
>
> Which test is failing? I've loaded version 59 of PolyMath and all 642 tests
> in Math-* packages are passing. (BTW, should the version be updated on
> github?)

Always the same test:
https://travis-ci.org/PolyMathOrg/PolyMath/jobs/126367821#L1974



This is rather weird: on my two different machines (Win7 and Ubuntu 15.10) this test passes.

Alexey

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

werner kassens-2
Hi,
this is because it is a random test and jenkins often initiates the rng with the same number. you can make it non-random and, i guess, non-failing with setting the seed (i am not at home at the moment, hence cant do it) :
generatedPoints: anInteger
    "Private - Generate random points into aCollection. 3 clusters are used"
    | centers results |
    centers := Array new: 3.
    centers at: 1 put: #( 200 200  200) asDhbVector;
                 at: 2 put: #(-200 200  200) asDhbVector;
                 at: 3 put: #( 200 200 -200) asDhbVector.
    results := OrderedCollection new.
    DhbMitchellMooreGenerator reset: 6."make tests non-random"
    anInteger timesRepeat: [ self accumulateAround: ( centers at: (3 random + 1)) size: 1 into: results ].
    ^results
it is possible than then another random-test will fail and one has to then make other tests nonrandom,i dont know in which sequence jenkins goes through the tests.
werner


On Thu, Apr 28, 2016 at 4:21 PM, Alexey Cherkaev <[hidden email]> wrote:


On 28 April 2016 at 14:41, Serge Stinckwich <[hidden email]> wrote:
On Thu, Apr 28, 2016 at 7:29 PM, Alexey Cherkaev
<[hidden email]> wrote:
> Hi,
>
> Which test is failing? I've loaded version 59 of PolyMath and all 642 tests
> in Math-* packages are passing. (BTW, should the version be updated on
> github?)

Always the same test:
https://travis-ci.org/PolyMathOrg/PolyMath/jobs/126367821#L1974



This is rather weird: on my two different machines (Win7 and Ubuntu 15.10) this test passes.

Alexey

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

stepharo

Thanks

I I saw a little glitch in the random package and once my energy to refactor my garden will be over I will do another pass on PM and may be I will be able to understand

how to fix the tests

Stef


Le 30/4/16 à 18:03, werner kassens a écrit :
Hi,
this is because it is a random test and jenkins often initiates the rng with the same number. you can make it non-random and, i guess, non-failing with setting the seed (i am not at home at the moment, hence cant do it) :
generatedPoints: anInteger
    "Private - Generate random points into aCollection. 3 clusters are used"
    | centers results |
    centers := Array new: 3.
    centers at: 1 put: #( 200 200  200) asDhbVector;
                 at: 2 put: #(-200 200  200) asDhbVector;
                 at: 3 put: #( 200 200 -200) asDhbVector.
    results := OrderedCollection new.
    DhbMitchellMooreGenerator reset: 6."make tests non-random"
    anInteger timesRepeat: [ self accumulateAround: ( centers at: (3 random + 1)) size: 1 into: results ].
    ^results
it is possible than then another random-test will fail and one has to then make other tests nonrandom,i dont know in which sequence jenkins goes through the tests.
werner


On Thu, Apr 28, 2016 at 4:21 PM, Alexey Cherkaev <[hidden email]> wrote:


On 28 April 2016 at 14:41, Serge Stinckwich <[hidden email]> wrote:
On Thu, Apr 28, 2016 at 7:29 PM, Alexey Cherkaev
<[hidden email]> wrote:
> Hi,
>
> Which test is failing? I've loaded version 59 of PolyMath and all 642 tests
> in Math-* packages are passing. (BTW, should the version be updated on
> github?)

Always the same test:
https://travis-ci.org/PolyMathOrg/PolyMath/jobs/126367821#L1974



This is rather weird: on my two different machines (Win7 and Ubuntu 15.10) this test passes.

Alexey

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

Alexey Cherkaev
In reply to this post by werner kassens-2
Thank, Werner! This makes sense (and begs the question why didn't I think about it! ;)). I would have loved to help with this one, but unfortunately my area of expertise lies mostly in more classical numerical methods: linear algebra, ODE, integration, etc.

Alexey

PS. I'm excited to start Pharo MOOC this coming week!

On Saturday, April 30, 2016 at 6:03:20 PM UTC+2, werner kassens wrote:
Hi,
this is because it is a random test and jenkins often initiates the rng with the same number. you can make it non-random and, i guess, non-failing with setting the seed (i am not at home at the moment, hence cant do it) :
generatedPoints: anInteger
    "Private - Generate random points into aCollection. 3 clusters are used"
    | centers results |
    centers := Array new: 3.
    centers at: 1 put: #( 200 200  200) asDhbVector;
                 at: 2 put: #(-200 200  200) asDhbVector;
                 at: 3 put: #( 200 200 -200) asDhbVector.
    results := OrderedCollection new.
    DhbMitchellMooreGenerator reset: 6."make tests non-random"
    anInteger timesRepeat: [ self accumulateAround: ( centers at: (3 random + 1)) size: 1 into: results ].
    ^results
it is possible than then another random-test will fail and one has to then make other tests nonrandom,i dont know in which sequence jenkins goes through the tests.
werner

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

stepharo


Le 1/5/16 à 10:45, Alexey Cherkaev a écrit :
> Thank, Werner! This makes sense (and begs the question why didn't I
> think about it! ;)). I would have loved to help with this one, but
> unfortunately my area of expertise lies mostly in more classical
> numerical methods: linear algebra, ODE, integration, etc.
>
> Alexey
>
> PS. I'm excited to start Pharo MOOC this coming week!

I hope that you will learn something.
It took us really a lot of time and energy.
We did it in a way that people can use it to teach pharo. All the
materials will be available just after the mooc.

Stef

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Cleaned random

stepharo
In reply to this post by SergeStinckwich
Fixed now based on the suggestion of Werner. :)

now the jobs are green.

Now random is ok for me and I will move to the next package.

Stef


Le 28/4/16 à 14:41, Serge Stinckwich a écrit :

> On Thu, Apr 28, 2016 at 7:29 PM, Alexey Cherkaev
> <[hidden email]> wrote:
>> Hi,
>>
>> Which test is failing? I've loaded version 59 of PolyMath and all 642 tests
>> in Math-* packages are passing. (BTW, should the version be updated on
>> github?)
> Always the same test:
> https://travis-ci.org/PolyMathOrg/PolyMath/jobs/126367821#L1974
>
>
>> Cheers,
>> Alexey
>>
>> On Sunday, April 24, 2016 at 4:38:49 AM UTC+2, Serge Stinckwich wrote:
>>> Great ! I will have a look fail this test is failing.
>>>
>>> Sent from my iPhone
>>>
>>>> On 23 avr. 2016, at 18:29, stepharo <[hidden email]> wrote:
>>>>
>>>> Hi
>>>>
>>>> I
>>>>     renamed all the classes
>>>>     renamed attributes when necessary
>>>>     clean protocols
>>>>     removed duplicated methods
>>>>     factored out methods
>>>>
>>>> Then I also use the latest version of DHB numerical serge. 69
>>>>
>>>> Everything is green except one failing test same as before.
>>>>
>>>> Stef
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "SciSmalltalk" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>> an email to [hidden email].
>>>> For more options, visit https://groups.google.com/d/optout.
>> --
>> You received this message because you are subscribed to the Google Groups
>> "SciSmalltalk" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [hidden email].
>> For more options, visit https://groups.google.com/d/optout.
>
>

--
You received this message because you are subscribed to the Google Groups "SciSmalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.
Loading...