Closure fixes have reverted changes in the kernel (again)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Closure fixes have reverted changes in the kernel (again)

Adrian Lienhard
I started looking at the failing tests and noted that a change  
(refactoring of how Traits access the changes/sources) in  
CompiledMethod>>getSourceFor:in: have been reverted. I can fix it, but  
I wonder which other closure fixes have reverted previous changes that  
we applied to Pharo-core. What is the easiest way to review the  
changes of the recent closure fixes introduced to Pharo-core? Since  
Eliot works against Squeak, I presume, any of his changes may be  
problematic and has to be reviewed.

Cheers,
Adrian
___________________
http://www.adrian-lienhard.ch/


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Closure fixes have reverted changes in the kernel (again)

Stéphane Ducasse

> I started looking at the failing tests and noted that a change
> (refactoring of how Traits access the changes/sources) in
> CompiledMethod>>getSourceFor:in: have been reverted. I can fix it, but
> I wonder which other closure fixes have reverted previous changes that
> we applied to Pharo-core. What is the easiest way to review the
> changes of the recent closure fixes introduced to Pharo-core? Since
> Eliot works against Squeak, I presume, any of his changes may be
> problematic and has to be reviewed.

The best things would be to take the image just before the fixes and
merge the package we pushed in.



indeed this is important to do that.

Stef


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

10457-Pha-ClosureFixes.cs (1K) Download Attachment