Smalltalk › Pharo › Pharo Smalltalk Developers

Cmd + click

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

17 messages Options

Uko2

Cmd + click

Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.

Is anyone aware of this?

Cheers.
Uko

Aliaksei Syrel

Re: Cmd + click

On Tue, Jan 19, 2016 at 3:37 PM, Yuriy Tymchuk <[hidden email]> wrote:

Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.

Is anyone aware of this?

Cheers.
Uko

Nicolai Hess-3-2

Re: Cmd + click

In reply to this post by Uko2

2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:

Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.

Is anyone aware of this?

platform and image version?

It works on Windows pharo 50529:

alt+right click -> browse Class/implementors of

alt+shift+right click -> users of class /senders of

Cheers.
Uko

Sven Van Caekenberghe-2

Re: Cmd + click

> On 19 Jan 2016, at 15:51, Nicolai Hess <[hidden email]> wrote:
>
>
>
> 2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:
> Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.
>
> Is anyone aware of this?
>
> platform and image version?
>
> It works on Windows pharo 50529:
> alt+right click -> browse Class/implementors of
> alt+shift+right click -> users of class /senders of

Cmd (Apple) key + (Shift) + Click works fine on OS X in #50535

> Cheers.
> Uko
>

stepharo

Re: Cmd + click

Excellent I will add it in the Updated Pharo by Example chapter

Stef

Le 19/1/16 16:50, Sven Van Caekenberghe a écrit :

>> On 19 Jan 2016, at 15:51, Nicolai Hess <[hidden email]> wrote:
>>
>>
>>
>> 2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:
>> Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.
>>
>> Is anyone aware of this?
>>
>> platform and image version?
>>
>> It works on Windows pharo 50529:
>> alt+right click -> browse Class/implementors of
>> alt+shift+right click -> users of class /senders of
> Cmd (Apple) key + (Shift) + Click works fine on OS X in #50535
>
>> Cheers.
>> Uko
>>
>
>

stepharo

Re: Cmd + click

In reply to this post by Sven Van Caekenberghe-2

2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:
Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.

Is anyone aware of this?

platform and image version?

It works on Windows pharo 50529:
alt+right click -> browse Class/implementors of
alt+shift+right click -> users of class /senders of

> Cmd (Apple) key + (Shift) + Click works fine on OS X in #50535

Sven do you get implementors and senders working because I get refs and
class def but not the method counterparts.

Stef
>
>> Cheers.
>> Uko
>>
>
>

Sven Van Caekenberghe-2

Re: Cmd + click

> On 19 Jan 2016, at 17:31, stepharo <[hidden email]> wrote:
>
>
> 2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:
> Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.
>
> Is anyone aware of this?
>
> platform and image version?
>
> It works on Windows pharo 50529:
> alt+right click -> browse Class/implementors of
> alt+shift+right click -> users of class /senders of
>
>> Cmd (Apple) key + (Shift) + Click works fine on OS X in #50535
>
> Sven do you get implementors and senders working because I get refs and class def but not the method counterparts.

I just tried in a fresh 50 image, and they all work fine. (I seem to remember differently, maybe from 40).

> Stef
>>
>>> Cheers.
>>> Uko

Uko2

Re: Cmd + click

Sorry, I’ve tried again and it works. I don’t know what happened… Maybe something else was registering the event, or some other magic.

I was using 50522.

Cheers.

Uko

On 19 Jan 2016, at 17:39, Sven Van Caekenberghe <[hidden email]> wrote:

On 19 Jan 2016, at 17:31, stepharo <[hidden email]> wrote:

2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:
Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.

Is anyone aware of this?

platform and image version?

It works on Windows pharo 50529:
alt+right click -> browse Class/implementors of
alt+shift+right click -> users of class /senders of

Cmd (Apple) key + (Shift) + Click works fine on OS X in #50535

Sven do you get implementors and senders working because I get refs and class def but not the method counterparts.

I just tried in a fresh 50 image, and they all work fine. (I seem to remember differently, maybe from 40).

Stef

Cheers.
Uko

stepharo

Re: Cmd + click

strnage in my image Latest update: #50529 when I type factorial in the method definitino pane and do click + mouse I do not get the implementors

Le 19/1/16 17:50, Yuriy Tymchuk a écrit :

Sorry, I’ve tried again and it works. I don’t know what happened… Maybe something else was registering the event, or some other magic.
I was using 50522.

Cheers.

Uko

On 19 Jan 2016, at 17:39, Sven Van Caekenberghe <[hidden email]> wrote:

On 19 Jan 2016, at 17:31, stepharo <[hidden email]> wrote:

2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:
Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.

Is anyone aware of this?

platform and image version?

It works on Windows pharo 50529:
alt+right click -> browse Class/implementors of
alt+shift+right click -> users of class /senders of

Cmd (Apple) key + (Shift) + Click works fine on OS X in #50535

Sven do you get implementors and senders working because I get refs and class def but not the method counterparts.

I just tried in a fresh 50 image, and they all work fine. (I seem to remember differently, maybe from 40).

Stef

Cheers.
Uko

stepharo

Re: Cmd + click

In reply to this post by Sven Van Caekenberghe-2

Sven
- I took the latest 50
- open playground
- type factorial
- cmd click on it => nothing
- cmd shift click on it => nothing

Now doing the same in Nautilus method pane works
Now I understand why it was not working with me.

It only works on method body.
If you click on a signature it does not work (which is a bug to me).

Stef

Sven Van Caekenberghe-2

Re: Cmd + click

In reply to this post by stepharo

> On 19 Jan 2016, at 21:28, stepharo <[hidden email]> wrote:
>
> strnage in my image Latest update: #50529 when I type factorial in the method definitino pane and do click + mouse I do not get the implementors

Well, it does indeed not work if you start typing a new method and cmd-click on the selector name, it does work inside code that follows. That might be intentional or might be a bug, probably the latter.

> Le 19/1/16 17:50, Yuriy Tymchuk a écrit :
>> Sorry, I’ve tried again and it works. I don’t know what happened… Maybe something else was registering the event, or some other magic.
>> I was using 50522.
>>
>> Cheers.
>> Uko
>>
>>
>>> On 19 Jan 2016, at 17:39, Sven Van Caekenberghe <[hidden email]> wrote:
>>>
>>>>
>>>> On 19 Jan 2016, at 17:31, stepharo <[hidden email]> wrote:
>>>>
>>>>
>>>> 2016-01-19 15:37 GMT+01:00 Yuriy Tymchuk <[hidden email]>:
>>>> Hi, there was a future that "cmd + click" browsed classes or showed implementors. Now it doesn’t seem to work at least in Nautilus.
>>>>
>>>> Is anyone aware of this?
>>>>
>>>> platform and image version?
>>>>
>>>> It works on Windows pharo 50529:
>>>> alt+right click -> browse Class/implementors of
>>>> alt+shift+right click -> users of class /senders of
>>>>
>>>>> Cmd (Apple) key + (Shift) + Click works fine on OS X in #50535
>>>>
>>>> Sven do you get implementors and senders working because I get refs and class def but not the method counterparts.
>>>
>>> I just tried in a fresh 50 image, and they all work fine. (I seem to remember differently, maybe from 40).
>>>
>>>> Stef
>>>>>
>>>>>> Cheers.
>>>>>> Uko
>>
>

Sven Van Caekenberghe-2

Re: Cmd + click

In reply to this post by stepharo

> On 19 Jan 2016, at 21:47, stepharo <[hidden email]> wrote:
>
> Sven
> - I took the latest 50
> - open playground
> - type factorial
> - cmd click on it => nothing
> - cmd shift click on it => nothing

factorial is not valid code
1 factorial is and then it works
so it has something to do with parsing/ast/errors, I guess

> Now doing the same in Nautilus method pane works
> Now I understand why it was not working with me.
>
> It only works on method body.
> If you click on a signature it does not work (which is a bug to me).
>
> Stef
>

Nicolai Hess-3-2

Re: Cmd + click

In reply to this post by stepharo

2016-01-19 21:47 GMT+01:00 stepharo <[hidden email]>:

Sven
- I took the latest 50
- open playground
- type factorial
- cmd click on it => nothing
- cmd shift click on it => nothing

Now doing the same in Nautilus method pane works
Now I understand why it was not working with me.

It only works on method body.
If you click on a signature it does not work (which is a bug to me).

Stef

17431 No TextLink for methods signature in the code pane

Uko2

Re: Cmd + click

In reply to this post by Sven Van Caekenberghe-2

It makes sense,

syntactically factorial is not a message sent, so it can’t be looked up a a method. I don’t know about the implementation, but maybe it tries to look it up as a global var.

Cheers.
Uko

> On 19 Jan 2016, at 21:51, Sven Van Caekenberghe <[hidden email]> wrote:
>
>
>> On 19 Jan 2016, at 21:47, stepharo <[hidden email]> wrote:
>>
>> Sven
>> - I took the latest 50
>> - open playground
>> - type factorial
>> - cmd click on it => nothing
>> - cmd shift click on it => nothing
>
> factorial is not valid code
> 1 factorial is and then it works
> so it has something to do with parsing/ast/errors, I guess
>
>> Now doing the same in Nautilus method pane works
>> Now I understand why it was not working with me.
>>
>> It only works on method body.
>> If you click on a signature it does not work (which is a bug to me).
>>
>> Stef
>>
>
>

Nicolai Hess-3-2

Re: Cmd + click

In reply to this post by Nicolai Hess-3-2

2016-01-19 22:04 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-19 21:47 GMT+01:00 stepharo <[hidden email]>:
Sven
- I took the latest 50
- open playground
- type factorial
- cmd click on it => nothing
- cmd shift click on it => nothing

Now doing the same in Nautilus method pane works
Now I understand why it was not working with me.

It only works on method body.
If you click on a signature it does not work (which is a bug to me).

Stef

17431 No TextLink for methods signature in the code pane

Fixed upstream:
Name: Rubric-NicolaiHess.323

(we need to get TextLink/RubTextLink merged into one. Now I had to fix this in RubStyler instead of its parent class :( )

Nicolai Hess-3-2

Re: Cmd + click

In reply to this post by Uko2

2016-01-19 22:05 GMT+01:00 Yuriy Tymchuk <[hidden email]>:

It makes sense,

syntactically factorial is not a message sent, so it can’t be looked up a a method. I don’t know about the implementation, but maybe it tries to look it up as a global var.

It is parsed as an incomplete identifier and results in a RBErrorNode.
If thee parser would recognized this as a valid message selector, it would create a RBMetNode and the highlighter would assign an

appropiate TextLink.

Cheers.
Uko

> On 19 Jan 2016, at 21:51, Sven Van Caekenberghe <[hidden email]> wrote:
>
>
>> On 19 Jan 2016, at 21:47, stepharo <[hidden email]> wrote:
>>
>> Sven
>> - I took the latest 50
>> - open playground
>> - type factorial
>> - cmd click on it => nothing
>> - cmd shift click on it => nothing
>
> factorial is not valid code
> 1 factorial is and then it works
> so it has something to do with parsing/ast/errors, I guess
>
>> Now doing the same in Nautilus method pane works
>> Now I understand why it was not working with me.
>>
>> It only works on method body.
>> If you click on a signature it does not work (which is a bug to me).
>>
>> Stef
>>
>
>

Nicolai Hess-3-2

Re: Cmd + click

In reply to this post by Nicolai Hess-3-2

2016-01-19 22:04 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-19 21:47 GMT+01:00 stepharo <[hidden email]>:
Sven
- I took the latest 50
- open playground
- type factorial
- cmd click on it => nothing
- cmd shift click on it => nothing

Now doing the same in Nautilus method pane works
Now I understand why it was not working with me.

It only works on method body.
If you click on a signature it does not work (which is a bug to me).

Stef

17431 No TextLink for methods signature in the code pane

oh, sorry you already opened an issue (17430) I didn't saw that.