Smalltalk › Pharo › Pharo Smalltalk Developers

Code Critics pragmas for classes - do they need to be on instance and class side?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Stan Shepherd

Code Critics pragmas for classes - do they need to be on instance and class side?

Hi, this one's for Lukas. Where you set Code critics to pragmas-

http://n4.nabble.com/Slime-in-one-click-image-tt100493.html#a100498

It seems only to work when the pragma is on both instance and class side. Is this the intention?

Cheers, ...Stan

Lukas Renggli

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

> It seems only to work when the pragma is on both instance and class side. Is
> this the intention?

Yes, that's how it is implemented ;-)

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Lukas Renggli

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

> Yes, that's how it is implemented ;-)

I mean, if it is added to the class-side it affects the class-side,
and if it is added to the instance-side it affects the instance-side.
We can change it that it affects both sides, if this is what everybody
wants?

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Stan Shepherd

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

Lukas Renggli wrote

> Yes, that's how it is implemented ;-)

I mean, if it is added to the class-side it affects the class-side,
and if it is added to the instance-side it affects the instance-side.
We can change it that it affects both sides, if this is what everybody
wants?

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

I was specifically thinking of "class not referenced", which seems strange to have to put on both sides. But I suppose there could be other class checks for which there could be utility in treating class and instance separately; I haven't come across a case so far.

...Stan

Lukas Renggli

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

> I was specifically thinking of "class not referenced", which seems strange
> to have to put on both sides. But I suppose there could be other class
> checks for which there could be utility in treating class and instance
> separately; I haven't come across a case so far.

Ok, you convinced me. I've fixed this (but not tested it) in
Refactoring-Core-lr.93. Let me know if this is better.

Name: Refactoring-Core-lr.93
Author: lr
Time: 3 January 2010, 3:25:42 pm
UUID: c8f01646-b4cc-420a-a05e-dd8a0a81a305
Ancestors: Refactoring-Core-TestRunner.92

- for lint issues in class environments filter the instance and class side

Lukas

>
> ...Stan
>
> --
> View this message in context: http://n2.nabble.com/Code-Critics-pragmas-for-classes-do-they-need-to-be-on-instance-and-class-side-tp4244276p4245938.html
> Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Stan Shepherd

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

Lukas Renggli wrote

> I was specifically thinking of "class not referenced", which seems strange
> to have to put on both sides. But I suppose there could be other class
> checks for which there could be utility in treating class and instance
> separately; I haven't come across a case so far.

Ok, you convinced me. I've fixed this (but not tested it) in
Refactoring-Core-lr.93. Let me know if this is better.

Name: Refactoring-Core-lr.93
Author: lr
Time: 3 January 2010, 3:25:42 pm
UUID: c8f01646-b4cc-420a-a05e-dd8a0a81a305
Ancestors: Refactoring-Core-TestRunner.92

- for lint issues in class environments filter the instance and class side

Lukas

>
> ...Stan

>
--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
Pharo-project@lists.gforge.inria.fr
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

That's a lot tidier, thanks. ...Stan

Code Critics pragmas for classes - do they need to be on instance *and* class side?

Code Critics pragmas for classes - do they need to be on instance *and* class side?

Re: Code Critics pragmas for classes - do they need to be on instance *and* class side?

Re: Code Critics pragmas for classes - do they need to be on instance *and* class side?

Re: Code Critics pragmas for classes - do they need to be on instance *and* class side?

Re: Code Critics pragmas for classes - do they need to be on instance *and* class side?

Re: Code Critics pragmas for classes - do they need to be on instance *and* class side?

Code Critics pragmas for classes - do they need to be on instance and class side?

Code Critics pragmas for classes - do they need to be on instance and class side?

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

Re: Code Critics pragmas for classes - do they need to be on instance and class side?

Re: Code Critics pragmas for classes - do they need to be on instance and class side?