Smalltalk › Cincom › VisualWorks

CodeCritic warnings in source code editor?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

CodeCritic warnings in source code editor?

Hi!

Is there a way to make the code critic warnings of vw 8.0 editor disappear permanently?

They are disturbing really:

Johannes

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Georg Heeg

Re: CodeCritic warnings in source code editor?

Johannes,

Your example is great. The warning message is plain wrong as this is the implementation of select:

Georg

Georg Heeg eK, Dortmund und Köthen, HR Dortmund A 12812

Wallstraße 22, 06366 Köthen

Tel. +49-3496-214328, Fax +49-3496-214712

Von: [hidden email] [mailto:[hidden email]] Im Auftrag von Johannes Brauer
Gesendet: Samstag, 28. Februar 2015 12:00
An: VW NC
Betreff: [vwnc] CodeCritic warnings in source code editor?

Hi!

Is there a way to make the code critic warnings of vw 8.0 editor disappear permanently?

They are disturbing really:

Johannes

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Re: CodeCritic warnings in source code editor?

Georg,

mainly I see the problem from a didactical point of view. It is quite difficult to enable beginners to use of the do:-message correctly. And then, when they try that for themselves, they always see these annoying warnings.

I selected the implementation of select: as example because of the particularly silly warning .

Johannes

Am 28.02.2015 um 14:39 schrieb Georg Heeg <[hidden email]>:

Johannes,

Your example is great. The warning message is plain wrong as this is the implementation of select:

Georg

Georg Heeg eK, Dortmund und Köthen, HR Dortmund A 12812

Wallstraße 22, 06366 Köthen

Tel. +49-3496-214328, Fax +49-3496-214712

Von: [hidden email] [[hidden email]] Im Auftrag von Johannes Brauer
Gesendet: Samstag, 28. Februar 2015 12:00
An: VW NC
Betreff: [vwnc] CodeCritic warnings in source code editor?

Hi!

Is there a way to make the code critic warnings of vw 8.0 editor disappear permanently?

They are disturbing really:

<image001.png>

Johannes

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

Michael Lucas-Smith-2

Re: CodeCritic warnings in source code editor?

You can take the code critic plugin out of the plugins collection on the class side of SourceCodeEditor. However, the main issue here was a bug that has been fixed in 8.0.1 where warnings would be displayed immediately upon looking at a method, rather than when you edited and/or saved a method.

Cheers,

Michael

On 1 Mar 2015, at 3:43 am, Johannes Brauer <[hidden email]> wrote:

Georg,

mainly I see the problem from a didactical point of view. It is quite difficult to enable beginners to use of the do:-message correctly. And then, when they try that for themselves, they always see these annoying warnings.

I selected the implementation of select: as example because of the particularly silly warning .

Johannes

Am 28.02.2015 um 14:39 schrieb Georg Heeg <[hidden email]>:

Johannes,

Your example is great. The warning message is plain wrong as this is the implementation of select:

Georg

Georg Heeg eK, Dortmund und Köthen, HR Dortmund A 12812

Wallstraße 22, 06366 Köthen

Tel. +49-3496-214328, Fax +49-3496-214712

Von: [hidden email] [[hidden email]] Im Auftrag von Johannes Brauer
Gesendet: Samstag, 28. Februar 2015 12:00
An: VW NC
Betreff: [vwnc] CodeCritic warnings in source code editor?

Hi!

Is there a way to make the code critic warnings of vw 8.0 editor disappear permanently?

They are disturbing really:

<image001.png>

Johannes

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Re: CodeCritic warnings in source code editor?

Thank you, Michael, I removed the class SmalllintDecoration and then the code critic message disappeared. In my opinion it should be possible to configure the editor so that the code critic message does not appear at all.

Where can I get vw 8.0.1?

Johannes

Am 28.02.2015 um 19:45 schrieb Michael Lucas-Smith <[hidden email]>:

You can take the code critic plugin out of the plugins collection on the class side of SourceCodeEditor. However, the main issue here was a bug that has been fixed in 8.0.1 where warnings would be displayed immediately upon looking at a method, rather than when you edited and/or saved a method.

Cheers,

Michael

On 1 Mar 2015, at 3:43 am, Johannes Brauer <[hidden email]> wrote:

Georg,

mainly I see the problem from a didactical point of view. It is quite difficult to enable beginners to use of the do:-message correctly. And then, when they try that for themselves, they always see these annoying warnings.

I selected the implementation of select: as example because of the particularly silly warning .

Johannes

Am 28.02.2015 um 14:39 schrieb Georg Heeg <[hidden email]>:

Johannes,

Your example is great. The warning message is plain wrong as this is the implementation of select:

ha

Georg

Georg Heeg eK, Dortmund und Köthen, HR Dortmund A 12812

Wallstraße 22, 06366 Köthen

Tel. +49-3496-214328, Fax +49-3496-214712

Von: [hidden email] [[hidden email]] Im Auftrag von Johannes Brauer
Gesendet: Samstag, 28. Februar 2015 12:00
An: VW NC
Betreff: [vwnc] CodeCritic warnings in source code editor?

Hi!

Is there a way to make the code critic warnings of vw 8.0 editor disappear permanently?

They are disturbing really:

<image001.png>

Johannes

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Vincent Lesbros-2

Re: CodeCritic warnings in source code editor?

I have the same kind of problem :

Perhaps the code critic should verify if the solution proposed is not the message currently implemented ?

I found that because I am upgrading from 7.9.1 to 8.0 ... and to implement a local menu in a graphical view I have the following code :

I want to give the menu (In a kind of ControllerWithMenu) corresponding to the graphical element (unBlob) clicked.

Sincerely, I can't see the interest of allSatisfy: in this case.

2015-03-01 16:47 GMT+01:00 Johannes Brauer <[hidden email]>:

Thank you, Michael, I removed the class SmalllintDecoration and then the code critic message disappeared. In my opinion it should be possible to configure the editor so that the code critic message does not appear at all.

Where can I get vw 8.0.1?

Johannes

Am 28.02.2015 um 19:45 schrieb Michael Lucas-Smith <[hidden email]>:

You can take the code critic plugin out of the plugins collection on the class side of SourceCodeEditor. However, the main issue here was a bug that has been fixed in 8.0.1 where warnings would be displayed immediately upon looking at a method, rather than when you edited and/or saved a method.

Cheers,

Michael

On 1 Mar 2015, at 3:43 am, Johannes Brauer <[hidden email]> wrote:

Georg,

mainly I see the problem from a didactical point of view. It is quite difficult to enable beginners to use of the do:-message correctly. And then, when they try that for themselves, they always see these annoying warnings.

I selected the implementation of select: as example because of the particularly silly warning .

Johannes

Am 28.02.2015 um 14:39 schrieb Georg Heeg <[hidden email]>:

Johannes,

Your example is great. The warning message is plain wrong as this is the implementation of select:

ha

Georg

Georg Heeg eK, Dortmund und Köthen, HR Dortmund A 12812

Wallstraße 22, 06366 Köthen

Tel. <a href="tel:%2B49-3496-214328" value="+493496214328" target="_blank">+49-3496-214328, Fax <a href="tel:%2B49-3496-214712" value="+493496214712" target="_blank">+49-3496-214712

Von: [hidden email] [[hidden email]] Im Auftrag von Johannes Brauer
Gesendet: Samstag, 28. Februar 2015 12:00
An: VW NC
Betreff: [vwnc] CodeCritic warnings in source code editor?

Hi!

Is there a way to make the code critic warnings of vw 8.0 editor disappear permanently?

They are disturbing really:

<image001.png>

Johannes

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Staatlich anerkannte private Fachhochschule
NORDAKADEMIE
Gemeinnützige Aktiengesellschaft
Köllner Chaussee 11
25337 Elmshorn

Vorstand:
Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv. Vorstand)

Vorsitzender des Aufsichtsrats:
Dr. h.c. Hans-Heinrich Bruns

Sitz:
Elmshorn, Amtsgericht Pinneberg, HRB 1682

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Niall Ross (Cincom)

Re: CodeCritic warnings in source code editor?

Dear Vincent,
I agree that in your 2nd attached image, the rule's proposal is
actually wrong in general; it should not need user input to suppress it
for an unusual case. In code like

^self menuFor:
(view blobs
detect: [:each | ...]
ifNone: [^super menu])

the problem is the return in the ifNone:. The Smallint rule's final
match pattern

'`@object detect: [:`each | | `@temps| `@.Statements]
ifNone: [| `@temps1 | `@.Statements2. ^`@anything]'

catches it and does not check that the return is merely merely the
default case of a detect that otherwise assigns/passes its result. I'll
check whether rehandling that is already under consideration (and if
not, look at it).

Yours faithfully
Niall Ross

>I have the same kind of problem :
>
>[image: Images intégrées 1]
>Perhaps the code critic should verify if the solution proposed is not the
>message currently implemented ?
>
>I found that because I am upgrading from 7.9.1 to 8.0 ... and to implement
>a local menu in a graphical view I have the following code :
>
>[image: Images intégrées 2]
>I want to give the menu (In a kind of ControllerWithMenu) corresponding to
>the graphical element (unBlob) clicked.
>Sincerely, I can't see the interest of allSatisfy: in this case.
>
>
>
>
>2015-03-01 16:47 GMT+01:00 Johannes Brauer <[hidden email]>:
>
>
>
>> Thank you, Michael, I removed the class SmalllintDecoration and then the
>>code critic message disappeared. In my opinion it should be possible to
>>configure the editor so that the code critic message does not appear at
>>all.
>>
>> Where can I get vw 8.0.1?
>>
>> Johannes
>>
>>Am 28.02.2015 um 19:45 schrieb Michael Lucas-Smith <
>>[hidden email]>:
>>
>> You can take the code critic plugin out of the plugins collection on the
>>class side of SourceCodeEditor. However, the main issue here was a bug that
>>has been fixed in 8.0.1 where warnings would be displayed immediately upon
>>looking at a method, rather than when you edited and/or saved a method.
>>
>> Cheers,
>>Michael
>>
>> On 1 Mar 2015, at 3:43 am, Johannes Brauer <[hidden email]>
>>wrote:
>>
>> Georg,
>>
>> mainly I see the problem from a didactical point of view. It is quite
>>difficult to enable beginners to use of the do:-message correctly. And
>>then, when they try that for themselves, they always see these annoying
>>warnings.
>>I selected the implementation of select: as example because of the
>>particularly silly warning .
>>
>> Johannes
>>
>>Am 28.02.2015 um 14:39 schrieb Georg Heeg <[hidden email]>:
>>
>> Johannes,
>>
>> Your example is great. The warning message is plain wrong as this is the
>>implementation of select:
>> ha
>> Georg
>>
>> Georg Heeg eK, Dortmund und Köthen, HR Dortmund A 12812
>> Wallstraße 22, 06366 Köthen
>> Tel. +49-3496-214328, Fax +49-3496-214712
>>
>> *Von:* [hidden email] [mailto:[hidden email]
>><[hidden email]>] *Im Auftrag von *Johannes Brauer
>>*Gesendet:* Samstag, 28. Februar 2015 12:00
>>*An:* VW NC
>>*Betreff:* [vwnc] CodeCritic warnings in source code editor?
>>
>> Hi!
>>
>> Is there a way to make the code critic warnings of vw 8.0 editor
>>disappear permanently?
>> They are disturbing really:
>> <image001.png>
>>
>> Johannes
>>
>> ------------------------------
>>
>>
>>
>>Staatlich anerkannte private Fachhochschule
>>NORDAKADEMIE
>>Gemeinnützige Aktiengesellschaft
>>Köllner Chaussee 11
>>25337 Elmshorn
>>
>>Vorstand:
>>Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv.
>>Vorstand)
>>
>>Vorsitzender des Aufsichtsrats:
>>Dr. h.c. Hans-Heinrich Bruns
>>
>>Sitz:
>>Elmshorn, Amtsgericht Pinneberg, HRB 1682
>>
>>
>>
>>------------------------------
>>
>>
>>Staatlich anerkannte private Fachhochschule
>>NORDAKADEMIE
>>Gemeinnützige Aktiengesellschaft
>>Köllner Chaussee 11
>>25337 Elmshorn
>>
>>Vorstand:
>>Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv.
>>Vorstand)
>>
>>Vorsitzender des Aufsichtsrats:
>>Dr. h.c. Hans-Heinrich Bruns
>>
>>Sitz:
>>Elmshorn, Amtsgericht Pinneberg, HRB 1682
>>
>> _______________________________________________
>>vwnc mailing list
>>[hidden email]
>>http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
>>
>>
>>
>>
>>------------------------------
>>
>>
>>Staatlich anerkannte private Fachhochschule
>>NORDAKADEMIE
>>Gemeinnützige Aktiengesellschaft
>>Köllner Chaussee 11
>>25337 Elmshorn
>>
>>Vorstand:
>>Prof. Dr. Georg Plate (Vorsitzender), Dipl.-Ing. Jörg Meier (stellv.
>>Vorstand)
>>
>>Vorsitzender des Aufsichtsrats:
>>Dr. h.c. Hans-Heinrich Bruns
>>
>>Sitz:
>>Elmshorn, Amtsgericht Pinneberg, HRB 1682
>>
>>
>>_______________________________________________
>>vwnc mailing list
>>[hidden email]
>>http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
>>
>>
>>
>>
>
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>vwnc mailing list
>[hidden email]
>http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
>
>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Michael Lucas-Smith-2

Re: CodeCritic warnings in source code editor?

In reply to this post by jb

>
> Where can I get vw 8.0.1?

It’s not out yet. Not too far off though.

Cheers,
Michael
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc