Smalltalk › Pharo › Pharo Smalltalk Users

Commit request on PBKDF2

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

tinchodias

Commit request on PBKDF2

Hello Udo and PBKDF2 users,

Thanks for the PBKDF2 [1] project; it's been useful in the mongotalk
project [2]. Now, I write you with a small change proposal due to some
problems I have because of name conflicts with classes at Cryptography
package [3] (which ConfigurationOfPBKDF2 declares as a dependency).

I analyzed what are the concrete dependencies in PBKDF2 to Cryptography:

- Core uses SHA1, which is in Pharo at least since Pharo 4.0
- Tests use the ByteArray>>fromHexString: method extension, which
could be copied.

(BTW also thanks to Christophe Demarey and collaborators for the
Dependencies Analyzer, it's very useful!)

Then (unless I'm missing something), PBKDF2 doesn't really need
Cryptography as dependency. I can commit the changes if you agree (I
see the repository is public). It works locally.

Regards,
Martín

[1] http://smalltalkhub.com/#!/~UdoSchneider/PBKDF2
[2] https://github.com/pharo-nosql/mongotalk
[3] http://smalltalkhub.com/#!/~Cryptography/Cryptography/

Udo Schneider

Re: Commit request on PBKDF2

Hi Martín,

sure - go ahead and change/fix it.

JFYI - one of the last things on my todo list was to move PBKDF2 to
github. If somebody volunteers I'm happy to pass on any maintainer
related "things". :-)

I won't have the time to do anything serious in Smalltalk for the
foreseeable future anyways :-(

CU,

Udo

On 06.05.18 01:46, Martin Dias wrote:

> Hello Udo and PBKDF2 users,
>
> Thanks for the PBKDF2 [1] project; it's been useful in the mongotalk
> project [2]. Now, I write you with a small change proposal due to some
> problems I have because of name conflicts with classes at Cryptography
> package [3] (which ConfigurationOfPBKDF2 declares as a dependency).
>
> I analyzed what are the concrete dependencies in PBKDF2 to Cryptography:
>
> - Core uses SHA1, which is in Pharo at least since Pharo 4.0
> - Tests use the ByteArray>>fromHexString: method extension, which
> could be copied.
>
> (BTW also thanks to Christophe Demarey and collaborators for the
> Dependencies Analyzer, it's very useful!)
>
> Then (unless I'm missing something), PBKDF2 doesn't really need
> Cryptography as dependency. I can commit the changes if you agree (I
> see the repository is public). It works locally.
>
> Regards,
> Martín
>
> [1] http://smalltalkhub.com/#!/~UdoSchneider/PBKDF2
> [2] https://github.com/pharo-nosql/mongotalk
> [3] http://smalltalkhub.com/#!/~Cryptography/Cryptography/
>
>