Compile error and regression with Swazoo

Hi,

gst doesn't compile here is the fix:

diff --git a/libgst/interp.inl b/libgst/interp.inl
index 50aadd3..e18e27c 100644
--- a/libgst/interp.inl
+++ b/libgst/interp.inl
@@ -61,7 +61,7 @@ static inline OOP mul_with_check (OOP op1, OOP op2,
                                    mst_Boolean *overflow);

  /* Generate random number using the Mersenne Twister technique */
-static inline uint32_t random_next (void);
+static inline uint32_t random_next (uint32_t *);
  static inline void random_generate (uint32_t *);

  /* These do not need overflow checking.  */


And Swazoo tests failed when launching make check

Swazoo.SiteIdentifierTest>>#testIPMismatch

The stack trace :

Swazoo.SiteIdentifierTest>>#testIPMismatch did not understand
#hostAddressString
TestVerboseLog>>logError: (SUnit.star#VFS.ZipFile/SUnit.st:608)
Swazoo.SiteIdentifierTest(TestCase)>>logError:
(SUnit.star#VFS.ZipFile/SUnit.st:870)
[] in TestResult>>runCase: (SUnit.star#VFS.ZipFile/SUnit.st:443)
MessageNotUnderstood(Exception)>>activateHandler: (ExcHandling.st:515)
MessageNotUnderstood(Exception)>>signal (ExcHandling.st:254)
String(Object)>>doesNotUnderstand: #hostAddressString (SysExcept.st:1442)
Swazoo.SiteIdentifier>>ipMatch: (Swazoo.star#VFS.ZipFile/HTTP.st:1763)
Swazoo.SiteIdentifier>>valueMatch: (Swazoo.star#VFS.ZipFile/HTTP.st:1842)
Swazoo.SiteIdentifier(Swazoo.URIIdentifier)>>match:
(Swazoo.star#VFS.ZipFile/HTTP.st:1667)
Swazoo.SiteIdentifierTest>>testIPMismatch
(Swazoo.star#VFS.ZipFile/Tests.st:1563)
Swazoo.SiteIdentifierTest(TestCase)>>performTest
(SUnit.star#VFS.ZipFile/SUnit.st:1080)
optimized [] in TestCase>>runCase (SUnit.star#VFS.ZipFile/SUnit.st:1036)
BlockClosure>>ensure: (BlkClosure.st:268)
BlockClosure>>sunitEnsure: (SUnit.star#VFS.ZipFile/SUnitPreload.st:89)
Swazoo.SiteIdentifierTest(TestCase)>>runCase
(SUnit.star#VFS.ZipFile/SUnit.st:1032)
[] in TestResult>>runCase: (SUnit.star#VFS.ZipFile/SUnit.st:434)
BlockClosure>>on:do: (BlkClosure.st:193)
BlockClosure>>sunitOn:do: (SUnit.star#VFS.ZipFile/SUnitPreload.st:94)
[] in TestResult>>runCase: (SUnit.star#VFS.ZipFile/SUnit.st:435)
BlockClosure>>on:do: (BlkClosure.st:193)
BlockClosure>>sunitOn:do: (SUnit.star#VFS.ZipFile/SUnitPreload.st:94)
TestResult>>runCase: (SUnit.star#VFS.ZipFile/SUnit.st:440)
Swazoo.SiteIdentifierTest(TestCase)>>run:
(SUnit.star#VFS.ZipFile/SUnit.st:1029)
[] in TestSuite>>run: (SUnit.star#VFS.ZipFile/SUnit.st:30)
OrderedCollection>>do: (OrderColl.st:66)
TestSuite>>run: (SUnit.star#VFS.ZipFile/SUnit.st:27)
[] in TestSuite>>run: (SUnit.star#VFS.ZipFile/SUnit.st:30)
OrderedCollection>>do: (OrderColl.st:66)
TestSuite>>run: (SUnit.star#VFS.ZipFile/SUnit.st:27)
[] in TestSuite>>run (SUnit.star#VFS.ZipFile/SUnit.st:21)
BlockClosure>>ensure: (BlkClosure.st:268)
BlockClosure>>sunitEnsure: (SUnit.star#VFS.ZipFile/SUnitPreload.st:89)
TestSuite>>run (SUnit.star#VFS.ZipFile/SUnit.st:19)
[] in TestSuitesScripter class>>run:quiet:verbose:
(SUnit.star#VFS.ZipFile/SUnitScript.st:33)
[] in TestSuitesScripter class>>withScript:do:
(SUnit.star#VFS.ZipFile/SUnitScript.st:87)
BlockClosure>>ensure: (BlkClosure.st:268)
BlockClosure>>sunitEnsure: (SUnit.star#VFS.ZipFile/SUnitPreload.st:89)
TestSuitesScripter class>>withScript:do:
(SUnit.star#VFS.ZipFile/SUnitScript.st:86)
TestSuitesScripter class>>run:quiet:verbose:
(SUnit.star#VFS.ZipFile/SUnitScript.st:22)
UndefinedObject>>executeStatements (scripts/Test.st:113)

Cheers,
Gwen


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 08/05/2011 11:47 PM, Gwenaël Casaccio wrote:
> Hi,
>
> gst doesn't compile here is the fix:

sorry, both like issues introduced by myself. I will look into a patch after
breakfast.


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 08/05/2011 11:47 PM, Gwenaël Casaccio wrote:
this part is correct, I wonder if I really didn't compile libgst after doing
the change (the patch is in my tree for almost a week though).

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 08/05/2011 11:47 PM, Gwenaël Casaccio wrote:

>
> Swazoo.SiteIdentifierTest>>#testIPMismatch did not understand #hostAddressString

sorry about this one too. SiteIdentifier clearly says that >>#ip should be a
string. So the bug in my case is that somewhere it turns out to be a SpIPAddress.

Paolo could you please revert 4cdde5dc6eaf87cc24b2dea1da7732cfada7e6f7 in both
stable-3.2 and master. I am sorry for having caused a regression.

holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 08/06/2011 03:30 AM, Holger Hans Peter Freyther wrote:
> On 08/05/2011 11:47 PM, Gwenaël Casaccio wrote:

> Paolo could you please revert 4cdde5dc6eaf87cc24b2dea1da7732cfada7e6f7 in both
> stable-3.2 and master. I am sorry for having caused a regression.

I am moving the hostAddressString into the HTTPRequest. All test cases pass
and my manual test with binding to localhost is passing too.


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 08/06/2011 02:51 AM, Holger Hans Peter Freyther wrote:
>> >  -static inline uint32_t random_next (void);
>> >  +static inline uint32_t random_next (uint32_t *);
>> >    static inline void random_generate (uint32_t *);
> this part is correct, I wonder if I really didn't compile libgst after doing
> the change (the patch is in my tree for almost a week though).

Nah, my fault.  You sent it with only a change to random_generate and I
"assumed" sparse didn't complain because random_next had no arguments.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk