'Contribute a fix to Pharo' for new Iceberg ?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

'Contribute a fix to Pharo' for new Iceberg ?

Sven Van Caekenberghe-2
Hi,

I got the new Iceberg working on the latest Pharo 7 (used it to commit something to P3) - authentication should be OK then I guess. It feels much better.

I would like to try contributing to Pharo again.

Has https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo been updated for the new Iceberg ?

Have things become simpler ?

I also forgot the easy/short git command to bring my fork up to date (if I have to do this myself).

Sven


Reply | Threaded
Open this post in threaded view
|

Re: 'Contribute a fix to Pharo' for new Iceberg ?

Marcus Denker-4


> On 23 Apr 2018, at 11:38, Sven Van Caekenberghe <[hidden email]> wrote:
>
> Hi,
>
> I got the new Iceberg working on the latest Pharo 7 (used it to commit something to P3) - authentication should be OK then I guess. It feels much better.
>
> I would like to try contributing to Pharo again.
>
> Has https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo been updated for the new Iceberg ?
>
No, not yet…

> Have things become simpler ?
>


The ways that I found how to do it: no. But I need more input from Esteban, I am for sure doing things wrong.
(this is why I did not start to update the tutorial with the way I am doing PRs now)

        Marcus
Reply | Threaded
Open this post in threaded view
|

Re: 'Contribute a fix to Pharo' for new Iceberg ?

EstebanLM


> On 23 Apr 2018, at 11:46, Marcus Denker <[hidden email]> wrote:
>
>
>
>> On 23 Apr 2018, at 11:38, Sven Van Caekenberghe <[hidden email]> wrote:
>>
>> Hi,
>>
>> I got the new Iceberg working on the latest Pharo 7 (used it to commit something to P3) - authentication should be OK then I guess. It feels much better.
>>
>> I would like to try contributing to Pharo again.
>>
>> Has https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo been updated for the new Iceberg ?
>>
> No, not yet…
>
>> Have things become simpler ?
>>
>
>
> The ways that I found how to do it: no. But I need more input from Esteban, I am for sure doing things wrong.
> (this is why I did not start to update the tutorial with the way I am doing PRs now)

we are finishing an iteration that will speed things up.
IMO it should be a lot simpler, but well.
Tomorrow I will record a new “how to contribute”.

Esteban

>
> Marcus


Reply | Threaded
Open this post in threaded view
|

Re: 'Contribute a fix to Pharo' for new Iceberg ?

Sven Van Caekenberghe-2


> On 23 Apr 2018, at 12:03, Esteban Lorenzano <[hidden email]> wrote:
>
>
>
>> On 23 Apr 2018, at 11:46, Marcus Denker <[hidden email]> wrote:
>>
>>
>>
>>> On 23 Apr 2018, at 11:38, Sven Van Caekenberghe <[hidden email]> wrote:
>>>
>>> Hi,
>>>
>>> I got the new Iceberg working on the latest Pharo 7 (used it to commit something to P3) - authentication should be OK then I guess. It feels much better.
>>>
>>> I would like to try contributing to Pharo again.
>>>
>>> Has https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo been updated for the new Iceberg ?
>>>
>> No, not yet…
>>
>>> Have things become simpler ?
>>>
>>
>>
>> The ways that I found how to do it: no. But I need more input from Esteban, I am for sure doing things wrong.
>> (this is why I did not start to update the tutorial with the way I am doing PRs now)
>
> we are finishing an iteration that will speed things up.
> IMO it should be a lot simpler, but well.
> Tomorrow I will record a new “how to contribute”.

OK, I will wait a day or two.
But please (someone) also write a short document.

> Esteban
>
>>
>> Marcus


Reply | Threaded
Open this post in threaded view
|

Re: 'Contribute a fix to Pharo' for new Iceberg ?

Marcus Denker-4
>>
>> we are finishing an iteration that will speed things up.
>> IMO it should be a lot simpler, but well.
>> Tomorrow I will record a new “how to contribute”.
>
> OK, I will wait a day or two.
> But please (someone) also write a short document.
>

I will update the description with the content of the video
(and I will makes sure that all outdate content is not linked to)

        Marcus


Reply | Threaded
Open this post in threaded view
|

Re: 'Contribute a fix to Pharo' for new Iceberg ?

Torsten Bergmann
In reply to this post by Sven Van Caekenberghe-2
Hi Sven

if you like you can also use my "https://github.com/astares/pharo-contributor" - at least
on Ubuntu (where I wrote, tested and use it)

- just clone the project
- use "download.sh" to download latest P7 automatically and started, it will also load a contribution
  help book I did where all is explained

- For a quick start usually you just have to go to the very last help page of the appearing help tool and click
  on

    CPTCloneTool run

  to automagically download and update you fork (after giving your Github username)

Then you can contribute as usual by having a branch for a bug number in Iceberg and so on.

Side note:
=========
Currently new Iceberg still has some trouble:
 - one has to discard the changes on Fuel (as there are none) after the automatic synch of the tool
 - one has to "LGitLibrary initialize" when one reopens a saved image (see start.sh), otherwise VM will crash
I already notfied Esteban.

For questions on my workflow with the tool: I'm usually available on Discord.

I'm sure there will also be an update of the official contribution tutorial and AFAIK Esteban
want to do some screencasts.

Thx
T.


> Gesendet: Montag, 23. April 2018 um 11:38 Uhr
> Von: "Sven Van Caekenberghe" <[hidden email]>
> An: "Pharo Development List" <[hidden email]>
> Betreff: [Pharo-dev] 'Contribute a fix to Pharo' for new Iceberg ?
>
> Hi,
>
> I got the new Iceberg working on the latest Pharo 7 (used it to commit something to P3) - authentication should be OK then I guess. It feels much better.
>
> I would like to try contributing to Pharo again.
>
> Has https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo been updated for the new Iceberg ?
>
> Have things become simpler ?
>
> I also forgot the easy/short git command to bring my fork up to date (if I have to do this myself).
>
> Sven
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: 'Contribute a fix to Pharo' for new Iceberg ?

Marcus Denker-4


> On 23 Apr 2018, at 12:47, Torsten Bergmann <[hidden email]> wrote:
>
> Hi Sven
>
> if you like you can also use my "https://github.com/astares/pharo-contributor" - at least
> on Ubuntu (where I wrote, tested and use it)
>
Ah, yes, this reminds me to  have a look at your contribution tool again, too. (Next week… after holidays).

        Marcus