Hello,
-- So, I would like to contribute. I read objects and protocols and developper certificate and I am reading the blue book (well, it is going to take a while, since I am reading it with other things, sice it is not my priority... for now :) ), but I am kind lost of where it would be appropriate to start, what would you suggest? []s, Vitor You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Hi Vitor, I think it is great news that you would like to contribute.is a failing test. This failing test only fails on Windows. '\'. So how about you fix the failing test under windows? On Wed, Sep 18, 2013 at 3:07 AM, Vitor Cruz <[hidden email]> wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Ok, I am already looking at it and it happens that the production code is using File.separator while the test is using the "/" string. Both are correct and are interoperable, but some people are afraid of using "/" or prefer to use File.separator in order to have more assistance from IDE, others prefer "/" because it is simpler and easy to read. My question is, should I change only the tests to use File.separator, or should I change the production code to use "/"?
-- []s, Vitor On Tuesday, September 17, 2013 6:37:50 PM UTC-3, jamesl wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Ah - all places should use File.separator. Does the test still fail under windows when using it? Sent from Hyperspace. -- You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
No, it solves the problem, I just needed to know the right convention, I will adjust it.
-- On Wednesday, September 18, 2013 5:29:49 PM UTC-3, jamesl wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Well, it solves the problem with shouldFindSourceInFile, but not with shouldFindSourceInJar, explanation can be found here:
-- http://stackoverflow.com/questions/13846000/file-separators-of-path-name-of-zipentry and here: http://www.lingala.net/zip4j/forum/index.php?topic=79.0 I think the best is to use "/" instead of File.separator in both production and test code, it solves both problems. []s, Vitor On Wednesday, September 18, 2013 9:19:44 PM UTC-3, Vitor Cruz wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Please can you make the change, and then issue a pull request with your Developer Agreement comment in the pull request?On Thu, Sep 19, 2013 at 11:20 AM, Vitor Cruz <[hidden email]> wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Might I recommend using Jar.File.Separator instead of hard-coding the separator? On Sep 18, 2013 9:23 PM, "James Ladd" <[hidden email]> wrote:
--
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Agreed - I think the constant should be used Sent from Hyperspace. -- You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
I am sorry Alfonso, but I could not find Jar.File.Separator, can you point me to where this constant is? Or did you suggested that I should create a constant for that purpose? On Wed, Sep 18, 2013 at 11:39 PM, James Ladd <[hidden email]> wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Ok, so I will: There are other issues preventing the tests to pass that I already corrected. After all that, clean install still fails, but because of a problem with exec-maven-plugin that I didn't dig much deep yet. I will prepare a patch with what I've already done and leave that other problem for later. I don't know if I will have time to do that before weekend, but I will try.1- Create a constant representing the zip file separator and use it for jar; 2- Leave the File.separator for normal file and adjust the test. On Thu, Sep 19, 2013 at 1:53 PM, Alfonso Guerra <[hidden email]> wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Forget to say it here (don't know if it is necessary), but I sent the pull request. :) On Thu, Sep 19, 2013 at 3:29 PM, Vitor Medina Cruz <[hidden email]> wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Thank you - ill try to incorporate ASAP At JavaOne right now making everyone aware of Redline Sent from Hyperspace. -- You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Awsome! When you have time please send a note telling us how was at JavaOne :) On Wed, Sep 25, 2013 at 3:04 PM, James Ladd <[hidden email]> wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Will do - lots of polyglot talk and I'm working on David Rose and team to get some support for Redline - fingers crossed. Sent from Hyperspace. -- You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
"Merged #183."
-- So, what's next? :) I sow some tickets on github, but I am not sure of what would be better to do right now. On Wednesday, September 25, 2013 3:12:22 PM UTC-3, jamesl wrote:
You received this message because you are subscribed to the Google Groups "Redline Smalltalk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
Free forum by Nabble | Edit this page |