Smalltalk › Pharo › Pharo Smalltalk Developers

Contributing to Pharo

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

104 messages Options

1234 ... 6

David Allouche

Contributing to Pharo

Hello,

I believe the Contributing to Pharo page http://pharo.org/contribute-propose-fix

is out of date.

I found a bug

https://pharo.fogbugz.com/f/cases/17396/MonticelloRepositoryBrowser-example-MNU

and a made a fix in in a clean image (50525), created by the newly fixed PharoLauncher.

Then I followed the instruction on the page.

Create a slice (group of packages):
Open the Monticello Browser.
Open the Slice Maker by clicking the "Slice" button.
In Slice Maker enter the Fogbugz issue number and "grab" the issue summary.
Select all dirty packages affected by your bug fix.

I have no idea how the "list of dirty packages" is generated, but

it shows a bunch of packages I have not touched
it does not show the package that contains my fix (Spec-Tools)

I looked in the world menu, and I found this menu item called "Komitter". That sounded like a good candidate.

Now, I guess I should select Pharo50Inbox as the Remote, write a commit message, click Ok and hope for the best.

Is that right?

I guess contributors are expected to use a recent image. So I think it would be good that someone updates the documentation. Or fix the slice maker. Or both.

stepharo

Re: Contributing to Pharo

Le 15/1/16 20:45, David Allouche a écrit :

Hello,

I believe the Contributing to Pharo page http://pharo.org/contribute-propose-fix

is out of date.

Certainly. Time passes so fast.

I found a bug

https://pharo.fogbugz.com/f/cases/17396/MonticelloRepositoryBrowser-example-MNU

and a made a fix in in a clean image (50525), created by the newly fixed PharoLauncher.

Then I followed the instruction on the page.

Create a slice (group of packages):

Open the Monticello Browser.

Open the Slice Maker by clicking the "Slice" button.

In Slice Maker enter the Fogbugz issue number and "grab" the issue summary.

Select all dirty packages affected by your bug fix.

I have no idea how the "list of dirty packages" is generated, but

it shows a bunch of packages I have not touched

Sometimes MC is confused and some packages get dirty while they are not.

it does not show the package that contains my fix (Spec-Tools)

This is strange. And MC shows the package as dirty? Then this is a bug.

I looked in the world menu, and I found this menu item called "Komitter". That sounded like a good candidate.

Now, I guess I should select Pharo50Inbox as the Remote, write a commit message, click Ok and hope for the best.

Sounds correct.
I'm not sure that I understand Komitter :).

Is that right?

I guess contributors are expected to use a recent image.

Yes it is always better and also to only publish one change at a time (which is annoying when you have sequences of changes but
nice to track down changes).

So I think it would be good that someone updates the documentation. Or fix the slice maker. Or both.

Can you reproduce the bug?

BTW it would be nice that you print and sign the pharo license, then you send us a scanned or surface mail version
and we will archive it.

We ask that to every contributors.

Stef

David Allouche

Re: Contributing to Pharo

On 15 Jan 2016, at 21:01, stepharo <[hidden email]> wrote:

Le 15/1/16 20:45, David Allouche a écrit :

it does not show the package that contains my fix (Spec-Tools)
This is strange. And MC shows the package as dirty? Then this is a bug.

I do not know how MC shows a package as dirty.

And anyway, I ended up fiddling my way into uploading the version to smalltalkhub (I think I just clicked Save in Monticello Browser). So it no longer shows as dirty. But apparently that did not provide the fogzbugz issue metadata… So it might be not dirty anymore. But then I have no idea what to do now to upload it correctly.

So I think it would be good that someone updates the documentation. Or fix the slice maker. Or both.
Can you reproduce the bug?

I cannot not reproduce it. I have no idea at all how people actually manage to use Slice Maker in a recent image.

Have you tried with a recent

BTW it would be nice that you print and sign the pharo license, then you send us a scanned or surface mail version
and we will archive it.

Surface mail, is that a kind of new social network thing? I'm afraid I got a bit behind the times those past few years.

We ask that to every contributors.

No problem, I'll do that. Copyright paperwork is important.

Nicolai Hess-3-2

Re: Contributing to Pharo

In reply to this post by stepharo

2016-01-15 21:01 GMT+01:00 stepharo <[hidden email]>:

Le 15/1/16 20:45, David Allouche a écrit :

Hello,

I believe the Contributing to Pharo page http://pharo.org/contribute-propose-fix

is out of date.

Certainly. Time passes so fast.

Hm, I do this on a daily basis and it works for me.

I found a bug

https://pharo.fogbugz.com/f/cases/17396/MonticelloRepositoryBrowser-example-MNU

and a made a fix in in a clean image (50525), created by the newly fixed PharoLauncher.

Then I followed the instruction on the page.

Create a slice (group of packages):

Open the Monticello Browser.

Open the Slice Maker by clicking the "Slice" button.

In Slice Maker enter the Fogbugz issue number and "grab" the issue summary.

Select all dirty packages affected by your bug fix.

I have no idea how the "list of dirty packages" is generated, but

it shows a bunch of packages I have not touched

Sometimes MC is confused and some packages get dirty while they are not.

we had fixed a couple of bugs on how the repository version is searched and loaded.

Sometimes it still loads (or compares against) the wrong version.

Deleting the package-cache (package-cache folder) may help

it does not show the package that contains my fix (Spec-Tools)

This is strange. And MC shows the package as dirty? Then this is a bug.

I looked in the world menu, and I found this menu item called "Komitter". That sounded like a good candidate.

Now, I guess I should select Pharo50Inbox as the Remote, write a commit message, click Ok and hope for the best.

Sounds correct.
I'm not sure that I understand Komitter :).

Is that right?

I don't use komitter, I find it easier with the step described on the how-to-contribute page

I guess contributors are expected to use a recent image.

Yes it is always better and also to only publish one change at a time (which is annoying when you have sequences of changes but
nice to track down changes).

So I think it would be good that someone updates the documentation. Or fix the slice maker. Or both.

Can you reproduce the bug?

BTW it would be nice that you print and sign the pharo license, then you send us a scanned or surface mail version
and we will archive it.

We ask that to every contributors.

Stef

Nicolai Hess-3-2

Re: Contributing to Pharo

In reply to this post by David Allouche

2016-01-15 23:16 GMT+01:00 David Allouche <[hidden email]>:

On 15 Jan 2016, at 21:01, stepharo <[hidden email]> wrote:

Le 15/1/16 20:45, David Allouche a écrit :

it does not show the package that contains my fix (Spec-Tools)
This is strange. And MC shows the package as dirty? Then this is a bug.

I do not know how MC shows a package as dirty.

This is how it should look in slice maker (left side) and monticello browser (right side).

The " * " marks dirty packages.

PharoScreenshot.png (262K) Download Attachment

Nicolai Hess-3-2

Re: Contributing to Pharo

2016-01-15 23:23 GMT+01:00 Nicolai Hess <[hidden email]>:

2016-01-15 23:16 GMT+01:00 David Allouche <[hidden email]>:

On 15 Jan 2016, at 21:01, stepharo <[hidden email]> wrote:

Le 15/1/16 20:45, David Allouche a écrit :

it does not show the package that contains my fix (Spec-Tools)
This is strange. And MC shows the package as dirty? Then this is a bug.

I do not know how MC shows a package as dirty.

This is how it should look in slice maker (left side) and monticello browser (right side).
The " * " marks dirty packages.

Maybe, we should include some screenshots on the "Contribute to Pharo" page.

CyrilFerlicot

Re: Contributing to Pharo

Le 15/01/2016 23:24, Nicolai Hess a écrit :
>
> Maybe, we should include some screenshots on the "Contribute to Pharo" page.
>
>

And maybe a screencast :)

--
Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France

signature.asc (836 bytes) Download Attachment

David Allouche

Re: Contributing to Pharo

In reply to this post by Nicolai Hess-3-2

On 15 Jan 2016, at 23:23, Nicolai Hess <[hidden email]> wrote:
2016-01-15 23:16 GMT+01:00 David Allouche <[hidden email]>:
On 15 Jan 2016, at 21:01, stepharo <[hidden email]> wrote:
Le 15/1/16 20:45, David Allouche a écrit :
it does not show the package that contains my fix (Spec-Tools)
This is strange. And MC shows the package as dirty? Then this is a bug.

I do not know how MC shows a package as dirty.

This is how it should look in slice maker (left side) and monticello browser (right side).
The " * " marks dirty packages.

Okay, got that.

So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello, unexpected contextual menu showing up when I do Cmd-T in the debugger, infinite recursions when trying to debug through the MonticelloRepositoryBrowser... All things that are so obvious that I have trouble believing they are actual bugs. Maybe there was something wrong in how my image was generated. I will try building another image.

I also wonder… so this "list of dirty packages" is actually a list of every package where some of them are marked dirty? I mean, why is it not just the list of dirty package, as the name implies?

David Allouche

Re: Contributing to Pharo

> On 15 Jan 2016, at 23:33, David Allouche <[hidden email]> wrote:
>
> So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello, unexpected contextual menu showing up when I do Cmd-T in the debugger, infinite recursions when trying to debug through the MonticelloRepositoryBrowser... All things that are so obvious that I have trouble believing they are actual bugs. Maybe there was something wrong in how my image was generated. I will try building another image.

Built a new latest image. Now I no longer have any syntax highlighting in the debuggers or class browser…

Now, people should use the latest image for dev. But apparently the latest image is more often broken than not. What is the trick?

Sorry for the unpleasant messages, but I am getting incredibly frustrated.

Nicolai Hess-3-2

Re: Contributing to Pharo

In reply to this post by David Allouche

2016-01-15 23:33 GMT+01:00 David Allouche <[hidden email]>:

On 15 Jan 2016, at 23:23, Nicolai Hess <[hidden email]> wrote:
2016-01-15 23:16 GMT+01:00 David Allouche <[hidden email]>:
On 15 Jan 2016, at 21:01, stepharo <[hidden email]> wrote:
Le 15/1/16 20:45, David Allouche a écrit :
it does not show the package that contains my fix (Spec-Tools)
This is strange. And MC shows the package as dirty? Then this is a bug.

I do not know how MC shows a package as dirty.

This is how it should look in slice maker (left side) and monticello browser (right side).
The " * " marks dirty packages.

Okay, got that.

So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello,

this is a known error from the "recent" change for rubric text component

unexpected contextual menu showing up when I do Cmd-T in the debugger,

known ( from the recent changes for debugger :) )

infinite recursions when trying to debug through the MonticelloRepositoryBrowser...

I don't know this error. But I don't think "this" MonticelloRepositoryBrowser is actually used.

All things that are so obvious that I have trouble believing they are actual bugs. Maybe there was something wrong in how my image was generated. I will try building another image.

I also wonder… so this "list of dirty packages" is actually a list of every package where some of them are marked dirty? I mean, why is it not just the list of dirty package, as the name implies?

Nicolai Hess-3-2

Re: Contributing to Pharo

In reply to this post by David Allouche

2016-01-15 23:48 GMT+01:00 David Allouche <[hidden email]>:

> On 15 Jan 2016, at 23:33, David Allouche <[hidden email]> wrote:
>
> So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello, unexpected contextual menu showing up when I do Cmd-T in the debugger, infinite recursions when trying to debug through the MonticelloRepositoryBrowser... All things that are so obvious that I have trouble believing they are actual bugs. Maybe there was something wrong in how my image was generated. I will try building another image.

Built a new latest image. Now I no longer have any syntax highlighting in the debuggers or class browser…

Now, people should use the latest image for dev. But apparently the latest image is more often broken than not. What is the trick?

Ah, that's not true. I work this way every day. And yes it can happen that the latest image is broken but, not that often.

Sorry for the unpleasant messages, but I am getting incredibly frustrated.

I am now (at this moment) working with the image version 50528.

David Allouche

Re: Contributing to Pharo

In reply to this post by Nicolai Hess-3-2

On 15 Jan 2016, at 23:49, Nicolai Hess <[hidden email]> wrote:

2016-01-15 23:33 GMT+01:00 David Allouche <[hidden email]>:

So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello,

this is a known error from the "recent" change for rubric text component

unexpected contextual menu showing up when I do Cmd-T in the debugger,

known ( from the recent changes for debugger :) )

infinite recursions when trying to debug through the MonticelloRepositoryBrowser...

I don't know this error. But I don't think "this" MonticelloRepositoryBrowser is actually used.

I think that was actually a bug in the debugger, or inspector, not in MonticelloRepositoryBrowser.

And yes, this appear to be dead code. I found it before finding the actual browser, and thought it might be a good place to start exploring Monticello.

I tried the old debugger in my new latest image (in the hope that syntax highlighting would not be broken there), but I realised it advertised no keyboard shortcut for stepping through the code…

Starting to wonder if I should go back to spending my evenings playing Elite Dangerous, and come back in a few weeks when stuff is hopefully less buggy everywhere :-(

David Allouche

Re: Contributing to Pharo

In reply to this post by Nicolai Hess-3-2

On 15 Jan 2016, at 23:55, Nicolai Hess <[hidden email]> wrote:

2016-01-15 23:48 GMT+01:00 David Allouche <[hidden email]>:

Built a new latest image. Now I no longer have any syntax highlighting in the debuggers or class browser…

Now, people should use the latest image for dev. But apparently the latest image is more often broken than not. What is the trick?

Ah, that's not true. I work this way every day. And yes it can happen that the latest image is broken but, not that often.

Sorry for the unpleasant messages, but I am getting incredibly frustrated.

I am now (at this moment) working with the image version 50528.

Yes, that's the one where syntax highlighting appears broken.

David Allouche

Re: Contributing to Pharo

> On 15 Jan 2016, at 23:58, David Allouche <[hidden email]> wrote:
>>
>> I am now (at this moment) working with the image version 50528.
>
> Yes, that's the one where syntax highlighting appears broken.

Nevermind, it works… I must have imagined it did not, or a transient bout of colour-blindness…

Nicolai Hess-3-2

Re: Contributing to Pharo

2016-01-16 0:07 GMT+01:00 David Allouche <[hidden email]>:

> On 15 Jan 2016, at 23:58, David Allouche <[hidden email]> wrote:
>>
>> I am now (at this moment) working with the image version 50528.
>
> Yes, that's the one where syntax highlighting appears broken.

Nevermind, it works… I must have imagined it did not, or a transient bout of colour-blindness…

We have some problems with the current syntax highlighting, somehow somtimes the highlighting is slow or paused.

We did not found a solution yet :
16020 Syntax Highlighting Rubric: First shows non-highlighted text, then color. Looks slow

Henrik Sperre Johansen

Re: Contributing to Pharo

In reply to this post by David Allouche

Or, try a stable release.

Whenever I try developing on the latest version, I end up getting disrupted by bugs in the core tools 70-80% of the time.

For released versions, in 1.4 it was maybe 5%, in 2.0 40%, in 3.0 20%, in 4.0 10%

So at least it's been trending downwards, though I expect a totally new debugger, image format, RBParser unification and new FFI in 5.0 will keep causing problems for a quite a while.

Cheers,

Henry

On Fri, Jan 15, 2016 at 11:57 PM, David Allouche <[hidden email]> wrote:

On 15 Jan 2016, at 23:49, Nicolai Hess <[hidden email]> wrote:

2016-01-15 23:33 GMT+01:00 David Allouche <[hidden email]>:

So yes, it's broken, but maybe it's something else entirely, I get new reproducible errors every few minutes: errors when activating pretty printing in the diff viewer in Monticello,

this is a known error from the "recent" change for rubric text component

unexpected contextual menu showing up when I do Cmd-T in the debugger,

known ( from the recent changes for debugger :) )

infinite recursions when trying to debug through the MonticelloRepositoryBrowser...

I don't know this error. But I don't think "this" MonticelloRepositoryBrowser is actually used.

I think that was actually a bug in the debugger, or inspector, not in MonticelloRepositoryBrowser.

And yes, this appear to be dead code. I found it before finding the actual browser, and thought it might be a good place to start exploring Monticello.

I tried the old debugger in my new latest image (in the hope that syntax highlighting would not be broken there), but I realised it advertised no keyboard shortcut for stepping through the code…

Starting to wonder if I should go back to spending my evenings playing Elite Dangerous, and come back in a few weeks when stuff is hopefully less buggy everywhere :-(

Ben Coman

Re: Contributing to Pharo

In reply to this post by David Allouche

On Sat, Jan 16, 2016 at 3:45 AM, David Allouche <[hidden email]> wrote:

Hello,

I believe the Contributing to Pharo page http://pharo.org/contribute-propose-fix
is out of date.

I found a bug
https://pharo.fogbugz.com/f/cases/17396/MonticelloRepositoryBrowser-example-MNU

and a made a fix in in a clean image (50525), created by the newly fixed PharoLauncher.

Then I followed the instruction on the page.
Create a slice (group of packages):
Open the Monticello Browser.
Open the Slice Maker by clicking the "Slice" button.
In Slice Maker enter the Fogbugz issue number and "grab" the issue summary.
Select all dirty packages affected by your bug fix.
I have no idea how the "list of dirty packages" is generated, but
it shows a bunch of packages I have not touched
it does not show the package that contains my fix (Spec-Tools)

I am curious on item 2. Was this just because the dirty package was sorted to the top of the list (per Nicolai's snapshots)?

I looked in the world menu, and I found this menu item called "Komitter". That sounded like a good candidate.

I see how the term "Commit" is misleading here without context. Probably "Press the <Save> button to commit your slice to the inbox repository" would probably be better.

Now, I guess I should select Pharo50Inbox as the Remote, write a commit message, click Ok and hope for the best.

Is that right?

I guess contributors are expected to use a recent image. So I think it would be good that someone updates the documentation. Or fix the slice maker. Or both.

https://pharo.fogbugz.com/default.asp?17398

cheers -ben

Ben Coman

Re: Contributing to Pharo

In reply to this post by David Allouche

On Sat, Jan 16, 2016 at 6:57 AM, David Allouche <[hidden email]> wrote:

>
> On 15 Jan 2016, at 23:49, Nicolai Hess <[hidden email]> wrote:
>
> 2016-01-15 23:33 GMT+01:00 David Allouche <[hidden email]>:
>>
>>
>> So yes, it's broken, but maybe it's something else entirely, I get new
>> reproducible errors every few minutes: errors when activating pretty
>> printing in the diff viewer in Monticello,
>
>
> this is a known error from the "recent" change for rubric text component
>
>>
>> unexpected contextual menu showing up when I do Cmd-T in the debugger,
>
>
> known ( from the recent changes for debugger :) )
>
>>
>> infinite recursions when trying to debug through the
>> MonticelloRepositoryBrowser...
>
>
> I don't know this error. But I don't think "this"
> MonticelloRepositoryBrowser is actually used.
>
>
> I think that was actually a bug in the debugger, or inspector, not in
> MonticelloRepositoryBrowser.
>
> And yes, this appear to be dead code. I found it before finding the actual
> browser, and thought it might be a good place to start exploring Monticello.
>
> I tried the old debugger in my new latest image (in the hope that syntax
> highlighting would not be broken there), but I realised it advertised no
> keyboard shortcut for stepping through the code…
>
> Starting to wonder if I should go back to spending my evenings playing Elite
> Dangerous, and come back in a few weeks when stuff is hopefully less buggy
> everywhere :-(

Generally I'm impressed at Pharo's stability given depth of the
surgery that is sometimes done on it - but after all it is bleeding
edge and sometimes things get in a bind. Since all the tools are
built and run inside the Image, sometimes its a bit like changing the
tyres on a moving car - but there is the advantage that we are
*always* eating our own dogfood.

So if occasionally if everything seems against you, after trying a
fresh Image as you already did, slide back to the last build that
worked for you (I don't think the issues you experience are Spur
related, but 50496 might be a good fallback as Pre-Spur and
Pre-GTDebugger). Then create a fresh Image from the latest build to
test your Slice and in that time maybe the other issues have gone.

cheers -ben

Ben Coman

Re: Contributing to Pharo

On Sat, Jan 16, 2016 at 9:42 AM, Ben Coman <[hidden email]> wrote:

> On Sat, Jan 16, 2016 at 6:57 AM, David Allouche <[hidden email]> wrote:
>>
>> On 15 Jan 2016, at 23:49, Nicolai Hess <[hidden email]> wrote:
>>
>> 2016-01-15 23:33 GMT+01:00 David Allouche <[hidden email]>:
>>>
>>>
>>> So yes, it's broken, but maybe it's something else entirely, I get new
>>> reproducible errors every few minutes: errors when activating pretty
>>> printing in the diff viewer in Monticello,
>>
>>
>> this is a known error from the "recent" change for rubric text component
>>
>>>
>>> unexpected contextual menu showing up when I do Cmd-T in the debugger,
>>
>>
>> known ( from the recent changes for debugger :) )
>>
>>>
>>> infinite recursions when trying to debug through the
>>> MonticelloRepositoryBrowser...
>>
>>
>> I don't know this error. But I don't think "this"
>> MonticelloRepositoryBrowser is actually used.
>>
>>
>> I think that was actually a bug in the debugger, or inspector, not in
>> MonticelloRepositoryBrowser.
>>
>> And yes, this appear to be dead code. I found it before finding the actual
>> browser, and thought it might be a good place to start exploring Monticello.
>>
>> I tried the old debugger in my new latest image (in the hope that syntax
>> highlighting would not be broken there), but I realised it advertised no
>> keyboard shortcut for stepping through the code…
>>
>> Starting to wonder if I should go back to spending my evenings playing Elite
>> Dangerous, and come back in a few weeks when stuff is hopefully less buggy
>> everywhere :-(
>
> Generally I'm impressed at Pharo's stability given depth of the
> surgery that is sometimes done on it - but after all it is bleeding
> edge and sometimes things get in a bind. Since all the tools are
> built and run inside the Image, sometimes its a bit like changing the
> tyres on a moving car - but there is the advantage that we are
> *always* eating our own dogfood.
>
> So if occasionally if everything seems against you, after trying a
> fresh Image as you already did, slide back to the last build that
> worked for you (I don't think the issues you experience are Spur
> related, but 50496 might be a good fallback as Pre-Spur and

Whoops. That should be 50495.

> Pre-GTDebugger). Then create a fresh Image from the latest build to
> test your Slice and in that time maybe the other issues have gone.
>
> cheers -ben

David Allouche

Re: Contributing to Pharo

In reply to this post by Ben Coman

On 16 Jan 2016, at 02:15, Ben Coman <[hidden email]> wrote:
On Sat, Jan 16, 2016 at 3:45 AM, David Allouche <[hidden email]> wrote:
it shows a bunch of packages I have not touched
it does not show the package that contains my fix (Spec-Tools)

I am curious on item 2. Was this just because the dirty package was sorted to the top of the list (per Nicolai's snapshots)?

I think that was indeed the source of confusion.

But, really, this "list of dirty packages" should really only list dirty packages. What is the use case for selecting a non-dirty package?

I looked in the world menu, and I found this menu item called "Komitter". That sounded like a good candidate.

I see how the term "Commit" is misleading here without context. Probably "Press the <Save> button to commit your slice to the inbox repository" would probably be better.

Yes, that would help, too.

https://pharo.fogbugz.com/default.asp?17398

Cool!

1234 ... 6