Contributing with tests
Locked
123
123
 
|
Hello everyone, We have one month to develop unit tests and get them integrated in the github repository. We'll be evaluated on our work. We would like to know which tests must be done first. We've seen in the contribution page that the Collection hierarchy needs to be reviewed, but there may be higher priority tests. We're looking forward to contributing in Amber project. Celia, Jonathan, Quentin, Romain You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
can I hug you guys? :D
does email hugs count? :D \o/ you’re sooo welcomed!!! On Sep 10, 2014, at 11:50 AM, Célia Cacciatore <[hidden email]> wrote:
You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
In reply to this post by Célia Cacciatore
Awesome guys!
OT question: Is Damien Cassou your teacher? :) Looking forward to review your contributions! Cheers, Nico Célia Cacciatore <[hidden email]> writes: > Hello everyone, > > We're a team of students in Université Lille I in France. We would like to > contribute in Amber project's tests in order to improve our test skills on > a real open-source project. > We have one month to develop unit tests and get them integrated in the > github repository. We'll be evaluated on our work. > > We would like to know which tests must be done first. We've seen in the > contribution page that the Collection hierarchy needs to be reviewed, but > there may be higher priority tests. > > We're looking forward to contributing in Amber project. > > > Celia, Jonathan, Quentin, Romain -- Nicolas Petton http://nicolas-petton.fr -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
In reply to this post by Célia Cacciatore
Well, I have tbe impression that Amber needa more of e2e tests than unit tests. CLI tooling has no tests even if it does a lot for Amber project bookkeeping (see issues with label 'in cli'); also Ambet is not actuallt tested in browser in Teavis CI but instead from node.ja runner. It's fine, but process of loading Amber in browser is not tested, which also has it's bugs - all of thia must be tested manually.
So if you would figure out how to run unit tests (also) from the browser itself in Travis, it would be big contribution. If your project is confined to unit testing, surely some part can be found, too. Herby Célia Cacciatore <[hidden email]>napísal/a: Hello everyone, We have one month to develop unit tests and get them integrated in the github repository. We'll be evaluated on our work. We would like to know which tests must be done first. We've seen in the contribution page that the Collection hierarchy needs to be reviewed, but there may be higher priority tests. We're looking forward to contributing in Amber project. Celia, Jonathan, Quentin, Romain You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
@Nicolas Petton : Yes, Damien Cassou is our teacher.
-- We must write tests but not necessarily unit tests. If browser tests are more important we can take a look at it and see if we can do it. Célia, Jonathan, Quentin, Romain Le mercredi 10 septembre 2014 17:23:17 UTC+2, Herby a écrit : Well, I have tbe impression that Amber needa more of e2e tests than unit tests. CLI tooling has no tests even if it does a lot for Amber project bookkeeping (see issues with label 'in cli'); also Ambet is not actuallt tested in browser in Teavis CI but instead from node.ja runner. It's fine, but process of loading Amber in browser is not tested, which also has it's bugs - all of thia must be tested manually. You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
Célia Cacciatore wrote: > @Nicolas Petton : Yes, Damien Cassou is our teacher. > > We must write tests but not necessarily unit tests. If browser tests are > more important we can take a look at it and see if we can do it. > > Célia, Jonathan, Quentin, Romain Well, from my point of view, either: - Make unit test suite we are actually running on node.js run not only from node.js but also from some browser, either - phantomjs on travisci, or - saucelabs and integrating somehow with travisci - Implement cli functional tests (issues 991-995 in tracker) would be of a big help. It would be good to know what @NicolasPetton finds as useful to implement, though, before going on. > > Le mercredi 10 septembre 2014 17:23:17 UTC+2, Herby a écrit : > > Well, I have tbe impression that Amber needa more of e2e tests than > unit tests. CLI tooling has no tests even if it does a lot for Amber > project bookkeeping (see issues with label 'in cli'); also Ambet is > not actuallt tested in browser in Teavis CI but instead from node.ja > runner. It's fine, but process of loading Amber in browser is not > tested, which also has it's bugs - all of thia must be tested manually. > So if you would figure out how to run unit tests (also) from the > browser itself in Travis, it would be big contribution. > > If your project is confined to unit testing, surely some part can be > found, too. > > Herby > > Célia Cacciatore <[hidden email] <javascript:>>napísal/a: > > Hello everyone, > > We're a team of students in Université Lille I in France. We would > like to contribute in Amber project's tests in order to improve our > test skills on a real open-source project. > We have one month to develop unit tests and get them integrated in > the github repository. We'll be evaluated on our work. > > We would like to know which tests must be done first. We've seen in > the contribution page that the Collection hierarchy needs to be > reviewed, but there may be higher priority tests. > > We're looking forward to contributing in Amber project. > > > Celia, Jonathan, Quentin, Romain > > -- > You received this message because you are subscribed to the Google > Groups "amber-lang" group. > To unsubscribe from this group and stop receiving emails from it, > send an email to [hidden email] <javascript:>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. > > -- > You received this message because you are subscribed to the Google > Groups "amber-lang" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [hidden email] > <mailto:[hidden email]>. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
We're currently looking at the technologies you mentioned. We'll wait to see the priority matters, but we're interested in the unit test suite in the browser. Thank you for everything. Celia, Jonathan, Quentin, Romain You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
As NicolasPetton announced yesterday, he has less time for Amber now, so he will probably not have time to add to this conversation.
The two alternatives I mentioned have similar priority, so if you choose rather the "automatize running the SUnit test suite in the browser from Travis CI", go for it. But first ask your professor, because as I look at it now, it's much more devops work than testing. In particular, you probably won't write any tests - it is about tedious work of finding out the tools and tie them together so they do what is needed. The SUnit suite is there already, it runs from cli runner as well as from browser interactively - the tasks which is needed is to make it run from some browser (phantomjs run locally (it's installable via npm) or via saucelabs service) non-interactively. Which by no means means I am telling you not to go for it, just, now I see it is not about testing very much. The second thing (the cli issues) is 50/50 tooling/actual testing, as there the test must be actually written, but as they are e2e tests, so you must find appropriate tools to write and run them, as well (CucumberJS?). Feel free to ask if you need something, Herby Célia Cacciatore wrote: > We're currently looking at the technologies you mentioned. > We'll wait to see the priority matters, but we're interested in the > unit test suite in the browser. > > Thank you for everything. > > Celia, Jonathan, Quentin, Romain > > -- > You received this message because you are subscribed to the Google > Groups "amber-lang" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [hidden email] > <mailto:[hidden email]>. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
Re: Contributing with tests
|
|
As you suggested, we just sent a mail to Damien Cassou.
-- By the way, we've already began to learn cucumber. Another possibility is maybe to use NightWatch.js; it seems that it can be integrate to a selenium browser like saucelabs. Another question: what about your code coverage? Are you sure that you don't need unit tests? Jonathan. (team Celia, Jonathan Quentin, Romain) You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
Jonathan Geoffroy wrote: > As you suggested, we just sent a mail to Damien Cassou. > By the way, we've already began to learn cucumber. Another possibility > is maybe to use NightWatch.js; it seems that it can be integrate to a > selenium browser like saucelabs. I don't know NightWatch.js. As for cucumber, it may actually not be needed for integration with saucelabs - the "integration with saucelabs" project was about running actual unit tests (which are already present) in various browser using saucelabs technology, but for that, it would be enough to add some adapter into a testrunner .html page and simulate, for example, output format of mocha tests. Oh, now that I think of it, saucelabs allows you to either run selenium tests or unit tests (mocha). You probably chose the former, while I thought you would do adapter for the latter. Well, whatever you see as better way. > Another question: what about your code coverage? Are you sure that you > don't need unit test s? Yes, our coverage can be better, but I think this issues I presented actually bring higher value. Most of code is tested that it works from inside well, known bugs are in tracker... all in all, I see increasing coverage as more aesthetical than value-adding activity; IOW, it can be postponed for better times (new code and bug fixes are being covered by tests). > Jonathan. (team Celia, Jonathan Quentin, Romain) -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
We've contacted our teacher, he is okay with everything as long as it concerns testing.
-- We have decided to make the functional tests which are needed, but when we looked at the issues on github, there were no details on what to do or which classes are concerned... The links don't work anymore. Could you give us some information so that we can get started ? For example, issue #991, what do you mean by functional tests for amberc ? Is there documentation somewhere ? We'll take all the advices you can give us. Moreover, the deadline for our project has been put forward to October 1st. Thank you for everything, Celia, Jonathan, Quentin, Romain Le mardi 16 septembre 2014 21:41:36 UTC+2, Herby a écrit :
You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
Célia Cacciatore wrote: > We've contacted our teacher, he is okay with everything as long as it > concerns testing. > > We have decided to make the functional tests which are needed, but when > we looked at the issues on github, there were no details on what to do > or which classes are concerned... The links don't work anymore. The links pointed to old instance of the issue, which all looked the same as existing ones, as all description and comments were copied. > Could you give us some information so that we can get started ? > For example, issue #991, what do you mean by functional tests for amberc > ? Is there documentation somewhere ? amberc has no written documentation, but when you install it (npm install -g amber-cli#master), you can run amberc --help which shows you the options. amberc does many things - takes .st files and compile them into .js files, looks for libraries in -L directories plus amber directories, and can produce a concatenated version of the package into a node.js executable. Plus it has a lots of options governing various directories. #991 is about making functional tests of these behaviours - does it compile the file, does it find all things at the specfied directories, does the file contains correct code, does it produce the concatenated executable that does the right thing? #992 has less priority - it should test if `amber repl` cli command works well - it loads and it actually evaluates what user types as input. #993 should be just a little test to see if `amber version` does the right thing. #994 is a bit complicated test scenario. The vision was, you write a test that simulates the whole path from creating an empty object with `amber init` (which is dependent on the input side by the version of grunt-init-amber it uses - but for the test you can try to install the one with fixed commit hash to be sure your simulated input matches to grunt-init-amber expectations), then serving it with `amber serve` and finally load it with browser (phantom or real) and see if it loads fine (eventually run the test suite in it to be sure everything was done fine). Since bug in amber can break this, you may want to install fixed version of amber after `amber init` to fix it as well on version that has no bugs. In fact this is two tests - tests of amber init and test of amber serve - you can split them, to test `amber init` produced good project one can just check it with `npm test`; to test `amber serve` some browser should try to load the project from `amber serve`d location and either some simple smoke test (make 'console log: 'WORKS' or 'window at: '__testMsg__' put: 'WORKS' run from loader callback and test that it happened in the driver), or indeed running the whole test suite and see it did not fail (which is task on its own) should be done. > We'll take all the advices you can give us. > > Moreover, the deadline for our project has been put forward to October 1st. Oh. It's pretty tight. Choose just some subset then (#991 and #994 with smoketest-only-in-browser variant?). > Thank you for everything, > Celia, Jonathan, Quentin, Romain Good luck, Herby -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
We are going to do the issues #991 and #994. Thanks for explanations.
-- Besides, do you want us to use pull request feature on Github when we have finished functionnal tests ? Thanks again, Romain, Quentin, Jonathan, Célia On Monday, September 22, 2014 3:11:12 PM UTC+2, Herby wrote:
You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
JijiSensei wrote: > We are going to do the issues #991 and #994. Thanks for explanations. > > Besides, do you want us to use pull request feature on Github when we > have finished functionnal tests ? Yes, of course. > Thanks again, > Romain, Quentin, Jonathan, Célia Herby -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
We tried to write some example code in Smalltalk to compile it with amberc and obtain a javascript file.
-- Can you tell us how we can launch the javascript program we generated ? Thank you very much. Celia, Jonathan, Quentin, Romain Le lundi 22 septembre 2014 17:22:44 UTC+2, Herby a écrit :
You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
Célia Cacciatore wrote: > We tried to write some example code in Smalltalk to compile it with > amberc and obtain a javascript file. > Can you tell us how we can launch the javascript program we generated ? Well, it is technically impossible to run .js file as-is, without amber harness. Either you generate the complete concatenated program with amberc, in that case you just run it as-is (in Windows, using node xxx.js as .js extension is bound to WScript).c. In case you want to use code from compiled package only, it must be loaded along with amber, somehow (like, including it in list of packages to load when using browser's loader). The bare compiled .js just contains the code of the package that amber should load, without other amber core it is unusable. OTOH, you can try to use it in minimal scenario, if you use r.js creatively, as it is an AMD module. You can definitely give r.js itself mappings for amber_core, include some runner specific for a test and make r.js build an all-in-one file itself. Maybe it is possible to use r.js to simply run an AMD module itself - I faintly remember something like that possible, but I never tried - if that is possible, you should be able to generate simple runner that just requires the generated .js as well as some amber bootstrapping, initialize amber and run your code. To recap, there is no easy way to run a package directly, you must understand a bit of AMD loading / packaging plus the way amber loads packages (require them all, then call initialize, then you can actually run the code). > Thank you very much. > > Celia, Jonathan, Quentin, Romain > > > Le lundi 22 septembre 2014 17:22:44 UTC+2, Herby a écrit : > > > > JijiSensei wrote: > > We are going to do the issues #991 and #994. Thanks for > explanations. > > > > Besides, do you want us to use pull request feature on Github > when we > > have finished functionnal tests ? > > Yes, of course. > > > Thanks ag > > Romain, Quentin, Jonathan, Célia > > Herby > > -- > You received this message because you are subscribed to the Google > Groups "amber-lang" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [hidden email] > <mailto:[hidden email]>. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
Okay.
-- We found an hello example on amber-examples but we couldn't launch them with gst nor use the compiled js with node. Could you give us some examples which work and how to use them please ? We also tried to write a smalltalk file which works with gst, but which can't be compiled with amberc. Is there a problem with the compiler ? Does it work only with a specific syntax of smalltalk ? We joined the file so you can look at it. Thank you. Celia, Jonathan, Quentin, Romain You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
animal.st (1K) |
|
Hi,
The Amber chunk format is not exactly the same as the Pharo or GST one, and the language itself has some important differences: https://github.com/amber-smalltalk/amber/wiki/Porting-code-from-other-Smalltalk-dialects But anyway, why aren't you using the builtin IDE instead of editing .st files manually? Cheers, Nico Célia Cacciatore <[hidden email]> writes: > Okay. > > We found an hello example on amber-examples > <https://github.com/amber-smalltalk/amber-examples/tree/master/hello> but > we couldn't launch them with gst nor use the compiled js with node. > Could you give us some examples which work and how to use them please ? > > We also tried to write a smalltalk file which works with gst, but which > can't be compiled with amberc. Is there a problem with the compiler ? Does > it work only with a specific syntax of smalltalk ? > We joined the file so you can look at it. > > Thank you. > > Celia, Jonathan, Quentin, Romain -- Nicolas Petton http://nicolas-petton.fr -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
As we don't know Smalltalk (we had to choose a language we didn't know), we tried with an example found on internet. Our goal is to write a functional test on amberc, so we just wanted a .st file to compile in command line, that's why we just tried to find a .st file on the internet. We still can't launch an Amber project currently. We compiled the hello example in amber-examples, but it didn't work in the browser (the button 'sayhello' does nothing), even when we added the script in index.html. We're looking for a simple example to try. Thanks. Celia, Jonathan, Quentin, Romain Le mercredi 24 septembre 2014 16:28:27 UTC+2, nicolas petton a écrit : Hi, You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
|
|
The simplest way to get started with Amber is to follow this page:
http://docs.amber-lang.net/ It will guide you through installing Amber and start a project, create a package, etc. There's also an introduction video here: http://docs.amber-lang.net/getting-started.html I would advise you to follow each step, and if things go wrong go back to this ML to ask questions. You also have the wiki: https://github.com/amber-smalltalk/amber/wiki but it might contain some outdated info. Cheers, Nico Célia Cacciatore <[hidden email]> writes: > As we don't know Smalltalk (we had to choose a language we didn't know), we > tried with an example found on internet. > Our goal is to write a functional test on amberc, so we just wanted a .st > file to compile in command line, that's why we just tried to find a .st > file on the internet. > We still can't launch an Amber project currently. We compiled the hello > example in amber-examples, but it didn't work in the browser (the button > 'sayhello' does nothing), even when we added the script in index.html. > We're looking for a simple example to try. > > Thanks. > > Celia, Jonathan, Quentin, Romain > > > > > Le mercredi 24 septembre 2014 16:28:27 UTC+2, nicolas petton a écrit : >> >> Hi, >> >> The Amber chunk format is not exactly the same as the Pharo or GST one, >> and the language itself has some important differences: >> >> >> https://github.com/amber-smalltalk/amber/wiki/Porting-code-from-other-Smalltalk-dialects >> >> But anyway, why aren't you using the builtin IDE instead of editing .st >> files manually? >> >> Cheers, >> Nico >> >> >> Célia Cacciatore <[hidden email] <javascript:>> writes: >> >> > Okay. >> > >> > We found an hello example on amber-examples >> > <https://github.com/amber-smalltalk/amber-examples/tree/master/hello> >> but >> > we couldn't launch them with gst nor use the compiled js with node. >> > Could you give us some examples which work and how to use them please ? >> > >> > We also tried to write a smalltalk file which works with gst, but which >> > can't be compiled with amberc. Is there a problem with the compiler ? >> Does >> > it work only with a specific syntax of smalltalk ? >> > We joined the file so you can look at it. >> > >> > Thank you. >> > >> > Celia, Jonathan, Quentin, Romain >> >> -- >> Nicolas Petton >> http://nicolas-petton.fr >> >> -- Nicolas Petton http://nicolas-petton.fr -- You received this message because you are subscribed to the Google Groups "amber-lang" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/d/optout. |
«
Return to Amber Smalltalk
|
1 view|%1 views
| Free forum by Nabble | Edit this page |