Critics Browser should diff formatted original

It's difficult to see what the actual changes are when the formatter makes significant whitespace changes. How about we diff the original source /re-formatted/ against the transformed source?

Sean P. DeNigris wrote

How about we diff the original source /re-formatted/ against the transformed source?

Issue 15574: Critics: Ignore whitespace changes when diffing transformations
https://pharo.fogbugz.com/default.asp?15574

Sean P. DeNigris wrote

Issue 15574: Critics: Ignore whitespace changes when diffing transformations
https://pharo.fogbugz.com/default.asp?15574

Thanks to Yuriy, now the confusing diff on the left will look like the one on the right

You are welcome.

There are more things to take into account. There is prettyprinted diff class, that should do it automatically, but it does not work because what you are getting after applying transformation - is regenerated source code i.e. there can be extra parentheses and so on. Also the diff that is used there is line-by line diff. We have a better diff which is embedded into side-by-side view, but what is anyway missing is a diff model.Than then can be used for visualization.

What could be cool is to have some bachelor (or maybe master, but I have no idea if there is enough to do) student to work on creating a diff model that can be used for ast, text and so on. And then adding views for the diffs.

Uko