DataSetView possible bug

A very oldbug I corrected in 5i4 is still there in VWNC7.7

UI.DataSetView>>setupEditor: aColumnDescriptor at: aCell downcast: aBoolean

...snip...
  aBoolean ifFalse:
    [  [controller clicked ~= true ifTrue: [controller lockCallbacks].
       editor widget controller activate]
         ensure: [controller ~= true ifTrue: [controller unlockCallbacks]].
       ^self].
...snip...

controller ~= true ???

wasn't the intention controller clicked ~= true ???

Nicolas

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

With the increasing amount of extra processes flying around, I'd be
happier with:

[(needUnlock := controller clicked ~= true) ifTrue: [controller
lockCallbacks].
editor widget controller activate]
    ensure: [needUnlock ifTrue: [controller unlockCallbacks]].

You never know when something else is going to do something "innocent"
like ask for Dialog defaultParentWindow, which will process all
outstanding events and could cause controller clicked to become false
between lines 1 and 3 above. #defaultParentWindow happens in the oddest
places, like setting up a uiEvent, or even just if there's an i/o delay
that allows an existing uiEvent's DeferrableAction getWindow poll to
run. But then that problem has only been around since 7.2.1, so yours
gets priority :-).

Steve

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc