Date comparison broken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Date comparison broken

mmimica
Hello

| yesterday |
yesterday := Date yesterday.
yesterday < yesterday

On Phalo 2.0, this evaluates to 'false'. I'ts not a joke.


--
Milan Mimica
http://sparklet.sf.net
Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

mmimica
Please ignore. I whish there was a 'unsend' button.


On 20 April 2013 18:31, Milan Mimica <[hidden email]> wrote:
Hello

| yesterday |
yesterday := Date yesterday.
yesterday < yesterday

On Phalo 2.0, this evaluates to 'false'. I'ts not a joke.


--
Milan Mimica
http://sparklet.sf.net



--
Milan Mimica
http://sparklet.sf.net
Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

mmimica
Actually, please don't ignore me. I knew there was sometime broken:
(Date today - 1 day) < (Date today - 1 day)  evaluates to 'true'


On 20 April 2013 18:33, Milan Mimica <[hidden email]> wrote:
Please ignore. I whish there was a 'unsend' button.


On 20 April 2013 18:31, Milan Mimica <[hidden email]> wrote:
Hello

| yesterday |
yesterday := Date yesterday.
yesterday < yesterday

On Phalo 2.0, this evaluates to 'false'. I'ts not a joke.


--
Milan Mimica
http://sparklet.sf.net



--
Milan Mimica
http://sparklet.sf.net



--
Milan Mimica
http://sparklet.sf.net
Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

mmimica
I found a bug:

in DateAndTime >> <

julianDayNumber < other julianDayNumber
ifTrue: [ ^ true ].

should be:

self julianDayNumber < other julianDayNumber
ifTrue: [ ^ true ].


On 20 April 2013 18:43, Milan Mimica <[hidden email]> wrote:
Actually, please don't ignore me. I knew there was sometime broken:
(Date today - 1 day) < (Date today - 1 day)  evaluates to 'true'


On 20 April 2013 18:33, Milan Mimica <[hidden email]> wrote:
Please ignore. I whish there was a 'unsend' button.


On 20 April 2013 18:31, Milan Mimica <[hidden email]> wrote:
Hello

| yesterday |
yesterday := Date yesterday.
yesterday < yesterday

On Phalo 2.0, this evaluates to 'false'. I'ts not a joke.


--
Milan Mimica
http://sparklet.sf.net



--
Milan Mimica
http://sparklet.sf.net



--
Milan Mimica
http://sparklet.sf.net



--
Milan Mimica
http://sparklet.sf.net
Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

Camillo Bruni-3
yes ;)

could you open an issue and possibly add a test that covers this?

that would be great.

On 2013-04-20, at 19:09, Milan Mimica <[hidden email]> wrote:

> I found a bug:
>
> in DateAndTime >> <
>
> julianDayNumber < other julianDayNumber
> ifTrue: [ ^ true ].
>
> should be:
>
> self julianDayNumber < other julianDayNumber
> ifTrue: [ ^ true ].
>
>
> On 20 April 2013 18:43, Milan Mimica <[hidden email]> wrote:
>
>> Actually, please don't ignore me. I knew there was sometime broken:
>> (Date today - 1 day) < (Date today - 1 day)  evaluates to 'true'
>>
>>
>> On 20 April 2013 18:33, Milan Mimica <[hidden email]> wrote:
>>
>>> Please ignore. I whish there was a 'unsend' button.
>>>
>>>
>>> On 20 April 2013 18:31, Milan Mimica <[hidden email]> wrote:
>>>
>>>> Hello
>>>>
>>>> | yesterday |
>>>> yesterday := Date yesterday.
>>>> yesterday < yesterday
>>>>
>>>> On Phalo 2.0, this evaluates to 'false'. I'ts not a joke.
>>>>
>>>>
>>>> --
>>>> Milan Mimica
>>>> http://sparklet.sf.net
>>>>
>>>
>>>
>>>
>>> --
>>> Milan Mimica
>>> http://sparklet.sf.net
>>>
>>
>>
>>
>> --
>> Milan Mimica
>> http://sparklet.sf.net
>>
>
>
>
> --
> Milan Mimica
> http://sparklet.sf.net


Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

mmimica
On 20 April 2013 19:10, Camillo Bruni <[hidden email]> wrote:
yes ;)

could you open an issue and possibly add a test that covers this?

Only if http://bugs.pharo.org woudl let me register. It says "Invalid email address." when I fill the form.
I have pushed the changes to http://ss3.gemstone.com/ss/PharoInbox


--
Milan Mimica
http://sparklet.sf.net
Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

Benjamin Van Ryseghem (Pharo)
I just create you an account :)

Ben

On Apr 20, 2013, at 7:44 PM, Milan Mimica <[hidden email]> wrote:

On 20 April 2013 19:10, Camillo Bruni <[hidden email]> wrote:
yes ;)

could you open an issue and possibly add a test that covers this?

Only if http://bugs.pharo.org woudl let me register. It says "Invalid email address." when I fill the form.
I have pushed the changes to http://ss3.gemstone.com/ss/PharoInbox


--
Milan Mimica
http://sparklet.sf.net

Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

mmimica
In reply to this post by Camillo Bruni-3


On 20 April 2013 19:10, Camillo Bruni <[hidden email]> wrote:
yes ;)

could you open an issue and possibly add a test that covers this?

that would be great.

On 2013-04-20, at 19:09, Milan Mimica <[hidden email]> wrote:

> I found a bug:
>
> in DateAndTime >> <
>
> julianDayNumber < other julianDayNumber
> ifTrue: [ ^ true ].
>
> should be:
>
> self julianDayNumber < other julianDayNumber
> ifTrue: [ ^ true ].
>
>
> On 20 April 2013 18:43, Milan Mimica <[hidden email]> wrote:
>
>> Actually, please don't ignore me. I knew there was sometime broken:
>> (Date today - 1 day) < (Date today - 1 day)  evaluates to 'true'
>>
>>
>> On 20 April 2013 18:33, Milan Mimica <[hidden email]> wrote:
>>
>>> Please ignore. I whish there was a 'unsend' button.
>>>
>>>
>>> On 20 April 2013 18:31, Milan Mimica <[hidden email]> wrote:
>>>
>>>> Hello
>>>>
>>>> | yesterday |
>>>> yesterday := Date yesterday.
>>>> yesterday < yesterday
>>>>
>>>> On Phalo 2.0, this evaluates to 'false'. I'ts not a joke.
>>>>
>>>>
>>>> --
>>>> Milan Mimica
>>>> http://sparklet.sf.net
>>>>
>>>
>>>
>>>
>>> --
>>> Milan Mimica
>>> http://sparklet.sf.net
>>>
>>
>>
>>
>> --
>> Milan Mimica
>> http://sparklet.sf.net
>>
>
>
>
> --
> Milan Mimica
> http://sparklet.sf.net





--
Milan Mimica
http://sparklet.sf.net
Reply | Threaded
Open this post in threaded view
|

Re: Date comparison broken

Henrik Sperre Johansen

On Apr 20, 2013, at 8:51 PM, Milan Mimica wrote:


If you're up for it taking a wider look, it's really part of a family of errors still lingering after the refactoring:

Cheers,
Henry