Debugger opening on user halt and not Object>>halt

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Debugger opening on user halt and not Object>>halt

tdupriez

Hello,

Does someone know which is the code responsible for the debugger opening on the halt of the user instead of Object>>halt (see picture)? It's neat but it's not the regular behaviour so I'm guessing it is handled somewhere specifically for halt messages?


Thomas

Reply | Threaded
Open this post in threaded view
|

Re: Debugger opening on user halt and not Object>>halt

Guillermo Polito
Hi Thomas,

Check the pragma debuggerCompleteToSender and its users. I think it's related to that.
BenComan probably can give a better insight since (if I recall correctly) he introduced it?

Guille

On Wed, Jan 30, 2019 at 5:44 PM Thomas Dupriez <[hidden email]> wrote:

Hello,

Does someone know which is the code responsible for the debugger opening on the halt of the user instead of Object>>halt (see picture)? It's neat but it's not the regular behaviour so I'm guessing it is handled somewhere specifically for halt messages?


Thomas



--

   

Guille Polito

Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille

CRIStAL - UMR 9189

French National Center for Scientific Research - http://www.cnrs.fr


Web: http://guillep.github.io

Phone: +33 06 52 70 66 13

Reply | Threaded
Open this post in threaded view
|

Re: Debugger opening on user halt and not Object>>halt

Ben Coman


On Thu, 31 Jan 2019 at 17:15, Guillermo Polito <[hidden email]> wrote:
Hi Thomas,

Check the pragma debuggerCompleteToSender and its users. I think it's related to that.
BenComan probably can give a better insight since (if I recall correctly) he introduced it?

Thats right.  Use "Tools > Finder > Source" to search for... debuggerCompleteToSender 
ignoring where its a pragma.

That leaves...
  Process>>complete:
  Process>>stepToHome:
  GTGenericStackDebugger>>filteredStack
  GTGenericStackDebugger>>setDebuggerToFirstNonFilteredContext
 
The first was me. Not sure about the second. The latter two were someone else.



Guille

On Wed, Jan 30, 2019 at 5:44 PM Thomas Dupriez <[hidden email]> wrote:

Hello,

Does someone know which is the code responsible for the debugger opening on the halt of the user instead of Object>>halt (see picture)? It's neat but it's not the regular behaviour so I'm guessing it is handled somewhere specifically for halt messages?


Its not just for halt, but for any method that you don't want the debugger opening in the method sending #signal.
Is your snapshot based on modified code? In Pharo-7.0.1+build.146.sha.c48755acc5f489337be0e7abc882c15b1707b254 (32 Bit)
in Playground I evaluate...
    1 + 1.
    self halt.
    2 + 2.
and my top line is the same as your second line.

cheers -ben

 

 

kjmlhgikmkmgbdgh.png (124K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Debugger opening on user halt and not Object>>halt

Sean P. DeNigris
Administrator
Ben Coman wrote
> The first was me. Not sure about the second. The latter two were someone
> else.

I always thought that DNU should be on this list too. Am I the only one?



-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Debugger opening on user halt and not Object>>halt

Ben Coman


On Sat, 2 Feb 2019 at 08:35, Sean P. DeNigris <[hidden email]> wrote:
Ben Coman wrote
> The first was me. Not sure about the second. The latter two were someone
> else.

I always thought that DNU should be on this list too. Am I the only one?

It seem to already do this?  In Playground evaluating...
  1 + 1.
  2 unknown.
  3 + 3

opens a debugger on the second line with "unknown" highlighted.
See <debuggerCompleteToSender> at the top of Object>>doesNotUnderstand:
Or do you mean something else?

cheers -ben
Reply | Threaded
Open this post in threaded view
|

Re: Debugger opening on user halt and not Object>>halt

Sean P. DeNigris
Administrator
Ben Coman wrote
> It seem to already do this?

Cool! That is new. In 6.1, it opened on DNU



-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Cheers,
Sean