DeepTraverser

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

DeepTraverser

Nicolas Anquetil
Anybody can explain the changes that occured over DeepTraverser ?
(Ideally how can we switch from old to new traverser?)

We have an "old" (1 year) bit of code that use the deepCollect: method

However, the changes in DeepTraverser break our code :-(

DeepTraverser-StefanReichhart.9
Time: 11 May 2015, 7:02:16.666278 pm

nicolas
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Tudor Girba-2
Hmm. deepCollect: should work as expected. Can you be more specific with what does not work?

Doru

--
www.tudorgirba.com

"Every thing has its own flow"

> On 22 Jun 2015, at 15:34, Nicolas Anquetil <[hidden email]> wrote:
>
> Anybody can explain the changes that occured over DeepTraverser ?
> (Ideally how can we switch from old to new traverser?)
>
> We have an "old" (1 year) bit of code that use the deepCollect: method
>
> However, the changes in DeepTraverser break our code :-(
>
> DeepTraverser-StefanReichhart.9
> Time: 11 May 2015, 7:02:16.666278 pm
>
> nicolas
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Blondeau Vincent
I fall into this kind of bug yesterday.

Can you try to do:
Number deepCollect: #superclass ?

That code does work in Moose 5.0 but not in Moose5.1... (-> nil DNU #superclass)

I solved it by putting a block with a nil checker on the #superclass call. But I don't think that a durable solution.

Vincent

-----Message d'origine-----
De : [hidden email] [mailto:[hidden email]] De la part de Tudor Girba
Envoyé : lundi 22 juin 2015 15:42
À : Moose-related development
Objet : [Moose-dev] Re: DeepTraverser

Hmm. deepCollect: should work as expected. Can you be more specific with what does not work?

Doru

--
www.tudorgirba.com

"Every thing has its own flow"

> On 22 Jun 2015, at 15:34, Nicolas Anquetil <[hidden email]> wrote:
>
> Anybody can explain the changes that occured over DeepTraverser ?
> (Ideally how can we switch from old to new traverser?)
>
> We have an "old" (1 year) bit of code that use the deepCollect: method
>
> However, the changes in DeepTraverser break our code :-(
>
> DeepTraverser-StefanReichhart.9
> Time: 11 May 2015, 7:02:16.666278 pm
>
> nicolas
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité de Worldline ne pourra être recherchée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être recherchée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Worldline liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Nicolas Anquetil
In reply to this post by Tudor Girba-2

Not too sure,

in DeepTraverser>>next, at some point the "objectsToTraverse" instance
variable contains a list with a "nil" inside
so "current := objectsToTraverse removeFirst." puts nil in "current" and
this raises an issue

not sure whether this "nil" was always there or whether it is something
new due to other changes

nicolas

On 22/06/2015 15:42, Tudor Girba wrote:

> Hmm. deepCollect: should work as expected. Can you be more specific with what does not work?
>
> Doru
>
> --
> www.tudorgirba.com
>
> "Every thing has its own flow"
>
>> On 22 Jun 2015, at 15:34, Nicolas Anquetil <[hidden email]> wrote:
>>
>> Anybody can explain the changes that occured over DeepTraverser ?
>> (Ideally how can we switch from old to new traverser?)
>>
>> We have an "old" (1 year) bit of code that use the deepCollect: method
>>
>> However, the changes in DeepTraverser break our code :-(
>>
>> DeepTraverser-StefanReichhart.9
>> Time: 11 May 2015, 7:02:16.666278 pm
>>
>> nicolas
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Tudor Girba-2
In reply to this post by Blondeau Vincent
Thanks. Stefan just fixed the problem on dev. Could you check? Then we can release it for Pharo 4 as well.

Doru

On Mon, Jun 22, 2015 at 5:08 PM, Blondeau Vincent <[hidden email]> wrote:
I fall into this kind of bug yesterday.

Can you try to do:
Number deepCollect: #superclass ?

That code does work in Moose 5.0 but not in Moose5.1... (-> nil DNU #superclass)

I solved it by putting a block with a nil checker on the #superclass call. But I don't think that a durable solution.

Vincent

-----Message d'origine-----
De : [hidden email] [mailto:[hidden email]] De la part de Tudor Girba
Envoyé : lundi 22 juin 2015 15:42
À : Moose-related development
Objet : [Moose-dev] Re: DeepTraverser

Hmm. deepCollect: should work as expected. Can you be more specific with what does not work?

Doru

--
www.tudorgirba.com

"Every thing has its own flow"

> On 22 Jun 2015, at 15:34, Nicolas Anquetil <[hidden email]> wrote:
>
> Anybody can explain the changes that occured over DeepTraverser ?
> (Ideally how can we switch from old to new traverser?)
>
> We have an "old" (1 year) bit of code that use the deepCollect: method
>
> However, the changes in DeepTraverser break our code :-(
>
> DeepTraverser-StefanReichhart.9
> Time: 11 May 2015, 7:02:16.666278 pm
>
> nicolas
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité de Worldline ne pourra être recherchée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être recherchée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Worldline liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Nicolas Anquetil
works !

many thanks

nicolas

On 22/06/2015 20:38, Tudor Girba wrote:
> Number deepCollect: #superclass

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Nicolas Anquetil
However, ConfigurationOfDeepTraverser>>stable: loads
'DeepTraverser-StefanReichhart.9'
(the old one)

nicolas

On 23/06/2015 17:20, Nicolas Anquetil wrote:
> works !
>
> many thanks
>
> nicolas
>
> On 22/06/2015 20:38, Tudor Girba wrote:
>> Number deepCollect: #superclass
>

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Tudor Girba-2
Thanks. As I said, we wanted to ensure that it works and now we will release a stable version for Pharo 4.

Doru

On Tue, Jun 23, 2015 at 5:21 PM, Nicolas Anquetil <[hidden email]> wrote:
However, ConfigurationOfDeepTraverser>>stable: loads 'DeepTraverser-StefanReichhart.9'
(the old one)

nicolas


On 23/06/2015 17:20, Nicolas Anquetil wrote:
works !

many thanks

nicolas

On 22/06/2015 20:38, Tudor Girba wrote:
Number deepCollect: #superclass


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Nicolas Anquetil


Hi,

any agenda for this?

nicolas

On 23/06/2015 17:40, Tudor Girba wrote:
Thanks. As I said, we wanted to ensure that it works and now we will release a stable version for Pharo 4.

Doru

On Tue, Jun 23, 2015 at 5:21 PM, Nicolas Anquetil <[hidden email]> wrote:
However, ConfigurationOfDeepTraverser>>stable: loads 'DeepTraverser-StefanReichhart.9'
(the old one)

nicolas


On 23/06/2015 17:20, Nicolas Anquetil wrote:
works !

many thanks

nicolas

On 22/06/2015 20:38, Tudor Girba wrote:
Number deepCollect: #superclass


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Tudor Girba-2
I forgot to mention that this should be fixed now. Could you check?

Doru

On Thu, Jul 2, 2015 at 5:01 PM, Nicolas Anquetil <[hidden email]> wrote:


Hi,

any agenda for this?

nicolas


On 23/06/2015 17:40, Tudor Girba wrote:
Thanks. As I said, we wanted to ensure that it works and now we will release a stable version for Pharo 4.

Doru

On Tue, Jun 23, 2015 at 5:21 PM, Nicolas Anquetil <[hidden email]> wrote:
However, ConfigurationOfDeepTraverser>>stable: loads 'DeepTraverser-StefanReichhart.9'
(the old one)

nicolas


On 23/06/2015 17:20, Nicolas Anquetil wrote:
works !

many thanks

nicolas

On 22/06/2015 20:38, Tudor Girba wrote:
Number deepCollect: #superclass


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

stepharo
don't we have tests for that?


Le 10/7/15 12:48, Tudor Girba a écrit :
I forgot to mention that this should be fixed now. Could you check?

Doru

On Thu, Jul 2, 2015 at 5:01 PM, Nicolas Anquetil <[hidden email]> wrote:


Hi,

any agenda for this?

nicolas


On 23/06/2015 17:40, Tudor Girba wrote:
Thanks. As I said, we wanted to ensure that it works and now we will release a stable version for Pharo 4.

Doru

On Tue, Jun 23, 2015 at 5:21 PM, Nicolas Anquetil <[hidden email]> wrote:
However, ConfigurationOfDeepTraverser>>stable: loads 'DeepTraverser-StefanReichhart.9'
(the old one)

nicolas


On 23/06/2015 17:20, Nicolas Anquetil wrote:
works !

many thanks

nicolas

On 22/06/2015 20:38, Tudor Girba wrote:
Number deepCollect: #superclass


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Tudor Girba-2
I meant to check if the configuration worked.

Doru

On Sat, Jul 11, 2015 at 10:12 AM, stepharo <[hidden email]> wrote:
don't we have tests for that?


Le 10/7/15 12:48, Tudor Girba a écrit :
I forgot to mention that this should be fixed now. Could you check?

Doru

On Thu, Jul 2, 2015 at 5:01 PM, Nicolas Anquetil <[hidden email]> wrote:


Hi,

any agenda for this?

nicolas


On 23/06/2015 17:40, Tudor Girba wrote:
Thanks. As I said, we wanted to ensure that it works and now we will release a stable version for Pharo 4.

Doru

On Tue, Jun 23, 2015 at 5:21 PM, Nicolas Anquetil <[hidden email]> wrote:
However, ConfigurationOfDeepTraverser>>stable: loads 'DeepTraverser-StefanReichhart.9'
(the old one)

nicolas


On 23/06/2015 17:20, Nicolas Anquetil wrote:
works !

many thanks

nicolas

On 22/06/2015 20:38, Tudor Girba wrote:
Number deepCollect: #superclass


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: DeepTraverser

Usman Bhatti
In reply to this post by Tudor Girba-2
I confirm that it is working for me.

usman

On Fri, Jul 10, 2015 at 12:48 PM, Tudor Girba <[hidden email]> wrote:
I forgot to mention that this should be fixed now. Could you check?

Doru

On Thu, Jul 2, 2015 at 5:01 PM, Nicolas Anquetil <[hidden email]> wrote:


Hi,

any agenda for this?

nicolas


On 23/06/2015 17:40, Tudor Girba wrote:
Thanks. As I said, we wanted to ensure that it works and now we will release a stable version for Pharo 4.

Doru

On Tue, Jun 23, 2015 at 5:21 PM, Nicolas Anquetil <[hidden email]> wrote:
However, ConfigurationOfDeepTraverser>>stable: loads 'DeepTraverser-StefanReichhart.9'
(the old one)

nicolas


On 23/06/2015 17:20, Nicolas Anquetil wrote:
works !

many thanks

nicolas

On 22/06/2015 20:38, Tudor Girba wrote:
Number deepCollect: #superclass


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev