I am trying to push a simple enhancement to Pharo50inbox on
smalltalkhub.com. I am running Pharo 5.0 (downloaded within the
last month) on Windows 10. |
Hi mark, it seems that your package: Regex-Core-MarkBratcher.39.mcz is not the inbox. if you have the package, then you can Copy(button in the monticello browser) it to the inbox, and try again. On Tue, Jun 14, 2016 at 9:53 PM, Mark Bratcher <[hidden email]> wrote:
Bernardo E.C. Sent from a cheap desktop computer in South America. |
i forgot to mention that i used to save my slices locally in a directory, and test the slice with a new image and see if the merge of the slice has no conflicts, to be sure that the monkey will work without problems. and then i copy the slice to the inbox On Tue, Jun 14, 2016 at 10:53 PM, Bernardo Ezequiel Contreras <[hidden email]> wrote:
Bernardo E.C. Sent from a cheap desktop computer in South America. |
Bernardo Thank you. That's a good idea. I'll try that. I was surprised that it didn't go to the inbox as I thought I set up the repository path properly. Mark Sent from TypeApp On Jun 14, 2016, at 10:00 PM, Bernardo Ezequiel Contreras <[hidden email]> wrote:
|
there's something fishy going on. (the dependency wasn't save to the inbox). in the other hand, the contribution steps could be improved On Tue, Jun 14, 2016 at 11:03 PM, Mark Bratcher <[hidden email]> wrote:
Bernardo E.C. Sent from a cheap desktop computer in South America. |
In reply to this post by vonbecmann
I have the same error, even if I save the slice to a local repository. So my steps are: 1) Open a clean Pharo 5.0 image 2) Modify one class#selector in Regex-Core 3) "Accept" the change (it prompts me to enter my name, which I do as MarkBratcher) 4) Open Monticello, and see "*Regex-Core (TheIntegrator.38)" as the only dirty package 5) Click on Slice, select a fogbugz ID, and let it auto-fill 6) Click the checkbox next to "*Regex-Core (TheIntegrator.38)" (the only dirty package listed) 7) Click OK for the Slice dialog 8) Now "*Regex-Core (TheIntegrator.38)" AND "*SLICE-..." (with
Regex-Core (TheIntegrator.38) appearing as part of that package)
both appear in the left pane of Monticello 9) Select the SLICE package on the left Monticello pane, select the repository on the right pane 10) Save the SLICE package to the repository (click Save). Both
the SLICE and Regex-Core versions bump (Regex-Core
(TheIntegrator.38) becomes Regex-Core (MarkBratcher.39)) and are
no longer dirty. A success dialog pops up with info about the
repository save, including a comment that the SLICE has
"Regex-Core (MarkBratcher.39)" as a dependency. 11) Exit Pharo 12) Reopen Pharo with a clean image 13) Open Monticello and open the repository that I saved the slice in 14) Click on the SLICE and click "Load" 15) I get the error that it cannot find the dependency on "Regex-Core (MarkBratcher.39)". I'm not sure why. On 6/14/2016 9:59 PM, Bernardo Ezequiel
Contreras wrote:
|
In reply to this post by vonbecmann
I opened the MCZ file saved for the slice package and it has no code
changes in it. It just has the dependency information. So it does
seem that more has to be saved to the repository than just the
SLICE. Or, the SLICE operation isn't "capturing" the code properly
as part of the package. In one of my attempts, I did try saving both
the SLICE and the package independently, but that didn't get rid of
the error.
On 6/14/2016 10:23 PM, Bernardo
Ezequiel Contreras wrote:
|
the slice has no code, it just a reference to the dependencies (the dirty packages), those dirty packages should be save in the repository(files ended with mcz in your directory) if you don't have those files in the local repository(directory), theres a bug. On Tue, Jun 14, 2016 at 11:33 PM, Mark Bratcher <[hidden email]> wrote:
Bernardo E.C. Sent from a cheap desktop computer in South America. |
Just saving the slice to the repository (as the instructions
indicate) does not save the code also, and Monticello marks the
slice and associated packages all clean when just saving the
slice. So I'm thinking bug...? On 6/14/2016 10:38 PM, Bernardo
Ezequiel Contreras wrote:
|
i tried your steps locally in a directory with a fake change and i couldnt reproduce the bug, i got the slice and the dependent package(with the fake change). please report it, someone with more knowledge should check it. On Tue, Jun 14, 2016 at 11:54 PM, Mark Bratcher <[hidden email]> wrote:
Bernardo E.C. Sent from a cheap desktop computer in South America. |
Thanks for trying it. Are you on Windows and Pharo 5.0? Can you tell me what item you changed? I'd be curious just to try
the same thing. On 6/14/2016 11:04 PM, Bernardo
Ezequiel Contreras wrote:
|
im on debian with Pharo5.0 Latest update: #50760 i just add a whitespace in the class comment of the class RxParser and then follow your steps, saving the slice locally in a directory. On Wed, Jun 15, 2016 at 12:08 AM, Mark Bratcher <[hidden email]> wrote:
Bernardo E.C. Sent from a cheap desktop computer in South America. |
I just tried it on my Ubuntu workstation and it appeared to save everything like it should. So it seems specific to the Windows version. On 6/14/2016 11:37 PM, Bernardo
Ezequiel Contreras wrote:
|
Free forum by Nabble | Edit this page |