Deprecation TheWorldMenu in Pharo 1.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Deprecation TheWorldMenu in Pharo 1.1

Lukas Renggli
What is the point of leaving the empty class TheWorldMenu in Pharo
1.1? Obviously it is deprecated, but then all its methods are removed.

I run across code like the following one in numerous packages:

        Smalltalk at: #TheWorldMenu ifPresent:
                [:theWorldMenu |  theWorldMenu registerOpenCommand:
                        { 'RFB/VNC Server' . { RFBServerGUI . #open } .
                          'Configure access to this desktop from remote VNC viewers.' }]

Of course this now fails, because the class is there but none of its
code? Would it be possible to either entirely remove the class or add
deprecated methods (they don't even need to do anything)?

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Deprecation TheWorldMenu in Pharo 1.1

Stéphane Ducasse
We should probably add the methods back so that people can load they code.


On Mar 19, 2010, at 10:26 AM, Lukas Renggli wrote:

> What is the point of leaving the empty class TheWorldMenu in Pharo
> 1.1? Obviously it is deprecated, but then all its methods are removed.
>
> I run across code like the following one in numerous packages:
>
> Smalltalk at: #TheWorldMenu ifPresent:
> [:theWorldMenu |  theWorldMenu registerOpenCommand:
> { 'RFB/VNC Server' . { RFBServerGUI . #open } .
>  'Configure access to this desktop from remote VNC viewers.' }]
>
> Of course this now fails, because the class is there but none of its
> code? Would it be possible to either entirely remove the class or add
> deprecated methods (they don't even need to do anything)?
>
> Lukas
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Deprecation TheWorldMenu in Pharo 1.1

Lukas Renggli
Yeah, the class comment says: "Just a placeholder so that old code can
still load."

However since all methods are missing old code doesn't load any better
than if the complete class would be gone.

The following commit in the inbox adds a few deprecated messages that.
That should improve the situation and make old code loadable again.

Name: Morphic-LukasRenggli.551
Author: lr
Time: 19 March 2010, 5:50:07 pm
UUID: 7962d62e-ae62-45e2-b950-2fa8c9b7145a
Ancestors: Morphic-StephaneDucasse.550

- added some depreacated methods to TheWorldMenu

Lukas




On 19 March 2010 17:04, Stéphane Ducasse <[hidden email]> wrote:

> We should probably add the methods back so that people can load they code.
>
>
> On Mar 19, 2010, at 10:26 AM, Lukas Renggli wrote:
>
>> What is the point of leaving the empty class TheWorldMenu in Pharo
>> 1.1? Obviously it is deprecated, but then all its methods are removed.
>>
>> I run across code like the following one in numerous packages:
>>
>>       Smalltalk at: #TheWorldMenu ifPresent:
>>               [:theWorldMenu |  theWorldMenu registerOpenCommand:
>>                       { 'RFB/VNC Server' . { RFBServerGUI . #open } .
>>                         'Configure access to this desktop from remote VNC viewers.' }]
>>
>> Of course this now fails, because the class is there but none of its
>> code? Would it be possible to either entirely remove the class or add
>> deprecated methods (they don't even need to do anything)?
>>
>> Lukas
>>
>> --
>> Lukas Renggli
>> http://www.lukas-renggli.ch
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Deprecation TheWorldMenu in Pharo 1.1

Stéphane Ducasse
Thanks lukas

Stef

On Mar 19, 2010, at 5:53 PM, Lukas Renggli wrote:

> Yeah, the class comment says: "Just a placeholder so that old code can
> still load."
>
> However since all methods are missing old code doesn't load any better
> than if the complete class would be gone.
>
> The following commit in the inbox adds a few deprecated messages that.
> That should improve the situation and make old code loadable again.
>
> Name: Morphic-LukasRenggli.551
> Author: lr
> Time: 19 March 2010, 5:50:07 pm
> UUID: 7962d62e-ae62-45e2-b950-2fa8c9b7145a
> Ancestors: Morphic-StephaneDucasse.550
>
> - added some depreacated methods to TheWorldMenu
>
> Lukas
>
>
>
>
> On 19 March 2010 17:04, Stéphane Ducasse <[hidden email]> wrote:
>> We should probably add the methods back so that people can load they code.
>>
>>
>> On Mar 19, 2010, at 10:26 AM, Lukas Renggli wrote:
>>
>>> What is the point of leaving the empty class TheWorldMenu in Pharo
>>> 1.1? Obviously it is deprecated, but then all its methods are removed.
>>>
>>> I run across code like the following one in numerous packages:
>>>
>>>       Smalltalk at: #TheWorldMenu ifPresent:
>>>               [:theWorldMenu |  theWorldMenu registerOpenCommand:
>>>                       { 'RFB/VNC Server' . { RFBServerGUI . #open } .
>>>                         'Configure access to this desktop from remote VNC viewers.' }]
>>>
>>> Of course this now fails, because the class is there but none of its
>>> code? Would it be possible to either entirely remove the class or add
>>> deprecated methods (they don't even need to do anything)?
>>>
>>> Lukas
>>>
>>> --
>>> Lukas Renggli
>>> http://www.lukas-renggli.ch
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
>
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Deprecation TheWorldMenu in Pharo 1.1

garduino
In reply to this post by Stéphane Ducasse
2010/3/19 Stéphane Ducasse <[hidden email]>:
> We should probably add the methods back so that people can load they code.
>

+1

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project