Dictionary tests are failing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Dictionary tests are failing

Guillermo Polito
Looks like a refactor in the tests that is not finished. There is a bit of a mess between #collectionClass and #classToBeTested in that hierarchy.

Is somebody working on that? I see no open issue.

Guille
Reply | Threaded
Open this post in threaded view
|

Re: Dictionary tests are failing

Marcus Denker-4

> On 18 Aug 2015, at 10:45, Guillermo Polito <[hidden email]> wrote:
>
> Looks like a refactor in the tests that is not finished. There is a bit of a mess between #collectionClass and #classToBeTested in that hierarchy.
>
> Is somebody working on that? I see no open issue.
>

This seems to be a side effect of the CollectionTests -> Collection-Tests change.

The odd thing is that the slice was tested OK.

We should add an issue.

(and put some effort into green tests…)

        Marcus


Reply | Threaded
Open this post in threaded view
|

Re: Dictionary tests are failing

Guillermo Polito
I'll do it!

El mar., 18 de ago. de 2015 a la(s) 10:59 a. m., Marcus Denker <[hidden email]> escribió:

> On 18 Aug 2015, at 10:45, Guillermo Polito <[hidden email]> wrote:
>
> Looks like a refactor in the tests that is not finished. There is a bit of a mess between #collectionClass and #classToBeTested in that hierarchy.
>
> Is somebody working on that? I see no open issue.
>

This seems to be a side effect of the CollectionTests -> Collection-Tests change.

The odd thing is that the slice was tested OK.

We should add an issue.

(and put some effort into green tests…)

        Marcus


Reply | Threaded
Open this post in threaded view
|

Re: Dictionary tests are failing

Guillermo Polito

El mar., 18 de ago. de 2015 a la(s) 11:03 a. m., Guillermo Polito <[hidden email]> escribió:
I'll do it!

El mar., 18 de ago. de 2015 a la(s) 10:59 a. m., Marcus Denker <[hidden email]> escribió:

> On 18 Aug 2015, at 10:45, Guillermo Polito <[hidden email]> wrote:
>
> Looks like a refactor in the tests that is not finished. There is a bit of a mess between #collectionClass and #classToBeTested in that hierarchy.
>
> Is somebody working on that? I see no open issue.
>

This seems to be a side effect of the CollectionTests -> Collection-Tests change.

The odd thing is that the slice was tested OK.

We should add an issue.

(and put some effort into green tests…)

        Marcus