Double line feeds in some method source

Hello all,

I built an image from the 1.0 image (congratulations/thanks to all!!!!) and have noticed that some of the method source has extra line feeds.  So far, I have not noticed anything that the affected classes/methods/packages/etc. have in common.

Anyone else seeing this?

Bill


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

On Apr 16, 2010, at 12:55 AM, Schwab,Wilhelm K wrote:

> Hello all,
>
> I built an image from the 1.0 image (congratulations/thanks to all!!!!) and have noticed that some of the method source has extra line feeds.  So far, I have not noticed anything that the affected classes/methods/packages/etc. have in common.

can you give us a list? or some samples to check?

Stef


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

>> I built an image from the 1.0 image (congratulations/thanks to all!!!!) and have noticed that some of the method source has extra line feeds.  So far, I have not noticed anything that the affected classes/methods/packages/etc. have in common.
>
> can you give us a list? or some samples to check?

What kind of extra line feeds? That kind of stuff can be easily fixed
with the regexp extension to the refactoring engine.

Lukas

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Lukas,

I recognize that lots of hard work goes into refactoring, but code should be able to move freely out of one image and into the next.  In the cases that caught my attention, the code is "double spaced" and it should not be.

Bill



-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Lukas Renggli
Sent: Friday, April 16, 2010 3:13 AM
To: [hidden email]
Subject: Re: [Pharo-project] Double line feeds in some method source

>> I built an image from the 1.0 image (congratulations/thanks to all!!!!) and have noticed that some of the method source has extra line feeds.  So far, I have not noticed anything that the affected classes/methods/packages/etc. have in common.
>
> can you give us a list? or some samples to check?

What kind of extra line feeds? That kind of stuff can be easily fixed with the regexp extension to the refactoring engine.

Lukas

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Stef,

There is a weird mix of code that I generated (which could easily violate Pharo's expectations for line termination), some code that I originally exported from Dolphin using SIF, edited using regular expressions and then imported using SIF.  All of it looked as intended in RC1, and all of it was simply saved using MC and loaded into 1.0 where the spacing is overly aggressive.  To complicate things, I am fairly certain that there is also affected code that was subjected only to browsers and MC.

A good place to start would be to look for a small package with some offenders that will reproduce the problem.  I will try to find one.

Bill


-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Stéphane Ducasse
Sent: Friday, April 16, 2010 3:10 AM
To: [hidden email]
Subject: Re: [Pharo-project] Double line feeds in some method source


On Apr 16, 2010, at 12:55 AM, Schwab,Wilhelm K wrote:

> Hello all,
>
> I built an image from the 1.0 image (congratulations/thanks to all!!!!) and have noticed that some of the method source has extra line feeds.  So far, I have not noticed anything that the affected classes/methods/packages/etc. have in common.

can you give us a list? or some samples to check?

Stef


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

On Apr 16, 2010, at 1:04 41PM, Schwab,Wilhelm K wrote:

> Lukas,
>
> I recognize that lots of hard work goes into refactoring, but code should be able to move freely out of one image and into the next.  In the cases that caught my attention, the code is "double spaced" and it should not be.
>
> Bill
>

There's no way anyone is going to spend time trying to chase that down without additional detail.
Specifically thinking of the methods used for exporting/importing code as part of building an image, as well as version of the image where non-duplicate lf code was produced and saved elsewhere, whether the source on disk contains double lfs so you can say if it's due to import/export, what settings the file readers/writers had (lf convention, encoder, etc...).

In essence, unless you give enough detail to reproduce, noone is going to bother looking into it. Even if you register an issue for it.

Cheers,
Henry
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Henry,

What makes you think that "providing more detail" is news to me?  Note that I started this thread to see if anyone else was noticing this problem; the day such discussion is always met with "if you don't... there's no way..." then we will not have a functioning forum.

My message to Lukas was simply that the RB is not the place to fix this.  As for the rest, see my resonse to Stef.  

Bill



-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Henrik Johansen
Sent: Friday, April 16, 2010 6:12 AM
To: [hidden email]
Subject: Re: [Pharo-project] Double line feeds in some method source


On Apr 16, 2010, at 1:04 41PM, Schwab,Wilhelm K wrote:

> Lukas,
>
> I recognize that lots of hard work goes into refactoring, but code should be able to move freely out of one image and into the next.  In the cases that caught my attention, the code is "double spaced" and it should not be.
>
> Bill
>

There's no way anyone is going to spend time trying to chase that down without additional detail.
Specifically thinking of the methods used for exporting/importing code as part of building an image, as well as version of the image where non-duplicate lf code was produced and saved elsewhere, whether the source on disk contains double lfs so you can say if it's due to import/export, what settings the file readers/writers had (lf convention, encoder, etc...).

In essence, unless you give enough detail to reproduce, noone is going to bother looking into it. Even if you register an issue for it.

Cheers,
Henry
_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

On Apr 16, 2010, at 1:21 41PM, Schwab,Wilhelm K wrote:

> Henry,
>
> What makes you think that "providing more detail" is news to me?  Note that I started this thread to see if anyone else was noticing this problem;

What does it matter if others have encountered it too, when you actually have?

> the day such discussion is always met with "if you don't... there's no way..." then we will not have a functioning forum.

I was merely being blunt for once on what such a post was likely to achieve. Sorry.

>
> My message to Lukas was simply that the RB is not the place to fix this.

If your intent is in fact to get a fix for whatever is causing this for you, your original post was of no use at all, except to raise inquiries for further information.

>  As for the rest, see my resonse to Stef.  
>
> Bill

"All of it looked as intended in RC1, and all of it was simply saved using MC and loaded into 1.0 where the spacing is overly aggressive. "
See, that's more like it. :D Looking forward to a package with which it is reproduceable.

Cheers,
Henry


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project