ECompletion/OCompletion tests takes A LIFE!!
Locked
12
12
ECompletion/OCompletion tests takes A LIFE!!
 
|
Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev image. If I just take a core image, load OCompletion and run tests, they take a lot of time, not acceptable.
Now....if I build a Dev image (with OB, RB, etc) and at the end I try to run OCompletion tests, the tests takes HOURS. The image seems frozen, but actually is working. If I interrupt I see the problem is in ECUntypedModel >> initializeSelectors the part of [ Smalltalk environment keysDo: [ :each | selectors add: (ECGlobalEntry contents: each type: #globalVar) ]. takes a lot of time and it seems related to "ECPreferences caseSensitive" and "ECUntypedModel >> resetSelectors" I don't know what else to say. To reproduce, take a PharoCore 1.1 and evaluate: Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfOCompletion'; load. (ConfigurationOfOCompletion project version: '1.2') load: 'Core Tests' Then, run all the tests inside OCompletionTests. You will see that after running some threads....it will look like frozen. There, do an interrupt and analize. IF you do that for a Dev image, it takes muuuuch more. I guess this is because "Smalltalk environment keys" will have muuuuuch more elements than a simple core. Anyway, help is appreciated. Cheers Mariano _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On Sun, 26 Sep 2010, Mariano Martinez Peck wrote:
> Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev image. > If I just take a core image, load OCompletion and run tests, they take a lot > of time, not acceptable. 7-8 seconds in Squeak using Cog. > > Now....if I build a Dev image (with OB, RB, etc) and at the end I try to run > OCompletion tests, the tests takes HOURS. The image seems frozen, but > actually is working. If I interrupt I see the problem is in > > ECUntypedModel >> initializeSelectors > > the part of > > > [ Smalltalk environment keysDo: > [ :each | > selectors add: (ECGlobalEntry > contents: each > type: #globalVar) ]. > > > takes a lot of time I know I'm saying this all the time, but it's true: SortedCollection is not suitable for this usage. Levente > > and it seems related to "ECPreferences caseSensitive" and "ECUntypedModel >>> resetSelectors" > > I don't know what else to say. To reproduce, take a PharoCore 1.1 and > evaluate: > > Gofer new > squeaksource: 'MetacelloRepository'; > package: 'ConfigurationOfOCompletion'; > load. > > (ConfigurationOfOCompletion project version: '1.2') load: 'Core Tests' > > Then, run all the tests inside OCompletionTests. You will see that after > running some threads....it will look like frozen. There, do an interrupt and > analize. > > IF you do that for a Dev image, it takes muuuuch more. I guess this is > because "Smalltalk environment keys" will have muuuuuch more elements than a > simple core. > > Anyway, help is appreciated. > > Cheers > > Mariano > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
In reply to this post by Mariano Martinez Peck
On Sep 26, 2010, at 7:03 PM, Levente Uzonyi wrote: > On Sun, 26 Sep 2010, Mariano Martinez Peck wrote: > >> Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev image. >> If I just take a core image, load OCompletion and run tests, they take a lot >> of time, not acceptable. > > 7-8 seconds in Squeak using Cog. and in squeak wihout Cog? >> Now....if I build a Dev image (with OB, RB, etc) and at the end I try to run >> OCompletion tests, the tests takes HOURS. The image seems frozen, but >> actually is working. If I interrupt I see the problem is in >> >> ECUntypedModel >> initializeSelectors >> >> the part of >> >> >> [ Smalltalk environment keysDo: >> [ :each | >> selectors add: (ECGlobalEntry >> contents: each >> type: #globalVar) ]. >> >> >> takes a lot of time > > I know I'm saying this all the time, but it's true: SortedCollection is not suitable for this usage. > > > Levente _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On Sun, 26 Sep 2010, Stéphane Ducasse wrote:
> > On Sep 26, 2010, at 7:03 PM, Levente Uzonyi wrote: > >> On Sun, 26 Sep 2010, Mariano Martinez Peck wrote: >> >>> Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev image. >>> If I just take a core image, load OCompletion and run tests, they take a lot >>> of time, not acceptable. >> >> 7-8 seconds in Squeak using Cog. > and in squeak wihout Cog? Levente > >>> Now....if I build a Dev image (with OB, RB, etc) and at the end I try to run >>> OCompletion tests, the tests takes HOURS. The image seems frozen, but >>> actually is working. If I interrupt I see the problem is in >>> >>> ECUntypedModel >> initializeSelectors >>> >>> the part of >>> >>> >>> [ Smalltalk environment keysDo: >>> [ :each | >>> selectors add: (ECGlobalEntry >>> contents: each >>> type: #globalVar) ]. >>> >>> >>> takes a lot of time >> >> I know I'm saying this all the time, but it's true: SortedCollection is not suitable for this usage. >> >> >> Levente > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
My Pharo 1.1 Dev, cog image:
OrderedCollection with an initial size of 500 and without sorting, no case sensitive, - 23 seconds OrderedCollection with an initial size of 500 and without sorting, case sensitive, - 17/18 seconds OrderedCollection with an initial size of 500 and sorting with #sortBy:, no case sensitive - 25 seconds OrderedCollection with an initial size of 500 and sorting with #sortBy:, case sensitive - 21 seconds Hope it helps, cheers Guille 2010/9/26 Levente Uzonyi <[hidden email]>
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
Ah, I forgot:
SortedCollection no case sensitive -> 58 seconds SortedCollection case sensitive -> 56 seconds On Mon, Sep 27, 2010 at 1:43 AM, Guillermo Polito <[hidden email]> wrote: My Pharo 1.1 Dev, cog image: _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
In reply to this post by Mariano Martinez Peck
mariano can you open a bug entry.
Stef On Sep 26, 2010, at 6:21 PM, Mariano Martinez Peck wrote: > Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev image. If I just take a core image, load OCompletion and run tests, they take a lot of time, not acceptable. > > Now....if I build a Dev image (with OB, RB, etc) and at the end I try to run OCompletion tests, the tests takes HOURS. The image seems frozen, but actually is working. If I interrupt I see the problem is in > > ECUntypedModel >> initializeSelectors > > the part of > > > [ Smalltalk environment keysDo: > [ :each | > selectors add: (ECGlobalEntry > contents: each > type: #globalVar) ]. > > > takes a lot of time > > and it seems related to "ECPreferences caseSensitive" and "ECUntypedModel >> resetSelectors" > > I don't know what else to say. To reproduce, take a PharoCore 1.1 and evaluate: > > Gofer new > squeaksource: 'MetacelloRepository'; > package: 'ConfigurationOfOCompletion'; > load. > > (ConfigurationOfOCompletion project version: '1.2') load: 'Core Tests' > > Then, run all the tests inside OCompletionTests. You will see that after running some threads....it will look like frozen. There, do an interrupt and analize. > > IF you do that for a Dev image, it takes muuuuch more. I guess this is because "Smalltalk environment keys" will have muuuuuch more elements than a simple core. > > Anyway, help is appreciated. > > Cheers > > Mariano > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
In a plain ECompletion image the code
> [ Smalltalk environment keysDo: > [ :each | > selectors add: (ECGlobalEntry > contents: each > type: #globalVar) ]. takes around 30 milliseconds to evaluate. Lukas On 27 September 2010 16:23, Stéphane Ducasse <[hidden email]> wrote: > mariano can you open a bug entry. > > Stef > On Sep 26, 2010, at 6:21 PM, Mariano Martinez Peck wrote: > >> Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev image. If I just take a core image, load OCompletion and run tests, they take a lot of time, not acceptable. >> >> Now....if I build a Dev image (with OB, RB, etc) and at the end I try to run OCompletion tests, the tests takes HOURS. The image seems frozen, but actually is working. If I interrupt I see the problem is in >> >> ECUntypedModel >> initializeSelectors >> >> the part of >> >> >> [ Smalltalk environment keysDo: >> [ :each | >> selectors add: (ECGlobalEntry >> contents: each >> type: #globalVar) ]. >> >> >> takes a lot of time >> >> and it seems related to "ECPreferences caseSensitive" and "ECUntypedModel >> resetSelectors" >> >> I don't know what else to say. To reproduce, take a PharoCore 1.1 and evaluate: >> >> Gofer new >> squeaksource: 'MetacelloRepository'; >> package: 'ConfigurationOfOCompletion'; >> load. >> >> (ConfigurationOfOCompletion project version: '1.2') load: 'Core Tests' >> >> Then, run all the tests inside OCompletionTests. You will see that after running some threads....it will look like frozen. There, do an interrupt and analize. >> >> IF you do that for a Dev image, it takes muuuuch more. I guess this is because "Smalltalk environment keys" will have muuuuuch more elements than a simple core. >> >> Anyway, help is appreciated. >> >> Cheers >> >> Mariano >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
IF you take a 1.1 core and just load OCompletion:
MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 If you load OCompletion and the rest of the dev image: MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 However, IN pharo dev 1.0 it is MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 sooo.... ???? something has changed? cheers Mariano
On Mon, Sep 27, 2010 at 9:30 PM, Lukas Renggli <[hidden email]> wrote:
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On Mon, 27 Sep 2010, Mariano Martinez Peck wrote:
> IF you take a 1.1 core and just load OCompletion: > > MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 > > If you load OCompletion and the rest of the dev image: > > MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 > > > However, IN pharo dev 1.0 it is > > MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 > > > sooo.... ???? > > something has changed? have n classes in the system, the method takes O(n^2) time. I have already fixed this, though it's not available yet. Using the Pharo 1.1 OneClick image I get these values for [ECContextTest new testUntypedVarsOnly] timeToRun : Old: 28227 New: 1241 Levente > > cheers > > Mariano > > > On Mon, Sep 27, 2010 at 9:30 PM, Lukas Renggli <[hidden email]> wrote: > >> In a plain ECompletion image the code >> >>> [ Smalltalk environment keysDo: >>> [ :each | >>> selectors add: (ECGlobalEntry >>> contents: each >>> type: #globalVar) ]. >> >> takes around 30 milliseconds to evaluate. >> >> Lukas >> >> On 27 September 2010 16:23, Stéphane Ducasse <[hidden email]> >> wrote: >>> mariano can you open a bug entry. >>> >>> Stef >>> On Sep 26, 2010, at 6:21 PM, Mariano Martinez Peck wrote: >>> >>>> Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev >> image. If I just take a core image, load OCompletion and run tests, they >> take a lot of time, not acceptable. >>>> >>>> Now....if I build a Dev image (with OB, RB, etc) and at the end I try to >> run OCompletion tests, the tests takes HOURS. The image seems frozen, but >> actually is working. If I interrupt I see the problem is in >>>> >>>> ECUntypedModel >> initializeSelectors >>>> >>>> the part of >>>> >>>> >>>> [ Smalltalk environment keysDo: >>>> [ :each | >>>> selectors add: (ECGlobalEntry >>>> contents: each >>>> type: #globalVar) ]. >>>> >>>> >>>> takes a lot of time >>>> >>>> and it seems related to "ECPreferences caseSensitive" and >> "ECUntypedModel >> resetSelectors" >>>> >>>> I don't know what else to say. To reproduce, take a PharoCore 1.1 and >> evaluate: >>>> >>>> Gofer new >>>> squeaksource: 'MetacelloRepository'; >>>> package: 'ConfigurationOfOCompletion'; >>>> load. >>>> >>>> (ConfigurationOfOCompletion project version: '1.2') load: 'Core Tests' >>>> >>>> Then, run all the tests inside OCompletionTests. You will see that after >> running some threads....it will look like frozen. There, do an interrupt and >> analize. >>>> >>>> IF you do that for a Dev image, it takes muuuuch more. I guess this is >> because "Smalltalk environment keys" will have muuuuuch more elements than a >> simple core. >>>> >>>> Anyway, help is appreciated. >>>> >>>> Cheers >>>> >>>> Mariano >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> >> -- >> Lukas Renggli >> www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
2010/9/27 Levente Uzonyi <[hidden email]>
But in Pharo 1.0 OCompletion was doing the same....so? did SortedCollection chang between 1.0 and 1.1? If you have n classes in the system, the method takes O(n^2) time. I have already fixed this, though it's not available yet. let us know when this is available.
_______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On Mon, 27 Sep 2010, Mariano Martinez Peck wrote:
> 2010/9/27 Levente Uzonyi <[hidden email]> > >> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >> >> IF you take a 1.1 core and just load OCompletion: >>> >>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>> >>> If you load OCompletion and the rest of the dev image: >>> >>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>> >>> >>> However, IN pharo dev 1.0 it is >>> >>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>> >>> >>> sooo.... ???? >>> >>> something has changed? >>> >> >> As I said, SortedCollection is not suitable for this kind of usage. > > > But in Pharo 1.0 OCompletion was doing the same....so? did SortedCollection > chang between 1.0 and 1.1? with the new code. > > >> If you have n classes in the system, the method takes O(n^2) time. I have >> already fixed this, though it's not available yet. >> > > let us know when this is available. A preview version is available here: http://leves.web.elte.hu/squeak/Ocompletion-ul.77.mcz It should work in Pharo 1.1, though it has some additional Squeak specific code which is unnecessary for Pharo. Levente > > >> >> Using the Pharo 1.1 OneClick image I get these values for >> [ECContextTest new testUntypedVarsOnly] timeToRun : >> Old: 28227 >> New: 1241 >> >> >> Levente >> >> >> >>> cheers >>> >>> Mariano >>> >>> >>> On Mon, Sep 27, 2010 at 9:30 PM, Lukas Renggli <[hidden email]> wrote: >>> >>> In a plain ECompletion image the code >>>> >>>> [ Smalltalk environment keysDo: >>>>> [ :each | >>>>> selectors add: (ECGlobalEntry >>>>> contents: each >>>>> type: #globalVar) ]. >>>>> >>>> >>>> takes around 30 milliseconds to evaluate. >>>> >>>> Lukas >>>> >>>> On 27 September 2010 16:23, Stéphane Ducasse <[hidden email]> >>>> wrote: >>>> >>>>> mariano can you open a bug entry. >>>>> >>>>> Stef >>>>> On Sep 26, 2010, at 6:21 PM, Mariano Martinez Peck wrote: >>>>> >>>>> Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev >>>>>> >>>>> image. If I just take a core image, load OCompletion and run tests, they >>>> take a lot of time, not acceptable. >>>> >>>>> >>>>>> Now....if I build a Dev image (with OB, RB, etc) and at the end I try >>>>>> to >>>>>> >>>>> run OCompletion tests, the tests takes HOURS. The image seems frozen, >>>> but >>>> actually is working. If I interrupt I see the problem is in >>>> >>>>> >>>>>> ECUntypedModel >> initializeSelectors >>>>>> >>>>>> the part of >>>>>> >>>>>> >>>>>> [ Smalltalk environment keysDo: >>>>>> [ :each | >>>>>> selectors add: (ECGlobalEntry >>>>>> contents: each >>>>>> type: #globalVar) ]. >>>>>> >>>>>> >>>>>> takes a lot of time >>>>>> >>>>>> and it seems related to "ECPreferences caseSensitive" and >>>>>> >>>>> "ECUntypedModel >> resetSelectors" >>>> >>>>> >>>>>> I don't know what else to say. To reproduce, take a PharoCore 1.1 and >>>>>> >>>>> evaluate: >>>> >>>>> >>>>>> Gofer new >>>>>> squeaksource: 'MetacelloRepository'; >>>>>> package: 'ConfigurationOfOCompletion'; >>>>>> load. >>>>>> >>>>>> (ConfigurationOfOCompletion project version: '1.2') load: 'Core Tests' >>>>>> >>>>>> Then, run all the tests inside OCompletionTests. You will see that >>>>>> after >>>>>> >>>>> running some threads....it will look like frozen. There, do an interrupt >>>> and >>>> analize. >>>> >>>>> >>>>>> IF you do that for a Dev image, it takes muuuuch more. I guess this is >>>>>> >>>>> because "Smalltalk environment keys" will have muuuuuch more elements >>>> than a >>>> simple core. >>>> >>>>> >>>>>> Anyway, help is appreciated. >>>>>> >>>>>> Cheers >>>>>> >>>>>> Mariano >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> [hidden email] >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> [hidden email] >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>>> >>>> >>>> >>>> -- >>>> Lukas Renggli >>>> www.lukas-renggli.ch >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>>> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On 28.09.2010 00:07, Levente Uzonyi wrote:
> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: > >> 2010/9/27 Levente Uzonyi <[hidden email]> >> >>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>> >>> IF you take a 1.1 core and just load OCompletion: >>>> >>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>>> >>>> If you load OCompletion and the rest of the dev image: >>>> >>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>>> >>>> >>>> However, IN pharo dev 1.0 it is >>>> >>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>>> >>>> >>>> sooo.... ???? >>>> >>>> something has changed? >>>> >>> >>> As I said, SortedCollection is not suitable for this kind of usage. >> >> >> But in Pharo 1.0 OCompletion was doing the same....so? did >> SortedCollection >> chang between 1.0 and 1.1? > > No, something else changed. The same test is still 5x faster in 1.0 > dev with the new code. Preferences class >> ecompletionCaseSensitive 1.0: (1725ms) 1.1 (19724ms) Preference>>settingValue which is there for backwards-compatability in 1.1 does both symbol creation and respondsTo:, so yeah, it's much slower than the old dictionary lookup. Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote:
> On 28.09.2010 00:07, Levente Uzonyi wrote: >> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >> >>> 2010/9/27 Levente Uzonyi <[hidden email]> >>> >>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>> >>>> IF you take a 1.1 core and just load OCompletion: >>>>> >>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>>>> >>>>> If you load OCompletion and the rest of the dev image: >>>>> >>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>>>> >>>>> >>>>> However, IN pharo dev 1.0 it is >>>>> >>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>>>> >>>>> >>>>> sooo.... ???? >>>>> >>>>> something has changed? >>>>> >>>> >>>> As I said, SortedCollection is not suitable for this kind of usage. >>> >>> >>> But in Pharo 1.0 OCompletion was doing the same....so? did >>> SortedCollection >>> chang between 1.0 and 1.1? >> >> No, something else changed. The same test is still 5x faster in 1.0 dev >> with the new code. > TimeProfiler to the rescue: > Preferences class >> ecompletionCaseSensitive > 1.0: (1725ms) > 1.1 (19724ms) > > Preference>>settingValue which is there for backwards-compatability in 1.1 > does both symbol creation and respondsTo:, so yeah, it's much slower than the > old dictionary lookup. Nice find. If you check my code, you'll find that I optimized that away. :) Levente > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On 28.09.2010 00:41, Levente Uzonyi wrote:
> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: > >> On 28.09.2010 00:07, Levente Uzonyi wrote: >>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>> >>>> 2010/9/27 Levente Uzonyi <[hidden email]> >>>> >>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>> >>>>> IF you take a 1.1 core and just load OCompletion: >>>>>> >>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>>>>> >>>>>> If you load OCompletion and the rest of the dev image: >>>>>> >>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>>>>> >>>>>> >>>>>> However, IN pharo dev 1.0 it is >>>>>> >>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>>>>> >>>>>> >>>>>> sooo.... ???? >>>>>> >>>>>> something has changed? >>>>>> >>>>> >>>>> As I said, SortedCollection is not suitable for this kind of usage. >>>> >>>> >>>> But in Pharo 1.0 OCompletion was doing the same....so? did >>>> SortedCollection >>>> chang between 1.0 and 1.1? >>> >>> No, something else changed. The same test is still 5x faster in 1.0 >>> dev with the new code. >> TimeProfiler to the rescue: >> Preferences class >> ecompletionCaseSensitive >> 1.0: (1725ms) >> 1.1 (19724ms) >> >> Preference>>settingValue which is there for backwards-compatability >> in 1.1 does both symbol creation and respondsTo:, so yeah, it's much >> slower than the old dictionary lookup. > > Nice find. If you check my code, you'll find that I optimized that > away. :) > > > Levente Rewrite the methods in ECPreferences to use the new syntax: <preference: category: description: type:>, and you shouldn't even have to do that to get ok performance. IMHO, it's rather disturbing to see things like EC, where its preferences are actually separated tucked away in an ECPreferences class, only to be delegated from there over to Preferences... Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote:
> On 28.09.2010 00:41, Levente Uzonyi wrote: >> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: >> >>> On 28.09.2010 00:07, Levente Uzonyi wrote: >>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>> >>>>> 2010/9/27 Levente Uzonyi <[hidden email]> >>>>> >>>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>>> >>>>>> IF you take a 1.1 core and just load OCompletion: >>>>>>> >>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>>>>>> >>>>>>> If you load OCompletion and the rest of the dev image: >>>>>>> >>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>>>>>> >>>>>>> >>>>>>> However, IN pharo dev 1.0 it is >>>>>>> >>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>>>>>> >>>>>>> >>>>>>> sooo.... ???? >>>>>>> >>>>>>> something has changed? >>>>>>> >>>>>> >>>>>> As I said, SortedCollection is not suitable for this kind of usage. >>>>> >>>>> >>>>> But in Pharo 1.0 OCompletion was doing the same....so? did >>>>> SortedCollection >>>>> chang between 1.0 and 1.1? >>>> >>>> No, something else changed. The same test is still 5x faster in 1.0 dev >>>> with the new code. >>> TimeProfiler to the rescue: >>> Preferences class >> ecompletionCaseSensitive >>> 1.0: (1725ms) >>> 1.1 (19724ms) >>> >>> Preference>>settingValue which is there for backwards-compatability in 1.1 >>> does both symbol creation and respondsTo:, so yeah, it's much slower than >>> the old dictionary lookup. >> >> Nice find. If you check my code, you'll find that I optimized that away. :) >> >> >> Levente > Yes ,you moved it out of the actual sort loop :) > Rewrite the methods in ECPreferences to use the new syntax: > <preference: category: description: type:>, and you shouldn't even have to do > that to get ok performance. > > IMHO, it's rather disturbing to see things like EC, where its preferences are > actually separated tucked away in an ECPreferences class, only to be > delegated from there over to Preferences... The preferences should be updated, but sending a message once is still better than 2k-30k times. Levente > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
On 28.09.2010 01:43, Levente Uzonyi wrote:
> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: > >> On 28.09.2010 00:41, Levente Uzonyi wrote: >>> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: >>> >>>> On 28.09.2010 00:07, Levente Uzonyi wrote: >>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>> >>>>>> 2010/9/27 Levente Uzonyi <[hidden email]> >>>>>> >>>>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>>>> >>>>>>> IF you take a 1.1 core and just load OCompletion: >>>>>>>> >>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>>>>>>> >>>>>>>> If you load OCompletion and the rest of the dev image: >>>>>>>> >>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>>>>>>> >>>>>>>> >>>>>>>> However, IN pharo dev 1.0 it is >>>>>>>> >>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>>>>>>> >>>>>>>> >>>>>>>> sooo.... ???? >>>>>>>> >>>>>>>> something has changed? >>>>>>>> >>>>>>> >>>>>>> As I said, SortedCollection is not suitable for this kind of usage. >>>>>> >>>>>> >>>>>> But in Pharo 1.0 OCompletion was doing the same....so? did >>>>>> SortedCollection >>>>>> chang between 1.0 and 1.1? >>>>> >>>>> No, something else changed. The same test is still 5x faster in >>>>> 1.0 dev with the new code. >>>> TimeProfiler to the rescue: >>>> Preferences class >> ecompletionCaseSensitive >>>> 1.0: (1725ms) >>>> 1.1 (19724ms) >>>> >>>> Preference>>settingValue which is there for backwards-compatability >>>> in 1.1 does both symbol creation and respondsTo:, so yeah, it's >>>> much slower than the old dictionary lookup. >>> >>> Nice find. If you check my code, you'll find that I optimized that >>> away. :) >>> >>> >>> Levente >> Yes ,you moved it out of the actual sort loop :) >> Rewrite the methods in ECPreferences to use the new syntax: >> <preference: category: description: type:>, and you shouldn't even >> have to do that to get ok performance. >> >> IMHO, it's rather disturbing to see things like EC, where its >> preferences are actually separated tucked away in an ECPreferences >> class, only to be delegated from there over to Preferences... > > The preferences should be updated, but sending a message once is still > better than 2k-30k times. > > > Levente I keep forgetting the fact we generally have different definitions of what constitutes "ok performance" ;) Cheers, Henry _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
Looks like some changes of ECompletion are then missing in
OCompletion. ECompletion doesn't use Preferences for a long time anymore. Lukas On 28 September 2010 02:26, Henrik Sperre Johansen <[hidden email]> wrote: > On 28.09.2010 01:43, Levente Uzonyi wrote: >> >> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: >> >>> On 28.09.2010 00:41, Levente Uzonyi wrote: >>>> >>>> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: >>>> >>>>> On 28.09.2010 00:07, Levente Uzonyi wrote: >>>>>> >>>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>>> >>>>>>> 2010/9/27 Levente Uzonyi <[hidden email]> >>>>>>> >>>>>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>>>>> >>>>>>>> IF you take a 1.1 core and just load OCompletion: >>>>>>>>> >>>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>>>>>>>> >>>>>>>>> If you load OCompletion and the rest of the dev image: >>>>>>>>> >>>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>>>>>>>> >>>>>>>>> >>>>>>>>> However, IN pharo dev 1.0 it is >>>>>>>>> >>>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>>>>>>>> >>>>>>>>> >>>>>>>>> sooo.... ???? >>>>>>>>> >>>>>>>>> something has changed? >>>>>>>>> >>>>>>>> >>>>>>>> As I said, SortedCollection is not suitable for this kind of usage. >>>>>>> >>>>>>> >>>>>>> But in Pharo 1.0 OCompletion was doing the same....so? did >>>>>>> SortedCollection >>>>>>> chang between 1.0 and 1.1? >>>>>> >>>>>> No, something else changed. The same test is still 5x faster in 1.0 >>>>>> dev with the new code. >>>>> >>>>> TimeProfiler to the rescue: >>>>> Preferences class >> ecompletionCaseSensitive >>>>> 1.0: (1725ms) >>>>> 1.1 (19724ms) >>>>> >>>>> Preference>>settingValue which is there for backwards-compatability in >>>>> 1.1 does both symbol creation and respondsTo:, so yeah, it's much slower >>>>> than the old dictionary lookup. >>>> >>>> Nice find. If you check my code, you'll find that I optimized that away. >>>> :) >>>> >>>> >>>> Levente >>> >>> Yes ,you moved it out of the actual sort loop :) >>> Rewrite the methods in ECPreferences to use the new syntax: >>> <preference: category: description: type:>, and you shouldn't even have >>> to do that to get ok performance. >>> >>> IMHO, it's rather disturbing to see things like EC, where its preferences >>> are actually separated tucked away in an ECPreferences class, only to be >>> delegated from there over to Preferences... >> >> The preferences should be updated, but sending a message once is still >> better than 2k-30k times. >> >> >> Levente > > Sure, on the order of a couple of milliseconds difference. > I keep forgetting the fact we generally have different definitions of what > constitutes "ok performance" ;) > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
In reply to this post by Henrik Sperre Johansen
On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote:
> On 28.09.2010 01:43, Levente Uzonyi wrote: >> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: >> >>> On 28.09.2010 00:41, Levente Uzonyi wrote: >>>> On Tue, 28 Sep 2010, Henrik Sperre Johansen wrote: >>>> >>>>> On 28.09.2010 00:07, Levente Uzonyi wrote: >>>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>>> >>>>>>> 2010/9/27 Levente Uzonyi <[hidden email]> >>>>>>> >>>>>>>> On Mon, 27 Sep 2010, Mariano Martinez Peck wrote: >>>>>>>> >>>>>>>> IF you take a 1.1 core and just load OCompletion: >>>>>>>>> >>>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 20907 >>>>>>>>> >>>>>>>>> If you load OCompletion and the rest of the dev image: >>>>>>>>> >>>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 100137 >>>>>>>>> >>>>>>>>> >>>>>>>>> However, IN pharo dev 1.0 it is >>>>>>>>> >>>>>>>>> MessageTally time: [ECContextTest new testUntypedVarsOnly] 7405 >>>>>>>>> >>>>>>>>> >>>>>>>>> sooo.... ???? >>>>>>>>> >>>>>>>>> something has changed? >>>>>>>>> >>>>>>>> >>>>>>>> As I said, SortedCollection is not suitable for this kind of usage. >>>>>>> >>>>>>> >>>>>>> But in Pharo 1.0 OCompletion was doing the same....so? did >>>>>>> SortedCollection >>>>>>> chang between 1.0 and 1.1? >>>>>> >>>>>> No, something else changed. The same test is still 5x faster in 1.0 dev >>>>>> with the new code. >>>>> TimeProfiler to the rescue: >>>>> Preferences class >> ecompletionCaseSensitive >>>>> 1.0: (1725ms) >>>>> 1.1 (19724ms) >>>>> >>>>> Preference>>settingValue which is there for backwards-compatability in >>>>> 1.1 does both symbol creation and respondsTo:, so yeah, it's much slower >>>>> than the old dictionary lookup. >>>> >>>> Nice find. If you check my code, you'll find that I optimized that away. >>>> :) >>>> >>>> >>>> Levente >>> Yes ,you moved it out of the actual sort loop :) >>> Rewrite the methods in ECPreferences to use the new syntax: >>> <preference: category: description: type:>, and you shouldn't even have to >>> do that to get ok performance. >>> >>> IMHO, it's rather disturbing to see things like EC, where its preferences >>> are actually separated tucked away in an ECPreferences class, only to be >>> delegated from there over to Preferences... >> >> The preferences should be updated, but sending a message once is still >> better than 2k-30k times. >> >> >> Levente > Sure, on the order of a couple of milliseconds difference. > I keep forgetting the fact we generally have different definitions of what > constitutes "ok performance" ;) 30k was a bit optimistic assumption. For example the Pharo 1.1 OneClick image has 3220 globals. The sortBlock asks for the preference twice per evaluation. SortedCollection uses a binary search during #add:. If we are optimistic, then the preference is asked 3220 * (3220 ln / 2 ln) * 2 times which is ~75k. In the same image the "old" code asked for the preference 2282899 times during the tests, while the new code did it only 398 times. If the preference is changed to return the value of a variable, then the difference is only 80 ms, otherwise it's 36.6 seconds. Levente > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Re: ECompletion/OCompletion tests takes A LIFE!!
|
|
In reply to this post by Henrik Sperre Johansen
On > 30k was a bit optimistic assumption. For example the Pharo 1.1 OneClick image has 3220 globals. The sortBlock asks for the preference twice per evaluation. SortedCollection uses a binary search during #add:. If we are optimistic, then the preference is asked 3220 * (3220 ln / 2 ln) * 2 times which is ~75k. > > In the same image the "old" code asked for the preference 2282899 times during the tests, while the new code did it only 398 times. If the preference is changed to return the value of a variable, then the difference is only 80 ms, otherwise it's 36.6 seconds. As you see we got trap in a tempest of documents to write :) so do not forget to open bug entry wehn some actions should be taken.... Soon back to life Stef _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |