Smalltalk › Pharo › Pharo Smalltalk Developers

Epicea redoVisitor does not handle protocol changes

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 5 messages Options
stepharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Epicea redoVisitor does not handle protocol changes

stepharo
Hi

I just tried to replay a change today in Pharo60 and I got an error in
epicea.

EpRedoVisitor>>visitEvent: aChange
     ^ self error: 'Should not be reached'.

EpRedoVisitor>>visitCodeChange: aChange
     "Default behavior for any change."

     ^ self visitEvent: aChange

EpRedoVisitor>>visitBehaviorChange: aChange
     ^ self visitCodeChange: aChange

EpRedoVisitor>>visitProtocolChange: aProtocolAddition
     ^ self visitBehaviorChange: aProtocolAddition.


visitProtocolAddition: aProtocolAddition
     ^ self visitProtocolChange: aProtocolAddition


Apparently it was a

     EpProtocolAddition


And the RedoVisitor does not handle them.

I do not have the time to check further - I just want to rescue my code
for now.


Stef


tinchodias
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Epicea redoVisitor does not handle protocol changes

tinchodias
Hi,
I'm looking at it. Vincent reported it a couple of weeks ago and I fixed it (apparently not?!)

Martin

On Tue, Aug 9, 2016 at 8:56 AM, stepharo <[hidden email]> wrote:
Hi

I just tried to replay a change today in Pharo60 and I got an error in epicea.

EpRedoVisitor>>visitEvent: aChange
    ^ self error: 'Should not be reached'.

EpRedoVisitor>>visitCodeChange: aChange
    "Default behavior for any change."

    ^ self visitEvent: aChange

EpRedoVisitor>>visitBehaviorChange: aChange
    ^ self visitCodeChange: aChange

EpRedoVisitor>>visitProtocolChange: aProtocolAddition
    ^ self visitBehaviorChange: aProtocolAddition.


visitProtocolAddition: aProtocolAddition
    ^ self visitProtocolChange: aProtocolAddition


Apparently it was a

    EpProtocolAddition


And the RedoVisitor does not handle them.

I do not have the time to check further - I just want to rescue my code for now.


Stef
tinchodias
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Epicea redoVisitor does not handle protocol changes

tinchodias
Ah, you can try:

Metacello new
    smalltalkhubUser: 'MartinDias' project: 'Epicea';
    configuration: 'Epicea';
    version: '7.98';
    load.
   
you should be working in a Pharo 6 that has an old Epicea version.

Martin

On Tue, Aug 9, 2016 at 11:19 AM, Martin Dias <[hidden email]> wrote:
Hi,
I'm looking at it. Vincent reported it a couple of weeks ago and I fixed it (apparently not?!)

Martin

On Tue, Aug 9, 2016 at 8:56 AM, stepharo <[hidden email]> wrote:
Hi

I just tried to replay a change today in Pharo60 and I got an error in epicea.

EpRedoVisitor>>visitEvent: aChange
    ^ self error: 'Should not be reached'.

EpRedoVisitor>>visitCodeChange: aChange
    "Default behavior for any change."

    ^ self visitEvent: aChange

EpRedoVisitor>>visitBehaviorChange: aChange
    ^ self visitCodeChange: aChange

EpRedoVisitor>>visitProtocolChange: aProtocolAddition
    ^ self visitBehaviorChange: aProtocolAddition.


visitProtocolAddition: aProtocolAddition
    ^ self visitProtocolChange: aProtocolAddition


Apparently it was a

    EpProtocolAddition


And the RedoVisitor does not handle them.

I do not have the time to check further - I just want to rescue my code for now.


Stef
stepharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Epicea redoVisitor does not handle protocol changes

stepharo
In reply to this post by tinchodias

tx martin.

Stef


Le 9/8/16 à 16:19, Martin Dias a écrit :
Hi,
I'm looking at it. Vincent reported it a couple of weeks ago and I fixed it (apparently not?!)

Martin

On Tue, Aug 9, 2016 at 8:56 AM, stepharo <[hidden email]> wrote:
Hi

I just tried to replay a change today in Pharo60 and I got an error in epicea.

EpRedoVisitor>>visitEvent: aChange
    ^ self error: 'Should not be reached'.

EpRedoVisitor>>visitCodeChange: aChange
    "Default behavior for any change."

    ^ self visitEvent: aChange

EpRedoVisitor>>visitBehaviorChange: aChange
    ^ self visitCodeChange: aChange

EpRedoVisitor>>visitProtocolChange: aProtocolAddition
    ^ self visitBehaviorChange: aProtocolAddition.


visitProtocolAddition: aProtocolAddition
    ^ self visitProtocolChange: aProtocolAddition


Apparently it was a

    EpProtocolAddition


And the RedoVisitor does not handle them.

I do not have the time to check further - I just want to rescue my code for now.


Stef
stepharo
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Epicea redoVisitor does not handle protocol changes

stepharo
In reply to this post by tinchodias

Ah, you can try:

Metacello new
    smalltalkhubUser: 'MartinDias' project: 'Epicea';
    configuration: 'Epicea';
    version: '7.98';
    load.
   
you should be working in a Pharo 6 that has an old Epicea version.

ah yes I should migrate. I took an old pillar image.
I will change now.

Stef


Martin

On Tue, Aug 9, 2016 at 11:19 AM, Martin Dias <[hidden email]> wrote:
Hi,
I'm looking at it. Vincent reported it a couple of weeks ago and I fixed it (apparently not?!)

Martin

On Tue, Aug 9, 2016 at 8:56 AM, stepharo <[hidden email]> wrote:
Hi

I just tried to replay a change today in Pharo60 and I got an error in epicea.

EpRedoVisitor>>visitEvent: aChange
    ^ self error: 'Should not be reached'.

EpRedoVisitor>>visitCodeChange: aChange
    "Default behavior for any change."

    ^ self visitEvent: aChange

EpRedoVisitor>>visitBehaviorChange: aChange
    ^ self visitCodeChange: aChange

EpRedoVisitor>>visitProtocolChange: aProtocolAddition
    ^ self visitBehaviorChange: aProtocolAddition.


visitProtocolAddition: aProtocolAddition
    ^ self visitProtocolChange: aProtocolAddition


Apparently it was a

    EpProtocolAddition


And the RedoVisitor does not handle them.

I do not have the time to check further - I just want to rescue my code for now.


Stef
Free forum by Nabble Edit this page