Smalltalk › Pharo › Pharo Smalltalk Developers

Error in ByteArray>>booleanAt:

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

raffaello.giulietti

Error in ByteArray>>booleanAt:

Hi,

the current (Pharo 6) code reads

^(self integerAt: byteOffset size: 1 signed: false) == true

so it always returns false, as no integer is identical to true.

Instead, it should read

^(self integerAt: byteOffset size: 1 signed: false) ~= 0

implementing the usual convention that 0 maps to false and every other
value maps to true.

Greetings
Raffaello

Sven Van Caekenberghe-2

Re: Error in ByteArray>>booleanAt:

> On 22 Jun 2017, at 17:39, Raffaello Giulietti <[hidden email]> wrote:
>
> Hi,
>
> the current (Pharo 6) code reads
>
> ^(self integerAt: byteOffset size: 1 signed: false) == true
>
> so it always returns false, as no integer is identical to true.
>
>
> Instead, it should read
>
> ^(self integerAt: byteOffset size: 1 signed: false) ~= 0
>
> implementing the usual convention that 0 maps to false and every other value maps to true.
>
> Greetings
> Raffaello

Good catch, probably a typo.

IMO, there should have been unit tests to validate such code.

Pavel Krivanek-3

Re: Error in ByteArray>>booleanAt:

In reply to this post by raffaello.giulietti

https://pharo.fogbugz.com/f/cases/20176/Error-in-ByteArray-booleanAt

2017-06-22 17:39 GMT+02:00 Raffaello Giulietti <[hidden email]>:

Hi,

the current (Pharo 6) code reads

^(self integerAt: byteOffset size: 1 signed: false) == true

so it always returns false, as no integer is identical to true.

Instead, it should read

^(self integerAt: byteOffset size: 1 signed: false) ~= 0

implementing the usual convention that 0 maps to false and every other value maps to true.

Greetings
Raffaello

Eliot Miranda-2

Re: Error in ByteArray>>booleanAt:

On Fri, Jun 23, 2017 at 4:19 AM, Pavel Krivanek <[hidden email]> wrote:

https://pharo.fogbugz.com/f/cases/20176/Error-in-ByteArray-booleanAt

Fixed in

Name: FFI-Kernel-eem.46

Author: eem

Time: 23 June 2017, 10:00:42.756292 am

UUID: ab2b7c9e-0edb-4f10-8fd2-32400997fb8e

Ancestors: FFI-Kernel-EstebanLorenzano.45

Fix booleanAt:

(This is part of the FFI package)

2017-06-22 17:39 GMT+02:00 Raffaello Giulietti <[hidden email]>:
Hi,

the current (Pharo 6) code reads

^(self integerAt: byteOffset size: 1 signed: false) == true

so it always returns false, as no integer is identical to true.

Instead, it should read

^(self integerAt: byteOffset size: 1 signed: false) ~= 0

implementing the usual convention that 0 maps to false and every other value maps to true.

Greetings
Raffaello

_,,,^..^,,,_

best, Eliot