Exception converting aString to Time

Hi,

Tracking a test failure of my Application on GS 3.4.1 i found the following:
Number fromString: 'hello'.
Date fromString: 'hello'.
Boolean fromString: 'hello'.
TimeStamp fromString: 'hello'.
Time fromString: 'hello'.

From 1 to 4 raise anException but (Time fromString: 'hello') answer a valid
Time instance.

It seems a bug to me ...

regards,
bruno



--
Sent from: http://forum.world.st/GLASS-f1460844.html
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

Hi,

There are more "strange" results in Time>>fromString: method. On GS 3.4.1
this method belong to Monticello package.

Time fromString: '01256asd'. "08:00:00"
Time fromString: '0125asd'. "05:00:00"
Time fromString: '~~~'. "00:00:00"
Time fromString: '112'.  "16:00:00"
Time fromString: '1100'. "20:00:00"

regards,
bruno



--
Sent from: http://forum.world.st/GLASS-f1460844.html
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

Thanks Bruno ... I've submitted a bug[1] for this and expect to have a
bugfix in a day or so ... I'll fold it into my Magritte work:) Hopefully
I won't encounter anything that depends upon the current behavior...

Dale

[1] https://github.com/GsDevKit/GsDevKit/issues/115

On 5/4/19 2:16 PM, BrunoBB via Glass wrote:
> Number fromString: 'hello'.
> Date fromString: 'hello'.
> Boolean fromString: 'hello'.
> TimeStamp fromString: 'hello'.
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

As I suspected, there is the potential for breaking existing code as Pharo3.0 only produced an error for `~~~`:

{
    Time fromString: '01256asd'.
    Time fromString: '0125asd'.
    Time fromString: '~~~'.
    Time fromString: '112'.
    Time fromString: '1100'
}

Pharo 3.0:                                  an Array(8:00 am 5:00 am ERROR 4:00 pm 8:00 pm)

I made proposed changes to GemStone (Time class>>readFrom:) where the code produces errors for the first three cases:

GemStone 3.4.3 (with my proposed patch):    anArray( ERROR, ERROR, ERROR 16:00:00, 20:00:00)

Hi,

There are more "strange" results in Time>>fromString: method. On GS 3.4.1
this method belong to Monticello package.

Time fromString: '01256asd'. "08:00:00"
Time fromString: '0125asd'. "05:00:00"
Time fromString: '~~~'. "00:00:00"
Time fromString: '112'.  "16:00:00"
Time fromString: '1100'. "20:00:00"

regards,
bruno



--
Sent from: http://forum.world.st/GLASS-f1460844.html
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

Dale,

Thanks for the explanation.
But for me there is not hurry.
The system i working on take some XML data from Java application the Time
exception is handler but so far the time XML node always come in the
expected format :)

regards,
bruno



--
Sent from: http://forum.world.st/GLASS-f1460844.html
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

Okay ... I'll push my changes to a separate issue branch, so it will be
there if needed, but I'll defer merging it into master until we have a
better understanding of the impacts of the change ...

DAke

On 5/7/19 4:58 AM, BrunoBB via Glass wrote: _______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass