FAMIXJavaPrintVisitor missing

Hi,

 

It seems FAMIXJavaPrintVisitor has been removed from the new version: Famix-Java-AndreiChis.90…

In fact, the FAMIXJavaPrintVisitor (in Famix-Java package) inherits of FAMIXVisitor (in Famix-Extension package).

But the Famix-Java package is loaded before the Famix-Extension one.

https://ci.inria.fr/moose/job/moose-6.0/490/console:

Loaded -> Famix-Java-AndreiChis.90 --- http://smalltalkhub.com/mc/Moose/Moose/main/ --- cache

…

Loaded -> Famix-Extensions-VincentBlondeau.287 --- http://smalltalkhub.com/mc/Moose/Moose/main/ --- cache

 

So it is impossible to load the class FAMIXJavaPrintVisitor but no warning is thrown…

 

Moreover,  FAMIXJavaPrintVisitor >>visitMethod:  uses the fastBehaviouralEntity method which is not loaded in the image. So tests are not able to pass …

 

A solution is to put the print visitor in another package (e.g. Fast), isn’t it?

 

BTW, there is some *** Warning: Warning: This package depends on the following classes: warnings, maybe it should be nice to take a look?

 

Cheers,

Vincent

 

 

De : [hidden email] [mailto:[hidden email]] De la part de Nicolas Anquetil
Envoyé : lundi 5 octobre 2015 12:16
À : Moose-related development
Objet : [Moose-dev] Re: FAMIXJavaPrintVisitor missing

 

Not sure what is happening, but it could be removed (and the tests that goes along with it.

This printing visitor was introduced as part of the FASTJava (representing java AST in Famix) work.

If nobody uses it, I will move it into this package (FASTJava)

nicolas

On 05/10/2015 11:42, Andrei Chis wrote:

Hi,

 

FAMIXJavaPrintVisitor is not present in the image which makes some tests fail.

It was added in Famix-Java-synectique.87 but then removed in  Famix-Java-vincentBlondeau.88.

I added it back in Famix-Java-AndreiChis.89, but even if Monticello shows that the latest package is

loaded, FAMIXJavaPrintVisitor is still missing.

 

Any idea what is going ok?

 

Cheers,

Andrei

_______________________________________________

Moose-dev mailing list

[hidden email]

https://www.iam.unibe.ch/mailman/listinfo/moose-dev

 

---

Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité de Worldline ne pourra être recherchée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être recherchée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Worldline liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

I put FAMIXJavaPrintVisitor into a FAST package (FAST-Java-Tool) because it makes more sense for now.
The need for printing only occured because with FAST we (will) have the full AST and can therefore re-print the full code.

Printing visitor on FAMIX meta-model alone makes little sense (except for debugging?)

The tests have been moved too, so hopefully this will not cause anymore problem for basic Moose

The tests are not green in FAST, but I have no time to look at it now

nicolas

On 05/10/2015 15:44, Blondeau Vincent wrote:

There is :

-          Test canUnderstand: result instead of catching the DNU

-          See in the private state of the entity if #fastBehaviouralEntity is defined

-          Or see if the class FASTEntity is defined

 

The second can be nice but the dictionary key should not change and it bypasses the implementation of fastBehaviouralEntity method.

 

Cheers,

Vincent

 

 

De : [hidden email] [[hidden email]] De la part de Andrei Chis
Envoyé : lundi 5 octobre 2015 15:13
À : Moose-related development
Objet : [Moose-dev] Re: FAMIXJavaPrintVisitor missing

 

 

 

On Mon, Oct 5, 2015 at 2:52 PM, Blondeau Vincent <[hidden email]> wrote:

FAMIXJavaPrintVisitor can be moved to Famix-Extensions, and it will work in this package. If the DNU exception is caught, the tests are green.

 

That can also work.

But catching a DNU exception just to make the tests green seems strange.

Is there no other way to fix the functionality?

 

Cheers,

Andrei

 

 

It is not so dependent of FAST and it will be nice to integrate it correctly in the Moose image.

 

Cheers,

Vincent

 

---

Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité de Worldline ne pourra être recherchée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être recherchée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Worldline liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev