FAMIXPackage>>relativeImportanceForSystemt -> ZeroDivide

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

FAMIXPackage>>relativeImportanceForSystemt -> ZeroDivide

Andre Hora
Hello,

The method FAMIXPackage>>relativeImportanceForSystemt throws a ZeroDivide when we have a model with one package (allModelPackages=1).
Should I remove the "-1" at the end?

FAMIXPackagerelativeImportanceForSystem
    ^ self lookUpPropertyNamed: #PRIS
                 computedAs: [ self numberOfClientPackages / (self mooseModel allModelPackages size - 1)]

--
Andre Hora


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
cbc
Reply | Threaded
Open this post in threaded view
|

Re: FAMIXPackage>>relativeImportanceForSystemt -> ZeroDivide

cbc
On Fri, Jul 8, 2011 at 1:40 AM, Andre Hora <[hidden email]> wrote:
>
> FAMIXPackagerelativeImportanceForSystem
>     ^ self lookUpPropertyNamed: #PRIS
>                  computedAs: [ self numberOfClientPackages / (self
> mooseModel allModelPackages size - 1)]
>
or just protect against zero:

FAMIXPackagerelativeImportanceForSystem
    ^ self lookUpPropertyNamed: #PRIS
                 computedAs: [ self numberOfClientPackages / ((self
mooseModel allModelPackages size - 1) max: 1)]

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: FAMIXPackage>>relativeImportanceForSystemt -> ZeroDivide

Andre Hora
yes sure. just didn't understand the -1 at the end :)

On Fri, Jul 8, 2011 at 6:35 PM, Chris Cunningham <[hidden email]> wrote:
On Fri, Jul 8, 2011 at 1:40 AM, Andre Hora <[hidden email]> wrote:
>
> FAMIXPackagerelativeImportanceForSystem
>     ^ self lookUpPropertyNamed: #PRIS
>                  computedAs: [ self numberOfClientPackages / (self
> mooseModel allModelPackages size - 1)]
>
or just protect against zero:

FAMIXPackagerelativeImportanceForSystem
    ^ self lookUpPropertyNamed: #PRIS
                 computedAs: [ self numberOfClientPackages / ((self
mooseModel allModelPackages size - 1) max: 1)]

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--
Andre Hora


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev