Smalltalk › Pharo › Pharo Smalltalk Developers

[FIX]: Issue 4795: Horizontal wheel

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

21 messages Options

Sean P. DeNigris

[FIX]: Issue 4795: Horizontal wheel

Administrator

https://pharo.fogbugz.com/default.asp?4795

Fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.1
Implement Horizontal Mouse Wheel
- Update scrolling morphs to use it
- Clean up MouseWheelEvent
- Add #isUp etc. testing messages; no more Symbol comparison e.g. "event direction = #up"
- Add proper instance creation message (we were calling a private constructor from user code)

n.b. horizontal wheel event uses the same hack we already use for vertical wheel, while we're waiting for a beautiful solution ;)

Cheers,
Sean

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

Here is also a changeset for those of us who are impatient and want it in 3.0 ;)

https://gist.github.com/seandenigris/dfbc669b422c7aeaa57f

Cheers,
Sean

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

In reply to this post by Sean P. DeNigris

Sean P. DeNigris wrote

Fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.1

Merging into 40486 there are two merge conflict in Athens-Morphic and TxText-Athens. Use the incoming version for both. Should I do so and resubmit a v. 2?

Cheers,
Sean

stepharo

Re: [FIX]: Issue 4795: Horizontal wheel

Le 10/2/15 20:34, Sean P. DeNigris a écrit :
> Sean P. DeNigris wrote
>> Fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.1
> Merging into 40486 there are two merge conflict in Athens-Morphic and
> TxText-Athens. Use the incoming version for both. Should I do so and
> resubmit a v. 2?

yes please because you should not expect one guy not knowing what you
did to really do a better
merge than you the original author.

Stef

>
>
>
> -----
> Cheers,
> Sean
> --
> View this message in context: http://forum.world.st/FIX-Issue-4795-Horizontal-wheel-tp4805005p4805008.html
> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>
>

Nicolai Hess

Re: [FIX]: Issue 4795: Horizontal wheel

In reply to this post by Sean P. DeNigris

2015-02-10 20:34 GMT+01:00 Sean P. DeNigris <[hidden email]>:

Sean P. DeNigris wrote
> Fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.1

Merging into 40486 there are two merge conflict in Athens-Morphic and
TxText-Athens. Use the incoming version for both. Should I do so and
resubmit a v. 2?

Yes, please resubmit a slice without the change on AthensSceneView and TxTextEditorMorph and
open two new issues (one for Athens and one for TxText) - or I do it. And I'll fix it in athens and txtext.

nicolai

-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/FIX-Issue-4795-Horizontal-wheel-tp4805005p4805008.html

Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

Nicolai Hess wrote

Yes, please resubmit a slice without the change on AthensSceneView and
TxTextEditorMorph and
open two new issues (one for Athens and one for TxText) - or I do it. And
I'll fix it in athens and txtext.

Issue 4795 Added Subcases
14909: Update Athens Mouse Wheel
14910: Update TxText Mouse Wheel

New fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.2
This version: remove changes to Tx and Athens, which will be handled as separate issues.

Cheers,
Sean

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

Sean P. DeNigris wrote

New fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.2

Why isn't the monkey checking this? I removed the subcases and resolved it 'review needed'...
https://pharo.fogbugz.com/default.asp?4795

Cheers,
Sean

Ben Coman

Re: [FIX]: Issue 4795: Horizontal wheel

I haven't seen an announcement that the CI back online yet after its maintenance. Indeed https://ci.inria.fr/pharo/ times out at the moment.

cheers -ben

On Thu, Feb 12, 2015 at 2:40 AM, Sean P. DeNigris <[hidden email]> wrote:

Sean P. DeNigris wrote
> New fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.2

Why isn't the monkey checking this? I removed the subcases and resolved it
'review needed'...
https://pharo.fogbugz.com/default.asp?4795

-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/FIX-Issue-4795-Horizontal-wheel-tp4805005p4805185.html

Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

In reply to this post by Sean P. DeNigris

Now parent Issue 14915 Horizontal Scrolling Everywhere with Subcases:
4795: Horizontal wheel events
14907: #mouseWheel: knows too much
14909: Update Athens Mouse Wheel
14910: Update TxText Mouse Wheel
14931: Update Glamour for Horizontal ...

New fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.3
_______________________________________________________
This version: remove changes to Glamour-Morphic-Brick

v. 2: remove changes to Tx and Athens, which will be handled as separate issues.

v. 1
Implement Horizontal Mouse Wheel
- Update scrolling morphs to use it
- Clean up MouseWheelEvent
- Add #isUp etc. testing messages; no more Symbol comparison e.g. "event direction = #up"
- Add proper instance creation message (we were calling a private constructor from user code)

n.b. horizontal wheel event uses the same hack we already use for vertical wheel, while we're waiting for a beautiful solution ;)
_______________________________________________________

Man, that was a hassle with all these external projects!!! Maybe I should've left it to the project maintainers to update their code? But then GTTools may have been broken which is now an essential part of the system. What is the best practice here?

Cheers,
Sean

Andrei Chis

Re: [FIX]: Issue 4795: Horizontal wheel

On Fri, Feb 13, 2015 at 5:26 PM, Sean P. DeNigris <[hidden email]> wrote:

Now parent Issue 14915 Horizontal Scrolling Everywhere with Subcases:
4795: Horizontal wheel events
14907: #mouseWheel: knows too much
14909: Update Athens Mouse Wheel
14910: Update TxText Mouse Wheel
14931: Update Glamour for Horizontal ...

New fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.3
_______________________________________________________
This version: remove changes to Glamour-Morphic-Brick

v. 2: remove changes to Tx and Athens, which will be handled as separate
issues.

v. 1
Implement Horizontal Mouse Wheel
- Update scrolling morphs to use it
- Clean up MouseWheelEvent
- Add #isUp etc. testing messages; no more Symbol comparison e.g. "event
direction = #up"
- Add proper instance creation message (we were calling a private
constructor from user code)

n.b. horizontal wheel event uses the same hack we already use for vertical
wheel, while we're waiting for a beautiful solution ;)
_______________________________________________________

Man, that was a hassle with all these external projects!!! Maybe I should've
left it to the project maintainers to update their code? But then GTTools
may have been broken which is now an essential part of the system. What is
the best practice here?

You should commit directly in the GTools repo. Do you have access?

It will then be integrated in the system next time we integrate GTools.

That will probably be next week as we are currently doing some major refactorings.

Cheers,

Andrei

-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/FIX-Issue-4795-Horizontal-wheel-tp4805005p4805573.html

Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

In reply to this post by Sean P. DeNigris

Sean P. DeNigris wrote

New fix in inbox: SLICE-Issue-4795-Horizontal-wheel-SeanDeNigris.3

Okay, the monkey failed me twice, even though I can merge both slices perfectly cleanly. Will someone please manually review this? It touches Morphic so it may go stale quickly. Thanks.

Cheers,
Sean

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

Sean P. DeNigris wrote

Will someone please manually review this? It touches Morphic so it may go stale quickly.

Hello? Bueller? Anyone? Come on, guys. This is horizontal scrolling - people have been asking for this for a long time! And, it's not a very complicated patch...

Cheers,
Sean

Nicolai Hess

Re: [FIX]: Issue 4795: Horizontal wheel

2015-02-15 16:02 GMT+01:00 Sean P. DeNigris <[hidden email]>:

Sean P. DeNigris wrote
> Will someone please manually review this? It touches Morphic so it may go
> stale quickly.

Hello? Bueller? Anyone? Come on, guys. This is horizontal scrolling - people
have been asking for this for a long time! And, it's not a very complicated
patch...

issue 4795 is now integrated. But only now I see a side-effect from this change
On windows:
In a TextEditor, ALT+ArrowLeft/ALT+ArrowRight and CTRL+ArrowLeft/CTRL+ArrowRight
both move the cursor to the prior/next word,

now only ALT+ArrowLeft/Right works.

On the other hand, the keymapping Ctrl/Alt is strange on windows anyway. There are
other shortcuts that are working with both, Ctrl and Alt, and I don't know if this is intended.

-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/FIX-Issue-4795-Horizontal-wheel-tp4805005p4805776.html

Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

stepharo

Re: [FIX]: Issue 4795: Horizontal wheel

In reply to this post by Sean P. DeNigris

Hi Sean

I tried to merge the version v3 and it is empty with the latest Pharo :
#40490

Stef
>> Will someone please manually review this? It touches Morphic so it may go
>> stale quickly.
> Hello? Bueller? Anyone? Come on, guys. This is horizontal scrolling - people
> have been asking for this for a long time! And, it's not a very complicated
> patch...

EstebanLM

Re: [FIX]: Issue 4795: Horizontal wheel

because is probably already there.
I remember integrating it… probably I forget to close it ?

Esteban

> On 16 Feb 2015, at 10:07, stepharo <[hidden email]> wrote:
>
> Hi Sean
>
> I tried to merge the version v3 and it is empty with the latest Pharo : #40490
>
> Stef
>>> Will someone please manually review this? It touches Morphic so it may go
>>> stale quickly.
>> Hello? Bueller? Anyone? Come on, guys. This is horizontal scrolling - people
>> have been asking for this for a long time! And, it's not a very complicated
>> patch...
>
>
>

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

EstebanLM wrote

because is probably already there.

Yes, it is in 40492.

Cheers,
Sean

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

In reply to this post by Nicolai Hess

Nicolai Hess wrote

now only ALT+ArrowLeft/Right works.

Hmm, are you sure it stopped working with this fix? I don't have this feature on Mac in 40489 either. If it did, and it's important, maybe we can have both. Let me know...

Cheers,
Sean

Nicolai Hess

Re: [FIX]: Issue 4795: Horizontal wheel

2015-02-16 15:46 GMT+01:00 Sean P. DeNigris <[hidden email]>:

Nicolai Hess wrote
> now only ALT+ArrowLeft/Right works.

Hmm, are you sure it stopped working with this fix? I don't have this

Yes I am SURE :)
I use this key combination a lot. And I used a lot of the recent image versions.
And it stopped working with 40490.

feature on Mac in 40489 either. If it did, and it's important, maybe we can
have both. Let me know...

Yes, I think this is Windows (and maybe Linux) issue. The

Ctrl/Alt behavior on this platform is strange (sometimes different and sometimes the same).

For example

Ctrl+d -> doIt

Alt+d -> doIt

Ctrl+c-> copy

Alt+c-> copy

Ctlr+a-> select all
Alt+a-> nothing

Ctlr+m-> nothing
Alt+m-> Browse it

-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/FIX-Issue-4795-Horizontal-wheel-tp4805005p4805915.html

Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Sean P. DeNigris

Re: [FIX]: Issue 4795: Horizontal wheel

Administrator

Nicolai Hess wrote

Yes I am SURE :)
I use this key combination a lot. And I used a lot of the recent image
versions.

Okay, since I am on Mac, I'm not sure how to proceed. Please advise if you have any suggestions...

Cheers,
Sean

ccrraaiigg

Re: [FIX]: Issue 4795: Horizontal wheel

In reply to this post by Sean P. DeNigris

> Bueller?

I think the devs here are perhaps *slightly* more busy than the
drooling teenagers in that scene... :)

-C

--
Craig Latta
netjam.org
+31 6 2757 7177 (SMS ok)
+ 1 415 287 3547 (no SMS)