[FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

hernan.wilkinson
Another fix... 
(Do I have to send a mail to the list per fix? the how to contribute page says so but it can be annoying...)

Hernan.

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Nicolas Cellier
Not annoying at all. Please do.

2009/4/29 Hernan Wilkinson <[hidden email]>:
> Another fix...
> (Do I have to send a mail to the list per fix? the how to contribute page
> says so but it can be annoying...)
> Hernan.
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

hernan.wilkinson
ok then, no problem.
BTW, I'd like somebody to look at the fix I made because I'm not sure that is the right way to doit. I mean, it is rare how the exception is related to the dialog box. I think it is done that way because the handler of the notification could not show a dialog... but if that is the idea then I think something is missing to relate the cancel option of the notification with the cancel button of the dialog.

On Wed, Apr 29, 2009 at 12:39 PM, Nicolas Cellier <[hidden email]> wrote:
Not annoying at all. Please do.

2009/4/29 Hernan Wilkinson <[hidden email]>:
> Another fix...
> (Do I have to send a mail to the list per fix? the how to contribute page
> says so but it can be annoying...)
> Hernan.
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Nicolas Cellier
However, I see this is related to OB.
It's not really a package of the core pharo, but rather an external
one included in Damien development images.
Such external package has its own maintainer  and is not maintained by
pharo team.
You should post to the appropriate code repository and mailing list...
(a good soul in this list will have to tell you which one, because I
don't know it)

Cheers

2009/4/29 Hernan Wilkinson <[hidden email]>:

> ok then, no problem.
> BTW, I'd like somebody to look at the fix I made because I'm not sure that
> is the right way to doit. I mean, it is rare how the exception is related to
> the dialog box. I think it is done that way because the handler of the
> notification could not show a dialog... but if that is the idea then I think
> something is missing to relate the cancel option of the notification with
> the cancel button of the dialog.
>
> On Wed, Apr 29, 2009 at 12:39 PM, Nicolas Cellier
> <[hidden email]> wrote:
>>
>> Not annoying at all. Please do.
>>
>> 2009/4/29 Hernan Wilkinson <[hidden email]>:
>> > Another fix...
>> > (Do I have to send a mail to the list per fix? the how to contribute
>> > page
>> > says so but it can be annoying...)
>> > Hernan.
>> > _______________________________________________
>> > Pharo-project mailing list
>> > [hidden email]
>> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>> >
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

hernan.wilkinson
ups... another question then... where is a list of core pharo packages?
I saw there is a pharo-core image and a pharo (or pharo-dev) image. I could not find the pharo-core image, the one in the download page is the pharo-dev image.

Thanks
Hernan.

On Wed, Apr 29, 2009 at 2:22 PM, Nicolas Cellier <[hidden email]> wrote:
However, I see this is related to OB.
It's not really a package of the core pharo, but rather an external
one included in Damien development images.
Such external package has its own maintainer  and is not maintained by
pharo team.
You should post to the appropriate code repository and mailing list...
(a good soul in this list will have to tell you which one, because I
don't know it)

Cheers

2009/4/29 Hernan Wilkinson <[hidden email]>:
> ok then, no problem.
> BTW, I'd like somebody to look at the fix I made because I'm not sure that
> is the right way to doit. I mean, it is rare how the exception is related to
> the dialog box. I think it is done that way because the handler of the
> notification could not show a dialog... but if that is the idea then I think
> something is missing to relate the cancel option of the notification with
> the cancel button of the dialog.
>
> On Wed, Apr 29, 2009 at 12:39 PM, Nicolas Cellier
> <[hidden email]> wrote:
>>
>> Not annoying at all. Please do.
>>
>> 2009/4/29 Hernan Wilkinson <[hidden email]>:
>> > Another fix...
>> > (Do I have to send a mail to the list per fix? the how to contribute
>> > page
>> > says so but it can be annoying...)
>> > Hernan.
>> > _______________________________________________
>> > Pharo-project mailing list
>> > [hidden email]
>> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>> >
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Mariano Martinez Peck


2009/4/29 Hernan Wilkinson <[hidden email]>
ups... another question then... where is a list of core pharo packages?
I saw there is a pharo-core image and a pharo (or pharo-dev) image. I could not find the pharo-core image, the one in the download page is the pharo-dev image.

In pharo webpage where it says "archive and more...". It is a link to this:
http://gforge.inria.fr/frs/?group_id=1299

There are all the images.

saludos

mariano
 

Thanks
Hernan.


On Wed, Apr 29, 2009 at 2:22 PM, Nicolas Cellier <[hidden email]> wrote:
However, I see this is related to OB.
It's not really a package of the core pharo, but rather an external
one included in Damien development images.
Such external package has its own maintainer  and is not maintained by
pharo team.
You should post to the appropriate code repository and mailing list...
(a good soul in this list will have to tell you which one, because I
don't know it)

Cheers

2009/4/29 Hernan Wilkinson <[hidden email]>:
> ok then, no problem.
> BTW, I'd like somebody to look at the fix I made because I'm not sure that
> is the right way to doit. I mean, it is rare how the exception is related to
> the dialog box. I think it is done that way because the handler of the
> notification could not show a dialog... but if that is the idea then I think
> something is missing to relate the cancel option of the notification with
> the cancel button of the dialog.
>
> On Wed, Apr 29, 2009 at 12:39 PM, Nicolas Cellier
> <[hidden email]> wrote:
>>
>> Not annoying at all. Please do.
>>
>> 2009/4/29 Hernan Wilkinson <[hidden email]>:
>> > Another fix...
>> > (Do I have to send a mail to the list per fix? the how to contribute
>> > page
>> > says so but it can be annoying...)
>> > Hernan.
>> > _______________________________________________
>> > Pharo-project mailing list
>> > [hidden email]
>> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>> >
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Adrian Lienhard

On Apr 29, 2009, at 23:48 , Mariano Martinez Peck wrote:

> 2009/4/29 Hernan Wilkinson <[hidden email]>
>
>> ups... another question then... where is a list of core pharo  
>> packages?I
>> saw there is a pharo-core image and a pharo (or pharo-dev) image. I  
>> could
>> not find the pharo-core image, the one in the download page is the  
>> pharo-dev
>> image.
>>
>
> In pharo webpage where it says "archive and more...". It is a link  
> to this:
> http://gforge.inria.fr/frs/?group_id=1299

I updated the web page to make this more clear.

Adrian

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

David Röthlisberger-2
In reply to this post by Nicolas Cellier
Hi,

You can post the bug notification to [hidden email] and/or upload
your patch to http://source.wiresong.ca/ob. Thanks.

Concerning this particular bug:
I don't understand what you mean with 'cancel button'? Where do you get such a
button, what is its behavior compared to the cancel option?

David

> However, I see this is related to OB.
> It's not really a package of the core pharo, but rather an external
> one included in Damien development images.
> Such external package has its own maintainer  and is not maintained by
> pharo team.
> You should post to the appropriate code repository and mailing list...
> (a good soul in this list will have to tell you which one, because I
> don't know it)
>
> Cheers
>
> 2009/4/29 Hernan Wilkinson <[hidden email]>:
>> ok then, no problem.
>> BTW, I'd like somebody to look at the fix I made because I'm not sure that
>> is the right way to doit. I mean, it is rare how the exception is related to
>> the dialog box. I think it is done that way because the handler of the
>> notification could not show a dialog... but if that is the idea then I think
>> something is missing to relate the cancel option of the notification with
>> the cancel button of the dialog.
>>
>> On Wed, Apr 29, 2009 at 12:39 PM, Nicolas Cellier
>> <[hidden email]> wrote:
>>> Not annoying at all. Please do.
>>>
>>> 2009/4/29 Hernan Wilkinson <[hidden email]>:
>>>> Another fix...
>>>> (Do I have to send a mail to the list per fix? the how to contribute
>>>> page
>>>> says so but it can be annoying...)
>>>> Hernan.
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [hidden email]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Stéphane Ducasse
In reply to this post by hernan.wilkinson

On Apr 29, 2009, at 11:40 PM, Hernan Wilkinson wrote:

> ups... another question then... where is a list of core pharo  
> packages?

if you open monticello in core you get the core packages.
There are stored in Pharo on SqueakSource.

> I saw there is a pharo-core image and a pharo (or pharo-dev) image.  
> I could not find the pharo-core image, the one in the download page  
> is the pharo-dev image.
>
> Thanks
> Hernan.
>
> On Wed, Apr 29, 2009 at 2:22 PM, Nicolas Cellier <[hidden email]
> > wrote:
> However, I see this is related to OB.
> It's not really a package of the core pharo, but rather an external
> one included in Damien development images.
> Such external package has its own maintainer  and is not maintained by
> pharo team.
> You should post to the appropriate code repository and mailing list...
> (a good soul in this list will have to tell you which one, because I
> don't know it)
>
> Cheers
>
> 2009/4/29 Hernan Wilkinson <[hidden email]>:
> > ok then, no problem.
> > BTW, I'd like somebody to look at the fix I made because I'm not  
> sure that
> > is the right way to doit. I mean, it is rare how the exception is  
> related to
> > the dialog box. I think it is done that way because the handler of  
> the
> > notification could not show a dialog... but if that is the idea  
> then I think
> > something is missing to relate the cancel option of the  
> notification with
> > the cancel button of the dialog.
> >
> > On Wed, Apr 29, 2009 at 12:39 PM, Nicolas Cellier
> > <[hidden email]> wrote:
> >>
> >> Not annoying at all. Please do.
> >>
> >> 2009/4/29 Hernan Wilkinson <[hidden email]>:
> >> > Another fix...
> >> > (Do I have to send a mail to the list per fix? the how to  
> contribute
> >> > page
> >> > says so but it can be annoying...)
> >> > Hernan.
> >> > _______________________________________________
> >> > Pharo-project mailing list
> >> > [hidden email]
> >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
> >> >
> >>
> >> _______________________________________________
> >> Pharo-project mailing list
> >> [hidden email]
> >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
> >
> >
> > _______________________________________________
> > Pharo-project mailing list
> > [hidden email]
> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
> >
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Simon Denier-3
In reply to this post by David Röthlisberger-2

On 30 avr. 09, at 09:53, David Röthlisberger wrote:

> Hi,
>
> You can post the bug notification to omnibrowser-
> [hidden email] and/or upload
> your patch to http://source.wiresong.ca/ob. Thanks.

Good to know there is such a group. Registered.

>
> Concerning this particular bug:
> I don't understand what you mean with 'cancel button'? Where do you  
> get such a
> button, what is its behavior compared to the cancel option?

I do get the button, which I think is quite standard for such pop up.  
It is the one next to the search field. Indeed, the cancel option  
cancels the user exit and come back to the edit panel with unsaved  
changes, while the cancel button works like the discard option,  
discarding the unsaved changes.


BTW, any hint about how to introduce return line in pop up title? :)

>
>
> David
>
>> However, I see this is related to OB.
>> It's not really a package of the core pharo, but rather an external
>> one included in Damien development images.
>> Such external package has its own maintainer  and is not maintained  
>> by
>> pharo team.
>> You should post to the appropriate code repository and mailing  
>> list...
>> (a good soul in this list will have to tell you which one, because I
>> don't know it)
>>
>> Cheers
>>
>> 2009/4/29 Hernan Wilkinson <[hidden email]>:
>>> ok then, no problem.
>>> BTW, I'd like somebody to look at the fix I made because I'm not  
>>> sure that
>>> is the right way to doit. I mean, it is rare how the exception is  
>>> related to
>>> the dialog box. I think it is done that way because the handler of  
>>> the
>>> notification could not show a dialog... but if that is the idea  
>>> then I think
>>> something is missing to relate the cancel option of the  
>>> notification with
>>> the cancel button of the dialog.
>>>
>>> On Wed, Apr 29, 2009 at 12:39 PM, Nicolas Cellier
>>> <[hidden email]> wrote:
>>>> Not annoying at all. Please do.
>>>>
>>>> 2009/4/29 Hernan Wilkinson <[hidden email]>:
>>>>> Another fix...
>>>>> (Do I have to send a mail to the list per fix? the how to  
>>>>> contribute
>>>>> page
>>>>> says so but it can be annoying...)
>>>>> Hernan.
>>>>> _______________________________________________
>>>>> Pharo-project mailing list
>>>>> [hidden email]
>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- 
>>>>> project
>>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [hidden email]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

--
  Simon




_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Damien Cassou
In reply to this post by Adrian Lienhard
On Thu, Apr 30, 2009 at 8:53 AM, Adrian Lienhard <[hidden email]> wrote:
>> In pharo webpage where it says "archive and more...". It is a link
>> to this:
>> http://gforge.inria.fr/frs/?group_id=1299
>
> I updated the web page to make this more clear.

I've changed it again a little:
- re-add the "archive and more..." link because it can still be useful
to people wanting older versions of Pharo
- add a new paragraph in Pharo-Core which says that "you probably
don't want this" :-)

--
Damien Cassou
http://damiencassou.seasidehosting.st

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

Stéphane Ducasse
In reply to this post by Simon Denier-3
>
>
>
> BTW, any hint about how to introduce return line in pop up title? :)

'hjkhkjh / lkjlkjkj  ' withCrs



_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project