Hi Lukas/Romain. While building a PharoDev, I noticed that ECUntypedModelTest >> testNarrowWith is failing.
The problem is in: self assert: count > 100. as "count", which is equal to "model entries size", is 98. Of course, if I change it to self assert: count > 90. for example, it works prefect. I have no idea about this. What do you think ? Cheers Mariano _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
It is stupid to have tests that depend on what else is loaded in the image.
OB and RB (for some parts) use a fake image with fake classes and methods in which they run their test. Lukas 2010/2/14 Mariano Martinez Peck <[hidden email]>: > Hi Lukas/Romain. While building a PharoDev, I noticed that > ECUntypedModelTest >> testNarrowWith is failing. > > The problem is in: > > self assert: count > 100. > > as "count", which is equal to "model entries size", is 98. > > Of course, if I change it to > > self assert: count > 90. > > for example, it works prefect. > > I have no idea about this. What do you think ? > > Cheers > > Mariano > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
yes, this test should either be deleted or rewritten. When I'm back
from holidays I'll look into it. Romain On Monday, February 15, 2010, Lukas Renggli <[hidden email]> wrote: > It is stupid to have tests that depend on what else is loaded in the image. > > OB and RB (for some parts) use a fake image with fake classes and > methods in which they run their test. > > Lukas > > 2010/2/14 Mariano Martinez Peck <[hidden email]>: >> Hi Lukas/Romain. While building a PharoDev, I noticed that >> ECUntypedModelTest >> testNarrowWith is failing. >> >> The problem is in: >> >> self assert: count > 100. >> >> as "count", which is equal to "model entries size", is 98. >> >> Of course, if I change it to >> >> self assert: count > 90. >> >> for example, it works prefect. >> >> I have no idea about this. What do you think ? >> >> Cheers >> >> Mariano >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
On Mon, Feb 15, 2010 at 1:34 PM, Romain Robbes <[hidden email]> wrote: yes, this test should either be deleted or rewritten. When I'm back Ok. Don't worry. If your fix comes before I build next pharo dev, I integrate it, otherwise, I will remove it for a while and then if you do it we put it again. ok ? cheers mariano Romain _______________________________________________ Pharo-project mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project |
Free forum by Nabble | Edit this page |