Smalltalk › Frameworks & Tools › SciSmalltalk

Failing Tests In PMPrincipalComponentAnalyserTest

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

hemalvarambhia

Failing Tests In PMPrincipalComponentAnalyserTest

I issued a PR against develop with a fix for testMatrixSign. It seems the assert message was mistakenly being sent to a PMMatrix object:

https://github.com/PolyMathOrg/PolyMath/pull/83

Along the way, I found that two tests are failing (see below):


PMPrincipalComponentAnalyserTest
f6e3a6_ca08 ✗ #testTransformMatrixWithJacobiTransformation (13ms)
TestFailure: Got a PMVector(0.8384922379048739 -0.5449135408239332)
a PMVector(0.5449135408239332 0.8384922379048739) instead of a PMVector(-0.83849224 -0.54491354)
a PMVector(0.54491354 -0.83849224).
PMPrincipalComponentAnalyserTest(TestAsserter)>>assert:description:
PMPrincipalComponentAnalyserTest(TestAsserter)>>assert:closeTo:
PMPrincipalComponentAnalyserTest>>testTransformMatrixWithJacobiTransformation ...assert: pca transformMatrix closeTo: (PMMatrix rows: #(#(-0.83849224 -0.54491354) #(0.54491354 -0.83849224)))
PMPrincipalComponentAnalyserTest(TestCase)>>performTest
1f3e74_ca08 ✗ #testTransformMatrixWithSVD (6ms)

Is anyone currently looking into this? If not, I'd be happy to volunteer.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

hemalvarambhia

Re: Failing Tests In PMPrincipalComponentAnalyserTest

Apologies, it looks like there already is an issue for the above:

https://github.com/PolyMathOrg/PolyMath/issues/81

Hemal
On Sunday, November 4, 2018 at 5:35:24 PM UTC, Hemal Varambhia wrote:

I issued a PR against develop with a fix for testMatrixSign. It seems the assert message was mistakenly being sent to a PMMatrix object:

<a href="https://github.com/PolyMathOrg/PolyMath/pull/83" target="_blank" rel="nofollow" onmousedown="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F83\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZYm2g8DtujEAa4Sc7nw_I3HyppQ';return true;" onclick="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fpull%2F83\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZYm2g8DtujEAa4Sc7nw_I3HyppQ';return true;">https://github.com/PolyMathOrg/PolyMath/pull/83

Along the way, I found that two tests are failing (see below):
PMPrincipalComponentAnalyserTest
f6e3a6_ca08 ✗ #testTransformMatrixWithJacobiTransformation (13ms)
TestFailure: Got a PMVector(0.8384922379048739 -0.5449135408239332)
a PMVector(0.5449135408239332 0.8384922379048739) instead of a PMVector(-0.83849224 -0.54491354)
a PMVector(0.54491354 -0.83849224).
PMPrincipalComponentAnalyserTest(TestAsserter)>>assert:description:
PMPrincipalComponentAnalyserTest(TestAsserter)>>assert:closeTo:
PMPrincipalComponentAnalyserTest>>testTransformMatrixWithJacobiTransformation ...assert: pca transformMatrix closeTo: (PMMatrix rows: #(#(-0.83849224 -0.54491354) #(0.54491354 -0.83849224)))
PMPrincipalComponentAnalyserTest(TestCase)>>performTest
1f3e74_ca08 ✗ #testTransformMatrixWithSVD (6ms)
Is anyone currently looking into this? If not, I'd be happy to volunteer.