Smalltalk › Pharo › Pharo Smalltalk Developers

FastTableModel switched from default single-select to multi

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Stephan Eggermont-3

FastTableModel switched from default single-select to multi

Breaking all code that expects selectedItem to be not-nil.
Is that wanted behaviour? I noticed it broke SpecGenerator.
I have no strong opinion on this, and welcome all Spec progress.

Stephan

Andrei Chis

Re: FastTableModel switched from default single-select to multi

Is this in the Glamour model or in the Spec one?

If it's the glamour one I made some changes to the Glamour one but I don't remember changing the default to multiple selection. Maybe it's a bug :)

Cheers,

Andrei

On Mon, Feb 13, 2017 at 12:38 AM, Stephan Eggermont <[hidden email]> wrote:
> Breaking all code that expects selectedItem to be not-nil.
> Is that wanted behaviour? I noticed it broke SpecGenerator.
> I have no strong opinion on this, and welcome all Spec progress.
>
> Stephan
>
>

Stephan Eggermont-3

Re: FastTableModel switched from default single-select to multi

On 13/02/17 12:52, Andrei Chis wrote:
> Is this in the Glamour model or in the Spec one?

In the Spec one, so I might be a bit late in noticing.

Stephan

tinchodias

Re: FastTableModel switched from default single-select to multi

Hi,

I can't reproduce in #60394. In fact I *want* multiple selection and only get single selection:

FastTableModel new beMultipleSelection; items: (1 to: 10) asArray; openWithSpec.

Martin

On Mon, Feb 13, 2017 at 9:03 PM, Stephan Eggermont <[hidden email]> wrote:

On 13/02/17 12:52, Andrei Chis wrote:

Is this in the Glamour model or in the Spec one?

In the Spec one, so I might be a bit late in noticing.

Stephan

tinchodias

Re: FastTableModel switched from default single-select to multi

Reported as https://pharo.fogbugz.com/f/cases/19715/FastTableModel-Can-t-enable-multiple-selection

I checked that multiple selection works with ListModel (the superclass of FastTableModel).

Martin

On Wed, Feb 15, 2017 at 1:56 PM, Martin Dias <[hidden email]> wrote:

Hi,

I can't reproduce in #60394. In fact I *want* multiple selection and only get single selection:

FastTableModel new beMultipleSelection; items: (1 to: 10) asArray; openWithSpec.

Martin

On Mon, Feb 13, 2017 at 9:03 PM, Stephan Eggermont <[hidden email]> wrote:
On 13/02/17 12:52, Andrei Chis wrote:

Is this in the Glamour model or in the Spec one?

In the Spec one, so I might be a bit late in noticing.

Stephan

tinchodias

Re: FastTableModel switched from default single-select to multi

I set the case to "Milestone Later"... I reproduced the bug in Pharo 5

On Wed, Feb 15, 2017 at 2:01 PM, Martin Dias <[hidden email]> wrote:

Reported as https://pharo.fogbugz.com/f/cases/19715/FastTableModel-Can-t-enable-multiple-selection

I checked that multiple selection works with ListModel (the superclass of FastTableModel).

Martin

On Wed, Feb 15, 2017 at 1:56 PM, Martin Dias <[hidden email]> wrote:
Hi,

I can't reproduce in #60394. In fact I *want* multiple selection and only get single selection:

FastTableModel new beMultipleSelection; items: (1 to: 10) asArray; openWithSpec.

Martin

On Mon, Feb 13, 2017 at 9:03 PM, Stephan Eggermont <[hidden email]> wrote:
On 13/02/17 12:52, Andrei Chis wrote:

Is this in the Glamour model or in the Spec one?

In the Spec one, so I might be a bit late in noticing.

Stephan

Stephan Eggermont-3

Re: FastTableModel switched from default single-select to multi

On 16/02/17 20:37, Martin Dias wrote:
> I set the case to "Milestone Later"... I reproduced the bug in Pharo 5

It is somewhat more complex. I have the problem with doubleClick,
but not if only adding a doubleClick handler. In SpecGenerator
I set some more properties.

Stephan