Feedback request: Editor with highlighting message-sends on mouse over

Hi Nicolai

Good idea!

I like it and it works well.

I now wonder if it should not be enabled as default. For that, maybe the highlight should be styled a bit (e.g. lighter colors) to do not perturb the user when not really needed but still easy to see. Another idea would be to show it only if you press a key while mouse over (e.g shift).

thanks

Le 10 août 2016 à 16:48, Nicolai Hess <[hidden email]> a écrit :

I opened an issue

18901 Highlight message send selector on mouse over

with an experimental implementation.

Just load the slice, enable the setting:
RubAbstractTextArea highlightMessageSend: true.

Now open a code editor (nautilus/MessageBrowser) and

move the mouse over a message send.

Or evaluate this code, it opens a text editor on  a method, where it is difficult

to see which part of the code belongs to which method:

evaluate:
TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) sourceCode;openWithSpec.

feedback welcome.

nicolai

Good idea!

I like it and it works well.

I now wonder if it should not be enabled as default. For that, maybe the highlight should be styled a bit (e.g. lighter colors) to do not perturb the user when not really needed but still easy to see. Another idea would be to show it only if you press a key while mouse over (e.g shift).

I opened an issue

18901 Highlight message send selector on mouse over

with an experimental implementation.

Just load the slice, enable the setting:
RubAbstractTextArea highlightMessageSend: true.

Now open a code editor (nautilus/MessageBrowser) and

move the mouse over a message send.

Or evaluate this code, it opens a text editor on  a method, where it is difficult

to see which part of the code belongs to which method:

evaluate:
TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) sourceCode;openWithSpec.

feedback welcome.

nicolai

2016-08-11 13:57 GMT+02:00 Christophe Demarey <[hidden email]>:

Good idea!

I like it and it works well.

I now wonder if it should not be enabled as default. For that, maybe the highlight should be styled a bit (e.g. lighter colors) to do not perturb the user when not really needed but still easy to see. Another idea would be to show it only if you press a key while mouse over (e.g shift).

I remember another nice idea to underline keyword messages with different colors. 

2016-08-11 21:23 GMT+02:00 Denis Kudriashov <[hidden email]>:

2016-08-11 13:57 GMT+02:00 Christophe Demarey <[hidden email]>:

Good idea!

I like it and it works well.

I now wonder if it should not be enabled as default. For that, maybe the highlight should be styled a bit (e.g. lighter colors) to do not perturb the user when not really needed but still easy to see. Another idea would be to show it only if you press a key while mouse over (e.g shift).

I remember another nice idea to underline keyword messages with different colors. 

Another idea, instead of highlighting the whole message with arguments, only underline the keywords. This is nice too, but the code to do so (using rubrics text segements) is much more complex, because

I had to use multiple text segments (one per keyword part).

Doing the underline for all keyword message is easier with using ordinary text style attributes. And let the syntax highligher set the proper attributes.

I already did this once, but not for underlining the keywords but for emphase variable assignments.

This is the changed styler to underline assignments. This makes it easer to spot places in long methods, where variables are changed.

(on the other hand, of course, methods shouldn't be that big :) )

2016-08-11 22:19 GMT+02:00 Nicolai Hess <[hidden email]>:

This is the changed styler to underline assignments. This makes it easer to spot places in long methods, where variables are changed.

(on the other hand, of course, methods shouldn't be that big :) )

Let's integrate it. It looks so good

Hi nicolai

It is nice. I would not put the border in black.

What is needed to integrate it.

Stef

Le 10/8/16 à 16:48, Nicolai Hess a écrit :

I opened an issue

18901 Highlight message send selector on mouse over

with an experimental implementation.

Just load the slice, enable the setting:
RubAbstractTextArea highlightMessageSend: true.

Now open a code editor (nautilus/MessageBrowser) and

move the mouse over a message send.

Or evaluate this code, it opens a text editor on  a method, where it is difficult

to see which part of the code belongs to which method:

evaluate:
TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) sourceCode;openWithSpec.

feedback welcome.

nicolai

I like the idea to use shift to activate it.

Le 12/8/16 à 19:19, Nicolai Hess a écrit :

2016-08-12 19:09 GMT+02:00 stepharo <[hidden email]>:

Hi nicolai

It is nice. I would not put the border in black.

What is needed to integrate it.

I put the issue to "Resolved ", so the monkey can check.

The background color is the same as for "secondary selection" and the border color is the same "muchDarker".

Of course, we can integrate it and change the color later.

 

Stef

Le 10/8/16 à 16:48, Nicolai Hess a écrit :

I opened an issue

18901 Highlight message send selector on mouse over

with an experimental implementation.

Just load the slice, enable the setting:
RubAbstractTextArea highlightMessageSend: true.

Now open a code editor (nautilus/MessageBrowser) and

move the mouse over a message send.

Or evaluate this code, it opens a text editor on  a method, where it is difficult

to see which part of the code belongs to which method:

evaluate:
TextModel new beForCode; aboutToStyle:true;behavior: MorphTreeMorph;text:(MorphTreeMorph>>#drawLinesOn:) sourceCode;openWithSpec.

feedback welcome.

nicolai