Smalltalk › Pharo › Pharo Smalltalk Developers

Finder depends on MethodFinder ?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

Mariano Martinez Peck

Finder depends on MethodFinder ?

Hi Ben. I was going to remove MethodFinder since I thought it was not used any more...but I noticed that Finder depends on it, for example in #computeWithMethodFinder:
so...is this correct or we should fix it ?

Thanks

--
Mariano
http://marianopeck.wordpress.com

Henrik Sperre Johansen

Re: Finder depends on MethodFinder ?

On 15.04.2011 10:55, Mariano Martinez Peck wrote:
> Hi Ben. I was going to remove MethodFinder since I thought it was not
> used any more...but I noticed that Finder depends on it, for example
> in #computeWithMethodFinder:
> so...is this correct or we should fix it ?
>
> Thanks
>
> --
> Mariano

The GUI (SelectorBrowser) is gone.
The functionality (MethodFinder) is not.

Could/Should probably be moved to Finder-Core though.

Cheers,
Henry

Mariano Martinez Peck

Re: Finder depends on MethodFinder ?

On Fri, Apr 15, 2011 at 11:16 AM, Henrik Sperre Johansen <[hidden email]> wrote:

On 15.04.2011 10:55, Mariano Martinez Peck wrote:

Hi Ben. I was going to remove MethodFinder since I thought it was not used any more...but I noticed that Finder depends on it, for example in #computeWithMethodFinder:
so...is this correct or we should fix it ?

Thanks

--
Mariano

The GUI (SelectorBrowser) is gone.
The functionality (MethodFinder) is not.

Yes I know. and this is what I was going to do today, remove MethodFinder since I thought is was only used in the old UI, not Finder.

Could/Should probably be moved to Finder-Core though.

I have ni idea how much Finder uses MethodFinder...maybe it is just a couple of methods. I don't know.

Cheers

Mariano

Cheers,
Henry

--
Mariano
http://marianopeck.wordpress.com

Henrik Sperre Johansen

Re: Finder depends on MethodFinder ?

On 15.04.2011 11:23, Mariano Martinez Peck wrote:

On Fri, Apr 15, 2011 at 11:16 AM, Henrik Sperre Johansen <[hidden email]> wrote:

On 15.04.2011 10:55, Mariano Martinez Peck wrote:

Hi Ben. I was going to remove MethodFinder since I thought it was not used any more...but I noticed that Finder depends on it, for example in #computeWithMethodFinder:
so...is this correct or we should fix it ?

Thanks

--
Mariano

The GUI (SelectorBrowser) is gone.
The functionality (MethodFinder) is not.

Yes I know. and this is what I was going to do today, remove MethodFinder since I thought is was only used in the old UI, not Finder.

Could/Should probably be moved to Finder-Core though.

I have ni idea how much Finder uses MethodFinder...maybe it is just a couple of methods. I don't know.

Cheers

Mariano

ClassBrowser -> Select MethodFinder -> Right click -> Class refs ;)

Cheers,
Henry

Stéphane Ducasse

Re: Finder depends on MethodFinder ?

In reply to this post by Henrik Sperre Johansen

>>
>
> The GUI (SelectorBrowser) is gone.
> The functionality (MethodFinder) is not.
>
> Could/Should probably be moved to Finder-Core though.

yes it would be good.

stef

Mariano Martinez Peck

Re: Finder depends on MethodFinder ?

Done: http://code.google.com/p/pharo/issues/detail?id=4025

On Fri, Apr 15, 2011 at 11:47 AM, Stéphane Ducasse <[hidden email]> wrote:

>>
>
> The GUI (SelectorBrowser) is gone.
> The functionality (MethodFinder) is not.
>
> Could/Should probably be moved to Finder-Core though.

yes it would be good.

stef

--
Mariano
http://marianopeck.wordpress.com

Benjamin Van Ryseghem (Pharo)

Re: Finder depends on MethodFinder ?

In reply to this post by Mariano Martinez Peck

Finder depends on MethodFinder because instead of re-implementeing the behavior, I have "stole" it.

Maybe we should re-implement it, but the is a total mess ...

Ben

On Apr 15, 2011, at 10:55 AM, Mariano Martinez Peck wrote:

Hi Ben. I was going to remove MethodFinder since I thought it was not used any more...but I noticed that Finder depends on it, for example in #computeWithMethodFinder:
so...is this correct or we should fix it ?

Thanks

--
Mariano
http://marianopeck.wordpress.com

Stéphane Ducasse

Re: Finder depends on MethodFinder ?

good enough for now.

Stef

On Apr 15, 2011, at 1:43 PM, Benjamin wrote:

> Finder depends on MethodFinder because instead of re-implementeing the behavior, I have "stole" it.
> Maybe we should re-implement it, but the is a total mess ...
>
> Ben
>
> On Apr 15, 2011, at 10:55 AM, Mariano Martinez Peck wrote:
>
>> Hi Ben. I was going to remove MethodFinder since I thought it was not used any more...but I noticed that Finder depends on it, for example in #computeWithMethodFinder:
>> so...is this correct or we should fix it ?
>>
>> Thanks
>>
>> --
>> Mariano
>> http://marianopeck.wordpress.com
>>
>