Smalltalk › Pharo › Pharo Smalltalk Developers

First commit

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Evan Donahue

First commit

Hello,

I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue

https://pharo.fogbugz.com/f/cases/17848

because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works.

I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save, I did not see any confirmation. How can I tell if my slice was submitted or not?

Thank you,

Evan

Juraj Kubelka

Re: First commit

Hi,

Juraj Kubelka

El 30-04-2017, a las 15:25, Evan Donahue <[hidden email]> escribió:

Hello,

I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue

https://pharo.fogbugz.com/f/cases/17848

because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works.

I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save, I did not see any confirmation. How can I tell if my slice was submitted or not?

I am not in front of my computer, but you can open the repository and search for the SLICE.

Than you should set resolve in FogBugz.

Juraj

Thank you,
Evan

Stephane Ducasse-3

Re: First commit

In reply to this post by Evan Donahue

if you open Pharo60Inbox you should be able to see it.

On Sun, Apr 30, 2017 at 8:25 PM, Evan Donahue <[hidden email]> wrote:

Hello,

I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue

https://pharo.fogbugz.com/f/cases/17848

because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works.

I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save, I did not see any confirmation. How can I tell if my slice was submitted or not?

Thank you,
Evan

Ben Coman

Re: First commit

In reply to this post by Evan Donahue

On Mon, May 1, 2017 at 2:25 AM, Evan Donahue <[hidden email]> wrote:

Hello,

I have just tried to submit my first patch to the main Pharo inbox. I submitted a patch for issue

https://pharo.fogbugz.com/f/cases/17848

because it basically amounted to changing an error message and seemed like a good place to start figuring out how the submission process works.

I saved my slice to the Pharo60Inbox, but when I typed my commit message and hit save,

I presume you mean, after you typed your commit message, you hit <Accept>.

I did not see any confirmation. How can I tell if my slice was submitted or not?

It seems like it did not save. I opened Pharo60Inbox and filtering on 17848 shows nothing.

You should have got up a window titled something like "Version: SLICE-Issue-NNNN-Blah-blah-blah-BenComan.1

Can you see it in your package cache? If its there, you can select it and choose <Copy> to copy it to Pharo60Inbox (but <Copy> requires you to have added your password to the Pharo60Inbox repo defintion).

cheers -ben

Evan Donahue

Re: First commit

Thanks. I have resubmitted and it seems to have worked. If anyone wants to let me know if it looks like I did everything right, I can hopefully move on to tackling other things.

Thanks,
Evan

Stephane Ducasse-3

Re: First commit

Tx evan!

We will have a look and this is great to have a new contributor!!!

Stef

On Tue, May 2, 2017 at 3:23 AM, Evan Donahue <[hidden email]> wrote:

Thanks. I have resubmitted and it seems to have worked. If anyone wants to
let me know if it looks like I did everything right, I can hopefully move on
to tackling other things.

Thanks,
Evan

--
View this message in context: http://forum.world.st/First-commit-tp4944984p4945091.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.