Smalltalk › Squeak › Squeak VM

Fix for UUID library crashes

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

David T. Lewis

Fix for UUID library crashes

Ian, Eliot:

The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
for the UUID library crash bug, provided by Levente Uzoni. While I
cannot confirm that it prevents crashes (since I have never encountered
one myself), I can confirm that it builds and runs and that the
proposed solution looks entirely plausible.

Actually, it's way more that just plausible: This one gets my vote
for Best Creative Hack Of The Year. Thank you Levente!

The bug report including Levente's patch is at:
http://bugs.squeak.org/view.php?id=7358

Dave

sqUnixUUID.c (1K) Download Attachment

Nicolas Cellier

Re: Fix for UUID library crashes

If you call this a hack, then take a look at the official libuuid fix.

Sure, I don't even know what an hypervisor is, so i'm not qualified to
comment, but just check
http://xenbits.xensource.com/xen-unstable.hg?rev/81aa410fa662 (via
https://bugzilla.redhat.com/show_bug.cgi?id=471801 )
It's frightening !

Nicolas

2011/2/16 David T. Lewis <[hidden email]>:

>
> Ian, Eliot:
>
> The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
> for the UUID library crash bug, provided by Levente Uzoni. While I
> cannot confirm that it prevents crashes (since I have never encountered
> one myself), I can confirm that it builds and runs and that the
> proposed solution looks entirely plausible.
>
> Actually, it's way more that just plausible: This one gets my vote
> for Best Creative Hack Of The Year. Thank you Levente!
>
> The bug report including Levente's patch is at:
> http://bugs.squeak.org/view.php?id=7358
>
> Dave
>
>
>

David T. Lewis

Re: Fix for UUID library crashes

Well that's pretty scary indeed, but just to be clear: I meant
the term "hack" in the best possible sense of the word. This is
a simple, creative, and pragmatic solution to an issue that has
caused a lot of real problems for many people over at least two
years.

I have personally been frustrated by having to explain the "why
did my VM crash" question over and over without being able to
provide a real solution. So it put a big smile on my face when
I saw the Mantis issue update notification in my inbox, with a
simple, working solution the the problem.

Also, I have been getting discouraged from reading long debates
on mailing lists concerning "fixing" things that are not broken.
So it is really good to see someone putting energy into fixing
something that actually *is* broken :))

Dave

On Wed, Feb 16, 2011 at 02:33:30AM +0100, Nicolas Cellier wrote:

>
> If you call this a hack, then take a look at the official libuuid fix.
>
> Sure, I don't even know what an hypervisor is, so i'm not qualified to
> comment, but just check
> http://xenbits.xensource.com/xen-unstable.hg?rev/81aa410fa662 (via
> https://bugzilla.redhat.com/show_bug.cgi?id=471801 )
> It's frightening !
>
> Nicolas
>
> 2011/2/16 David T. Lewis <[hidden email]>:
> >
> > Ian, Eliot:
> >
> > The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
> > for the UUID library crash bug, provided by Levente Uzoni. While I
> > cannot confirm that it prevents crashes (since I have never encountered
> > one myself), I can confirm that it builds and runs and that the
> > proposed solution looks entirely plausible.
> >
> > Actually, it's way more that just plausible: This one gets my vote
> > for Best Creative Hack Of The Year. Thank you Levente!
> >
> > The bug report including Levente's patch is at:
> > ?http://bugs.squeak.org/view.php?id=7358
> >
> > Dave
> >
> >
> >

Andreas.Raab

Re: Fix for UUID library crashes

On 2/15/2011 6:30 PM, David T. Lewis wrote:

> Well that's pretty scary indeed, but just to be clear: I meant
> the term "hack" in the best possible sense of the word. This is
> a simple, creative, and pragmatic solution to an issue that has
> caused a lot of real problems for many people over at least two
> years.
>
> I have personally been frustrated by having to explain the "why
> did my VM crash" question over and over without being able to
> provide a real solution. So it put a big smile on my face when
> I saw the Mantis issue update notification in my inbox, with a
> simple, working solution the the problem.

Yes, indeed. I'm all for pushing it.

> Also, I have been getting discouraged from reading long debates
> on mailing lists concerning "fixing" things that are not broken.
> So it is really good to see someone putting energy into fixing
> something that actually *is* broken :))

I have a simpler solution: I don't read those lists :-)

Cheers,
- Andreas

> Dave
>
> On Wed, Feb 16, 2011 at 02:33:30AM +0100, Nicolas Cellier wrote:
>> If you call this a hack, then take a look at the official libuuid fix.
>>
>> Sure, I don't even know what an hypervisor is, so i'm not qualified to
>> comment, but just check
>> http://xenbits.xensource.com/xen-unstable.hg?rev/81aa410fa662 (via
>> https://bugzilla.redhat.com/show_bug.cgi?id=471801 )
>> It's frightening !
>>
>> Nicolas
>>
>> 2011/2/16 David T. Lewis<[hidden email]>:
>>> Ian, Eliot:
>>>
>>> The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
>>> for the UUID library crash bug, provided by Levente Uzoni. While I
>>> cannot confirm that it prevents crashes (since I have never encountered
>>> one myself), I can confirm that it builds and runs and that the
>>> proposed solution looks entirely plausible.
>>>
>>> Actually, it's way more that just plausible: This one gets my vote
>>> for Best Creative Hack Of The Year. Thank you Levente!
>>>
>>> The bug report including Levente's patch is at:
>>> ?http://bugs.squeak.org/view.php?id=7358
>>>
>>> Dave
>>>
>>>
>>>

Eliot Miranda-2

Re: Fix for UUID library crashes

In reply to this post by David T. Lewis

On Tue, Feb 15, 2011 at 5:24 PM, David T. Lewis <[hidden email]> wrote:

Ian, Eliot:

The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
for the UUID library crash bug, provided by Levente Uzoni.

chomp. Thanks Levente; this makes perfect sense. It'll be included in the next OSCog build.

While I
cannot confirm that it prevents crashes (since I have never encountered
one myself), I can confirm that it builds and runs and that the
proposed solution looks entirely plausible.

Actually, it's way more that just plausible: This one gets my vote
for Best Creative Hack Of The Year. Thank you Levente!

The bug report including Levente's patch is at:
http://bugs.squeak.org/view.php?id=7358

Dave

Bert Freudenberg

Re: Fix for UUID library crashes

In reply to this post by David T. Lewis

On 16.02.2011, at 02:24, David T. Lewis wrote:

> Ian, Eliot:
>
> The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
> for the UUID library crash bug, provided by Levente Uzoni. While I
> cannot confirm that it prevents crashes (since I have never encountered
> one myself), I can confirm that it builds and runs and that the
> proposed solution looks entirely plausible.
>
> Actually, it's way more that just plausible: This one gets my vote
> for Best Creative Hack Of The Year. Thank you Levente!
>
> The bug report including Levente's patch is at:
> http://bugs.squeak.org/view.php?id=7358
>
> Dave
>
> <sqUnixUUID.c>

Awesome! Levente, you are indeed a Hacker :)

http://www.catb.org/jargon/html/H/hacker.html

- Bert -

Levente Uzonyi-2

Re: Fix for UUID library crashes

In reply to this post by David T. Lewis

On Tue, 15 Feb 2011, David T. Lewis wrote:

Thanks Dave, I hope it will "fix" this issue once and for all.

Levente

>
> The bug report including Levente's patch is at:
> http://bugs.squeak.org/view.php?id=7358
>
> Dave
>
>

Levente Uzonyi-2

Re: Fix for UUID library crashes

In reply to this post by Eliot Miranda-2

On Tue, 15 Feb 2011, Eliot Miranda wrote:

> On Tue, Feb 15, 2011 at 5:24 PM, David T. Lewis <[hidden email]> wrote:
>
>>
>> Ian, Eliot:
>>
>> The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
>> for the UUID library crash bug, provided by Levente Uzoni.
>
>
> chomp. Thanks Levente; this makes perfect sense. It'll be included in the
> next OSCog build.

Thanks. Before you add it, take a look at Ian's changes, which make the
code more readable and I guess follow the style of the VM sources better
than my version. And the signal handler function should have been declared
as static:
http://squeakvm.org/cgi-bin/viewcvs.cgi/trunk/platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c?rev=2362&view=auto

Levente

>
>
>> While I
>> cannot confirm that it prevents crashes (since I have never encountered
>> one myself), I can confirm that it builds and runs and that the
>> proposed solution looks entirely plausible.
>>
>> Actually, it's way more that just plausible: This one gets my vote
>> for Best Creative Hack Of The Year. Thank you Levente!
>>
>> The bug report including Levente's patch is at:
>> http://bugs.squeak.org/view.php?id=7358
>>
>> Dave
>>
>>
>>
>

Levente Uzonyi-2

Re: Fix for UUID library crashes

In reply to this post by Bert Freudenberg

On Wed, 16 Feb 2011, Bert Freudenberg wrote:

>
>
> On 16.02.2011, at 02:24, David T. Lewis wrote:
>
>> Ian, Eliot:
>>
>> The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
>> for the UUID library crash bug, provided by Levente Uzoni. While I
>> cannot confirm that it prevents crashes (since I have never encountered
>> one myself), I can confirm that it builds and runs and that the
>> proposed solution looks entirely plausible.
>>
>> Actually, it's way more that just plausible: This one gets my vote
>> for Best Creative Hack Of The Year. Thank you Levente!
>>
>> The bug report including Levente's patch is at:
>> http://bugs.squeak.org/view.php?id=7358
>>
>> Dave
>>
>> <sqUnixUUID.c>
>
>
> Awesome! Levente, you are indeed a Hacker :)
>
> http://www.catb.org/jargon/html/H/hacker.html

Thanks Bert. :)

Levente

>
> - Bert -
>
>