Fix for extend

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix for extend

Mathieu Suen-2
Hi Paolo,

I have made a fix for the issue: http://smalltalk.gnu.org/project/issue/520.
You can take it from my repository.
I am not fan of the fix but at least it work.


        Mth




__________________________________________________
Do You Yahoo!?
En finir avec le spam? Yahoo! Mail vous offre la meilleure protection possible contre les messages non sollicités
http://mail.yahoo.fr Yahoo! Mail

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Fix for extend

Paolo Bonzini-2
On 09/24/2010 10:58 PM, Mathieu Suen wrote:
> Hi Paolo,
>
> I have made a fix for the issue: http://smalltalk.gnu.org/project/issue/520.
> You can take it from my repository.
> I am not fan of the fix but at least it work.

No, it is more complicated than that.  Here is a more complete testcase:

Eval [
     (Object subclass: #AB)
         instanceVariableNames: 'a'.
     (Object subclass: #C)
         instanceVariableNames: 'c';
         createGetMethod: 'c';
         createSetMethod: 'c'.
]

Eval [
     cObj := C new.
     cObj c: 34.
     Smalltalk at: #TestObj put: cObj.

     AB
         instanceVariableNames: 'a b';
         createGetMethod: 'b';
         createSetMethod: 'b'.
     ^cObj c
]

Eval [
     cObj := C new.
     cObj c: 34.
     ^cObj instVarAt: 3
]

Eval [
     TestObj b: 12.
     AB instanceVariableNames: 'b'.
     ^TestObj b
]

Eval [
     ^TestObj instVarAt: 1
]

Eval [
     ^TestObj instVarAt: 2
]

Eval [
     AB instanceVariableNames: 'b a'.
     ^TestObj b
]

Eval [
     ^TestObj instVarAt: 1
]

Eval [
     ^TestObj instVarAt: 3
]

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re : [Help-smalltalk] Fix for extend

Mathieu Suen-2
Ok so the  fix before (I just revert my repository) was better but it produce a
lot of Recompiling classes ... output.
And if you clean and reconfigure you get a lot of those output inside of some
Makefile.frag.
Maybe we just need to remove the Transcript output.





----- Message d'origine ----

> De : Paolo Bonzini <[hidden email]>
> À : Mathieu Suen <[hidden email]>
> Cc : GNU Smalltalk <[hidden email]>
> Envoyé le : Sam 25 septembre 2010, 17h 42min 05s
> Objet : Re: [Help-smalltalk] Fix for extend
>
> On 09/24/2010 10:58 PM, Mathieu Suen wrote:
> > Hi Paolo,
> >
> > I  have made a fix for the issue:
http://smalltalk.gnu.org/project/issue/520.

> > You can take it from my  repository.
> > I am not fan of the fix but at least it work.
>
> No, it  is more complicated than that.  Here is a more complete  testcase:
>
> Eval [
>     (Object subclass: #AB)
>          instanceVariableNames: 'a'.
>     (Object subclass:  #C)
>         instanceVariableNames: 'c';
>          createGetMethod: 'c';
>          createSetMethod: 'c'.
> ]
>

I guess you mean  (AB subclass:  #C)

> Eval [
>     cObj := C  new.
>     cObj c: 34.
>     Smalltalk at: #TestObj put:  cObj.
>
>     AB
>          instanceVariableNames: 'a b';
>         createGetMethod:  'b';
>         createSetMethod: 'b'.
>     ^cObj  c
> ]
>
> Eval [
>     cObj := C new.
>     cObj c:  34.
>     ^cObj instVarAt: 3
> ]
>
> Eval [
>      TestObj b: 12.
>     AB instanceVariableNames: 'b'.
>      ^TestObj b
> ]
>
> Eval [
>     ^TestObj instVarAt:  1
> ]
>
> Eval [
>     ^TestObj instVarAt: 2
> ]
>
> Eval  [
>     AB instanceVariableNames: 'b a'.
>     ^TestObj  b
> ]
>
> Eval [
>     ^TestObj instVarAt: 1
> ]
>
> Eval  [
>     ^TestObj instVarAt: 3
> ]
>
> Paolo
>




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Re : Fix for extend

Paolo Bonzini-2
On 09/27/2010 05:33 PM, Mathieu Suen wrote:
> Ok so the  fix before (I just revert my repository) was better but it produce a
> lot of Recompiling classes ... output.
> And if you clean and reconfigure you get a lot of those output inside of some
> Makefile.frag.
> Maybe we just need to remove the Transcript output.

Good idea.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk