Fix in GTExampleImpostorPragma

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix in GTExampleImpostorPragma

abergel
Hi!

I have produced:
GT-Inspector-AlexandreBergel.389

That replace:
GTExampleImpostorPragma>>= aImpostorPragma
        ^ self class = aImpostorPragma class
                and: [ self method = aImpostorPragma method ]

by:
GTExampleImpostorPragma>>= aImpostorPragma
        ^ self class == aImpostorPragma class
                and: [ self method == aImpostorPragma method ]

Performing #= between methods is pretty expensive and I see no reason why classes have to be compared with #= and not #==

Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Fix in GTExampleImpostorPragma

CyrilFerlicot


On 29/02/2016 09:22, Alexandre Bergel wrote:

> Hi!
>
> I have produced:
> GT-Inspector-AlexandreBergel.389
>
> That replace:
> GTExampleImpostorPragma>>= aImpostorPragma
> ^ self class = aImpostorPragma class
> and: [ self method = aImpostorPragma method ]
>
> by:
> GTExampleImpostorPragma>>= aImpostorPragma
> ^ self class == aImpostorPragma class
> and: [ self method == aImpostorPragma method ]
>
> Performing #= between methods is pretty expensive and I see no reason why classes have to be compared with #= and not #==
>
Hi,

If you recompile a method and compare the previous one and the new
compiled one I think #= can return true and #== false. I don't know if
you can have the same in your case but for a moment there was a bug in
Nautilus because of that. Make sure this will not happen here.

> Cheers,
> Alexandre
>

--
Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev

signature.asc (817 bytes) Download Attachment