Fixed Glamour wrong users of LayoutFrame fractions: (0@0 corner: 1@1) fixes

Hi

I commited Glamour fixes for

     LayoutFrame fractions: (0@0 corner: 1@1))
         ->
     LayoutFrame identity

It is faster, produces less garbage and easier to read.

Now it would be good that Glamourers do the same cleans that I did with
Igor on complete Pharo.
Check all the uses of fractions: and fractions:offsets: and only use
those if you do not create
by yourself a rectangle.

In addition using rectangles for passing four digits is doomed to create
wrong and incorrect rectangles
so if you still need to use rectangle better use Margin.

A margin is a holder of 1,2 or 4 digits and it is not a rectangle.

Tell me if you need more precision.

Stef

Hi,

> On Jan 9, 2016, at 11:17 AM, stepharo <[hidden email]> wrote:
>
> Hi
>
> I commited Glamour fixes for
>
>    LayoutFrame fractions: (0@0 corner: 1@1))
>        ->
>    LayoutFrame identity

Thanks!

> It is faster, produces less garbage and easier to read.
>
> Now it would be good that Glamourers do the same cleans that I did with Igor on complete Pharo.
> Check all the uses of fractions: and fractions:offsets: and only use those if you do not create
> by yourself a rectangle.

Yes. This is on the to do list. I missed this one beforehand.


> In addition using rectangles for passing four digits is doomed to create wrong and incorrect rectangles
> so if you still need to use rectangle better use Margin.
>
> A margin is a holder of 1,2 or 4 digits and it is not a rectangle.
>
> Tell me if you need more precision.

Makes sense.

Cheers,
Doru

> Stef
>

--
www.tudorgirba.com
www.feenk.com

"To utilize feedback, you first have to acquire it."