Fixed: Issue 2754 - DateAndTime creation from string/stream using incorrect default offset

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Fixed: Issue 2754 - DateAndTime creation from string/stream using incorrect default offset

Sean P. DeNigris
Administrator
http://code.google.com/p/pharo/issues/detail?id=2754

Fix in PharoInbox SLICE-Issue-2754-CreationFromStringOrStreamDefaultsToLocalOffset-SeanDeNigris.1
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Fixed: Issue 2754 - DateAndTime creation from string/stream using incorrect default offset

Stéphane Ducasse
hi sean

what is the DateAndTime localOffset? "Answer the duration we are offset from UTC"
Your changes basically uses DateAndTime localOffset when no offset is specified (and before it used zero).
It sounds reasonable but I was wondering the impact.

Stef


On Aug 5, 2010, at 10:57 PM, Sean P. DeNigris wrote:

>
> http://code.google.com/p/pharo/issues/detail?id=2754
>
> Fix in PharoInbox
> SLICE-Issue-2754-CreationFromStringOrStreamDefaultsToLocalOffset-SeanDeNigris.1
> --
> View this message in context: http://forum.world.st/Fixed-Issue-2754-DateAndTime-creation-from-string-stream-using-incorrect-default-offset-tp2315601p2315601.html
> Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Fixed: Issue 2754 - DateAndTime creation from string/stream using incorrect default offset

Sean P. DeNigris
Administrator
Stéphane Ducasse wrote
what is the DateAndTime localOffset? "Answer the duration we are offset from UTC"
http://en.wikipedia.org/wiki/Coordinated_Universal_Time -
In casual use, when fractions of a second are not important, Greenwich Mean Time (GMT) can be considered equivalent to UTC or UT1. In fact, saying "GMT" often implies either UTC or UT1. For this reason, saying "GMT" is generally avoided in technical contexts, with an unambiguous terminology of "UTC" or "UT1" preferred instead.

Stéphane Ducasse wrote
Your changes basically uses DateAndTime localOffset when no offset is specified (and before it used zero).
It sounds reasonable but I was wondering the impact.
Yes, that's correct.  I changed it for two reasons:
1. when someone says, "6pm," I don't think they ever mean GMT (unless, of course, that's their local time).
2. The non-[string|stream] instance creation methods (e.g. DateAndTime date: Date today time: Time now) do not operate that way, and return a DateAndTime like "2010-08-10T17:11:36-04:00" (with my local offset)

HTH,
Sean
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Fixed: Issue 2754 - DateAndTime creation from string/stream using incorrect default offset

Stéphane Ducasse
thanks for the explanation.
I will integrate your changes.

Stef

>> what is the DateAndTime localOffset? "Answer the duration we are offset
>> from UTC"
>>
> http://en.wikipedia.org/wiki/Coordinated_Universal_Time -
> In casual use, when fractions of a second are not important, Greenwich Mean
> Time (GMT) can be considered equivalent to UTC or UT1. In fact, saying "GMT"
> often implies either UTC or UT1. For this reason, saying "GMT" is generally
> avoided in technical contexts, with an unambiguous terminology of "UTC" or
> "UT1" preferred instead.
>
>
> Stéphane Ducasse wrote:
>>
>> Your changes basically uses DateAndTime localOffset when no offset is
>> specified (and before it used zero).
>> It sounds reasonable but I was wondering the impact.
>>
> Yes, that's correct.  I changed it for two reasons:
> 1. when someone says, "6pm," I don't think they ever mean GMT (unless, of
> course, that's their local time).
> 2. The non-[string|stream] instance creation methods (e.g. DateAndTime date:
> Date today time: Time now) do not operate that way, and return a DateAndTime
> like "2010-08-10T17:11:36-04:00" (with my local offset)
>
> HTH,
> Sean
> --
> View this message in context: http://forum.world.st/Fixed-Issue-2754-DateAndTime-creation-from-string-stream-using-incorrect-default-offset-tp2315601p2320464.html
> Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project