Smalltalk › Pharo › Pharo Smalltalk Developers

Fixes for Numbers are ready (toward ANSI)

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 8 messages Options
Nicolas Cellier
Reply | Threaded
Open this post in threaded view
♦
♦
|

Fixes for Numbers are ready (toward ANSI)

Nicolas Cellier
I cumulated the changes in this order:

http://code.google.com/p/pharo/issues/list?id=874
PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1
add Integer #bitAt:

http://code.google.com/p/pharo/issues/list?id=875
PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1
fix Float hash

http://code.google.com/p/pharo/issues/list?id=876
PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-Part1-nice.1
PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-Part2-nice.1
fix number equal transitivity (and further change Fraction hash)

http://code.google.com/p/pharo/issues/detail?id=681
PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1
connect SqNumberParser in Number readFrom: (with backward compatibility)

http://code.google.com/p/pharo/issues/list?id=879
PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1
add ANSI Float Characterization

Please review :)

Nicolas

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Stéphane Ducasse
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Fixes for Numbers are ready (toward ANSI)

Stéphane Ducasse
thanks nicolas
BTW did you got feedback about this one?
http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Status%20Summary%20Milestone&start=200

On Jun 11, 2009, at 9:24 PM, Nicolas Cellier wrote:

> I cumulated the changes in this order:
>
> http://code.google.com/p/pharo/issues/list?id=874
> PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1
> add Integer #bitAt:
>
> http://code.google.com/p/pharo/issues/list?id=875
> PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1
> fix Float hash
>
> http://code.google.com/p/pharo/issues/list?id=876
> PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-
> Part1-nice.1
> PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-
> Part2-nice.1
> fix number equal transitivity (and further change Fraction hash)
>
> http://code.google.com/p/pharo/issues/detail?id=681
> PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1
> connect SqNumberParser in Number readFrom: (with backward  
> compatibility)
>
> http://code.google.com/p/pharo/issues/list?id=879
> PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1
> add ANSI Float Characterization
>
> Please review :)
>
> Nicolas
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Nicolas Cellier
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Fixes for Numbers are ready (toward ANSI)

Nicolas Cellier
2009/6/11 Stéphane Ducasse <[hidden email]>:
> thanks nicolas
> BTW did you got feedback about this one?
> http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Status%20Summary%20Milestone&start=200

None yet. I only see 3 explanations:
- everyone is busy, dead, in hollidays, in the garden, etc...
- everyone disabled the preference for generating the error log
- I'm the only one doing bugs, no one else ever seen a slow Notifier

Maybe I should submit to squeak-dev, but the list seems rather quiet
these times.

Nicolas


>
> On Jun 11, 2009, at 9:24 PM, Nicolas Cellier wrote:
>
>> I cumulated the changes in this order:
>>
>> http://code.google.com/p/pharo/issues/list?id=874
>> PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1
>> add Integer #bitAt:
>>
>> http://code.google.com/p/pharo/issues/list?id=875
>> PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1
>> fix Float hash
>>
>> http://code.google.com/p/pharo/issues/list?id=876
>> PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-
>> Part1-nice.1
>> PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-
>> Part2-nice.1
>> fix number equal transitivity (and further change Fraction hash)
>>
>> http://code.google.com/p/pharo/issues/detail?id=681
>> PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1
>> connect SqNumberParser in Number readFrom: (with backward
>> compatibility)
>>
>> http://code.google.com/p/pharo/issues/list?id=879
>> PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1
>> add ANSI Float Characterization
>>
>> Please review :)
>>
>> Nicolas
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Stéphane Ducasse
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Fixes for Numbers are ready (toward ANSI)

Stéphane Ducasse

On Jun 11, 2009, at 10:02 PM, Nicolas Cellier wrote:

> 2009/6/11 Stéphane Ducasse <[hidden email]>:
>> thanks nicolas
>> BTW did you got feedback about this one?
>> http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Status%20Summary%20Milestone&start=200
>
> None yet. I only see 3 explanations:
> - everyone is busy, dead, in hollidays, in the garden, etc...

Dead busyz dead = stef

> - everyone disabled the preference for generating the error log
> - I'm the only one doing bugs, no one else ever seen a slow Notifier
>
> Maybe I should submit to squeak-dev, but the list seems rather quiet
> these times.
>
> Nicolas
>
>
>>
>> On Jun 11, 2009, at 9:24 PM, Nicolas Cellier wrote:
>>
>>> I cumulated the changes in this order:
>>>
>>> http://code.google.com/p/pharo/issues/list?id=874
>>> PharoInbox/SLICE-Mantis6985-Issue874-Integer-bitAt-nice.1
>>> add Integer #bitAt:
>>>
>>> http://code.google.com/p/pharo/issues/list?id=875
>>> PharoIbox/SLICE-Mantis6601-Issue875-Float-hash-nice.1
>>> fix Float hash
>>>
>>> http://code.google.com/p/pharo/issues/list?id=876
>>> PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-
>>> Part1-nice.1
>>> PharoInbox/SLICE-Mantis3374-Issue876-Arithmetic-Equality-transitive-
>>> Part2-nice.1
>>> fix number equal transitivity (and further change Fraction hash)
>>>
>>> http://code.google.com/p/pharo/issues/detail?id=681
>>> PharoInbox/SLICE-Mantis6982-Issue681-Number-readFrom-nice.1
>>> connect SqNumberParser in Number readFrom: (with backward
>>> compatibility)
>>>
>>> http://code.google.com/p/pharo/issues/list?id=879
>>> PharoInbox/SLICE-Issue879-ANSI-FloatCharacterization-nice.1
>>> add ANSI Float Characterization
>>>
>>> Please review :)
>>>
>>> Nicolas
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Alain Plantec-4
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Fixes for Numbers are ready (toward ANSI)

Alain Plantec-4
In reply to this post by Nicolas Cellier
Nicolas Cellier a écrit :

> 2009/6/11 Stéphane Ducasse <[hidden email]>:
>  
>> thanks nicolas
>> BTW did you got feedback about this one?
>> http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Status%20Summary%20Milestone&start=200
>>    
>
> None yet. I only see 3 explanations:
> - everyone is busy, dead, in hollidays, in the garden, etc...
> - everyone disabled the preference for generating the error log
> - I'm the only one doing bugs, no one else ever seen a slow Notifier
>  
:)
Hi Nicolas,
sorry for the stupid question but what are you asking testers to do ?
I've loaded the 4 .cs, verified that the preference is on and evaluated 0/0.
seen a notifier, click on proceed and get a SqueakDebug.log.
and then what ?
thanks
Alain

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Nicolas Cellier
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Fixes for Numbers are ready (toward ANSI)

Nicolas Cellier
2009/6/11 Alain Plantec <[hidden email]>:

> Nicolas Cellier a écrit :
>> 2009/6/11 Stéphane Ducasse <[hidden email]>:
>>
>>> thanks nicolas
>>> BTW did you got feedback about this one?
>>> http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Status%20Summary%20Milestone&start=200
>>>
>>
>> None yet. I only see 3 explanations:
>> - everyone is busy, dead, in hollidays, in the garden, etc...
>> - everyone disabled the preference for generating the error log
>> - I'm the only one doing bugs, no one else ever seen a slow Notifier
>>
> :)
> Hi Nicolas,
> sorry for the stupid question but what are you asking testers to do ?
> I've loaded the 4 .cs, verified that the preference is on and evaluated 0/0.
> seen a notifier, click on proceed and get a SqueakDebug.log.
> and then what ?
> thanks
> Alain
>

The speed should increase, that's what the patch is all for.
I don't know what test Stef wants exactly, I see two possibilities:
-1) review the changes
-2) install the changes and do normal activity, report if any trouble

Nicolas

> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Stéphane Ducasse
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Fixes for Numbers are ready (toward ANSI)

Stéphane Ducasse
yes something like that.
I think that the community should be more active reviewing fixes :)


>
>> Nicolas Cellier a écrit :
>>> 2009/6/11 Stéphane Ducasse <[hidden email]>:
>>>
>>>> thanks nicolas
>>>> BTW did you got feedback about this one?
>>>> http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Status%20Summary%20Milestone&start=200
>>>>
>>>
>>> None yet. I only see 3 explanations:
>>> - everyone is busy, dead, in hollidays, in the garden, etc...
>>> - everyone disabled the preference for generating the error log
>>> - I'm the only one doing bugs, no one else ever seen a slow Notifier
>>>
>> :)
>> Hi Nicolas,
>> sorry for the stupid question but what are you asking testers to do ?
>> I've loaded the 4 .cs, verified that the preference is on and  
>> evaluated 0/0.
>> seen a notifier, click on proceed and get a SqueakDebug.log.
>> and then what ?
>> thanks
>> Alain
>>
>
> The speed should increase, that's what the patch is all for.
> I don't know what test Stef wants exactly, I see two possibilities:
> -1) review the changes
> -2) install the changes and do normal activity, report if any trouble
>
> Nicolas
>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Mariano Martinez Peck
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Fixes for Numbers are ready (toward ANSI)

Mariano Martinez Peck
In reply to this post by Alain Plantec-4


On Thu, Jun 11, 2009 at 5:26 PM, Alain Plantec <[hidden email]> wrote:
Nicolas Cellier a écrit :
> 2009/6/11 Stéphane Ducasse <[hidden email]>:
>
>> thanks nicolas
>> BTW did you got feedback about this one?
>> http://code.google.com/p/pharo/issues/detail?id=860&colspec=ID%20Type%20Status%20Summary%20Milestone&start=200
>>
>
> None yet. I only see 3 explanations:
> - everyone is busy, dead, in hollidays, in the garden, etc...
> - everyone disabled the preference for generating the error log
> - I'm the only one doing bugs, no one else ever seen a slow Notifier
>
:)
Hi Nicolas,
sorry for the stupid question but what are you asking testers to do ?
I've loaded the 4 .cs, verified that the preference is on and evaluated 0/0.
seen a notifier, click on proceed and get a SqueakDebug.log.
and then what ?

Should he do something like what Nicolas do:

Debugger class>>#openOn:context:label:contents:fullView:
                Preferences logDebuggerStackToFile
                                ifTrue: [MessageTally spyOn: [Smalltalk

                                                logError: title
                                                inContext: context
                                                to: 'SqueakDebug.log']]

and compare the times before and after the changesets ???

Cheers,

Mariano
 

thanks
Alain

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Free forum by Nabble Edit this page