Smalltalk › Gemtalk › GLASS

Flattening traits - trait methods now compiled into classes not seen as changes

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

GLASS mailing list

Flattening traits - trait methods now compiled into classes not seen as changes

Hi All,

This may be the wrong place to post this - please let me know if there’s a more appropriate place.

I’m working on a new port of Pillar to GemStone (with the intention of updating Pier in GemStone to the latest version).

Once I flatten traits and recompile the methods, monticello does not see the removed methods as changed, and doesn’t write them to disc. I’ve attached a screenshot showing the apparent changes (the removed traits and methods) and a class browser showing one of the classes that has had the trait methods (accessing parameters protocol) as instance methods, however they are not included in the changes.

I’m not sure how to proceed, and don’t know how I can force metacello to write those methods into a filetree when I commit the package. Any suggestions?

Cheers,

Jupiter

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

GLASS mailing list

Re: Flattening traits - trait methods now compiled into classes not seen as changes

This is the right place (at least to start the discussion) ...

Hmmm ... it's been a while since I've dug into the traits expansion code ... presumably you want the traits to be expanded and then the new methods to become part of the package? ... I would have thought that that would work ... Could you pass me the steps it takes to get to the point you're at? then I can try to understand what's going wrong ...

Perhaps you can open an issue up on GsDevKit/GsDevKit[3] for this problem and then we can continue the discussion there ...

Cool that you're working on a Pillar port!

BTW, did you notice that I have ported the latest version of Magritte3 to GemStone[1]? I have a few minor items left on my todo list before making the official announcement, but it should be ready to go as I've already updated the Magritte3 project entry up on http://gsdevkit.github.io[2].

Dale

[1] https://github.com/GsDevKit/Magritte3
[2] http://gsdevkit.github.io/GsDevKit_home/
[3] https://github.com/GsDevKit/GsDevKit/issues

On 12/28/15 11:50 PM, Jupiter Jones via Glass wrote:

Hi All,

This may be the wrong place to post this - please let me know if there’s a more appropriate place.

I’m working on a new port of Pillar to GemStone (with the intention of updating Pier in GemStone to the latest version).

Once I flatten traits and recompile the methods, monticello does not see the removed methods as changed, and doesn’t write them to disc. I’ve attached a screenshot showing the apparent changes (the removed traits and methods) and a class browser showing one of the classes that has had the trait methods (accessing parameters protocol) as instance methods, however they are not included in the changes.

I’m not sure how to proceed, and don’t know how I can force metacello to write those methods into a filetree when I commit the package. Any suggestions?

Cheers,

Jupiter
_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass