FogBugz (Case [Issue]10848) Trait - Problems with parenthesis in TraitComposition

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

FogBugz (Case [Issue]10848) Trait - Problems with parenthesis in TraitComposition

Pharo Issue Tracker
A FogBugz case was edited by Sebastian Tleye.

Case ID:      10848
Title:        Problems with parenthesis in TraitComposition
Status:       Resolved (Fix Review Needed)
Category:     Bug
Project:      Trait
Area:         Misc
Priority:     5 - Fix If Time
Milestone:    Pharo3.0: 30/03/2014
Assigned To:  Sebastian Tleye

URL:          https://pharo.fogbugz.com/default.asp?10848

The slice SLICE-Issue-10848-Problems-with-parenthesis-in-TraitComposition-ST.3 can be improved:

- Object>>deepFlattenInto: must not be part of the slice
- I find it very strange that parenthesis are put around all expressions, even the outermost ones. Can you improve this part? Maybe by fixing TraitComposition>>printOn:. Such a fix would make your patch much less invasive because many tests are changed by your patch just by adding parenthesis around the outermost expression.
- You added verifications to TraitTest>>testAddAndRemoveMethodsInClassOrTrait. Could you create a new test instead of changing this one?


You are subscribed to this case.  If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.fogbugz.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=10848) from this case.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker