FogBugz (Case [Issue]10889) Trait - ExplicitRequirement methods bug

A FogBugz case was reactivated (assigned to Everyone) by Damien Cassou.

Case ID:      10889
Title:        ExplicitRequirement methods bug
Status:       Work Needed
Category:     Bug
Project:      Trait
Area:         Misc
Priority:     5 - Fix If Time
Milestone:    Pharo3.0: 30/03/2014
Assigned To:  Everyone

URL:          https://pharo.fogbugz.com/default.asp?10889


Changes:
Status changed from 'Resolved (Fix To Include)' to 'Work Needed'.

Commenting on SLICE-Issue-10889-ExplicitRequirement-methods-bug-SebastianTleye.1:

- You could please avoid changing TraitTest>>#testExplicitRequirement and add a new test instead (e.g., #testExplicitRequirementDoesNotTakePrecedence)
- TraitPureBehaviorTest>>testTraitsAccessor and #testClassesWithTraits are changed for no apparent reason. Try to avoid changing existing test unless this is absolutely necessary. This will help people understand the impact of your patch. If you don't change any test, people will have greater trust in your code.
- In TPureBehavior>>updateMethodDictionarySelector: you add code to an already complex method. Could you please refactor this method instead?
- TClassDescription>>updateTraitMethodsForAfterRemoval: should have a comment.
- If you understand the behavior of TClassDescription>>removeSelector: please improve the comment. It looks like the comment does not explain what the method is doing. At least, the comment talks about "message" where I think "method" is the right name, and the comment talks about "whose selector is given from the method dictionary of the receiver" but a "selector" is passed as parameter.
- It looks quite strange to me that you remove methods from dictionaries in TBehavior>>basicAddSelector:withMethod:. Can you explain why you are doing that? The method comment talks about "adding" methods, not removing.


You are subscribed to this case.  If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.fogbugz.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=10889) from this case.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker