FogBugz (Case [Issue]19854) Nautilus - Rename variable refactoring by cmd r in Nautilus shows RBNode name instead of var name

Classic

List

Threaded

♦

♦

Locked 1 message

Pharo Issue Tracker

Reply | Threaded

Open this post in threaded view

♦

♦

|

FogBugz (Case [Issue]19854) Nautilus - Rename variable refactoring by cmd r in Nautilus shows RBNode name instead of var name

Denis Kudryashov edited Case 19854: Rename variable refactoring by cmd r in Nautilus shows RBNode name instead of var name: Bug in  Nautilus: 1. Pharo Image  •  You are subscribed to this case What you describe is a bug of cmd+r refactoring. Because it not works when you press it on message selector for example. Instead of method rename dialog it will try to apply variable rename refactoring. And I see now that it implemented in the way to work only for temp/arg variables. So cmd+r on instance variable will also not work. To fix it we should delegate refactoring to selected node itself. Look at #renameTextSelectionForMethod method. Priority: 3 – Must Fix Status: Work Needed Assigned to: Everyone Milestone: Pharo6.0 Go to Case No longer need updates? Unsubscribe from this case. Don't want FogBugz notifications anymore? Update your preferences. A FogBugz case was edited by Denis Kudryashov. Case ID: 19854 Title: Rename variable refactoring by cmd r in Nautilus shows RBNode name instead of var name Status: Work Needed Category: Bug Project: Nautilus Area: 1. Pharo Image Priority: 3 - Must Fix Milestone: Pharo6.0: 3/31/2017 Assigned To: Everyone URL: https://pharo.fogbugz.com/f/cases/19854 What you describe is a bug of cmd+r refactoring. Because it not works when you press it on message selector for example. Instead of method rename dialog it will try to apply variable rename refactoring. And I see now that it implemented in the way to work only for temp/arg variables. So cmd+r on instance variable will also not work. To fix it we should delegate refactoring to selected node itself. Look at #renameTextSelectionForMethod method. You are subscribed to this case. If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.fogbugz.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=19854) from this case. _______________________________________________ Pharo-bugtracker mailing list [hidden email] https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker