FogBugz (Case [Issue]20004) Kernel - SnapshotDone should be not announced on every image startup

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

FogBugz (Case [Issue]20004) Kernel - SnapshotDone should be not announced on every image startup

Pharo Issue Tracker
FogBugz Notification
avatar
Denis Kudryashov opened Case 20004: SnapshotDone should be not announced on every image startup and assigned it to Everyone:
Bug in Project:  Kernel: 1. Pharo Image  •  You are subscribed to this case
Now we have logic in SessionManager:
<code>
SessionManager>>snapshot: save andQuit: quit
| isImageStarting snapshotResult |
ChangesLog default logSnapshot: save andQuit: quit.

self currentSession stop: quit. "Image not usable from here until the session is restarted!"
save
ifTrue: [
snapshotResult := Smalltalk snapshotPrimitive. "<-- PC frozen here on image file"
isImageStarting := snapshotResult == true.
SystemAnnouncer uniqueInstance snapshotDone: isImageStarting ]
ifFalse: [ isImageStarting := false ].
(quit and: [ isImageStarting not ])
ifTrue: [ Smalltalk quitPrimitive ].

"create a new session object if we're booting"
isImageStarting ifTrue: [ self installNewSession ].

self currentSession start: isImageStarting.
snapshotResult
ifNil: [ self error: 'Failed to write image file (disk full?)' ].

"We return the resuming state, which may be useful for users to know the state of the image"
^ isImageStarting
<code>
When we save image just after snapshot system announce event:
<code>
SystemAnnouncer uniqueInstance snapshotDone: isImageStarting
</code>
Which means this event will be announced at every startup. I think it is wrong. And it should be announced only on working image
Priority Priority: 5 – Fix If Time Status Status: Work Needed
Assigned To Assigned to: Everyone Milestone Milestone: Pharo6.0

Go to Case
No longer need updates? Unsubscribe from this case.

Don't want FogBugz notifications anymore? Update your preferences.

FogBugz

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker