Pharo Issue Tracker - FogBugz (Caso [Issue]11579) Monticello - When adding a class variable, the monticello package is not dirty

FogBugz Notification

	Nicolás Papagna Maldonado edited Case 11579: When adding a class variable, the monticello package is not dirty: Bug in Monticello: 1. Pharo Image • You are subscribed to this case

I think I've found the cause of this issue.

In Pharo 2.0, this change announce is triggered at the end of:

<code>ClassBuilder>>name:inEnvironment:subclassOf:type:instanceVariableNames:classVariableNames:poolDictionaries:category:unsafe:</code>

In the latest Pharo development version, announcements are triggered when either an instance of <code>ClassModification</code> modified the slots (see <code>SlotClassBuilder>>applySlotChange:</code>) or the format (see <code>SlotClassBuilder>>applyFormatChange:</code>) of the class being changed in <code>SlotClassBuilder>>apply:</code>.

The problem is that the string containing the class variables definition is never used to create the <code>ClassModification</code> instance.

Class variable definition is being handled separetely, and so, changes are not triggered.

See the ending collaborations of <code>SlotClassBuilder>>build</code>.

It would be great if you could give me feedback to fix this issue:

do you think the class variable definition is a responsibility of <code>ClassModification</code>?

is there a reason this behavior is not implemented in that class?

Thanks in advance,

Nico PM

	Priority: 3 – Must Fix		Status: Work Needed
	Assigned to: Everyone		Milestone: Pharo3.0

Go to Case

No longer need updates? Unsubscribe from this case.

Don't want FogBugz notifications anymore? Update your preferences.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker