Smalltalk › Pharo › Pharo Smalltalk Developers

Fwd: FogBugz (Case [Issue]19057) CI and Bugtracker - Failing test: SHParserST80Test.testNumberHierarchy

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

Nicolai Hess-3-2

Fwd: FogBugz (Case [Issue]19057) CI and Bugtracker - Failing test: SHParserST80Test.testNumberHierarchy

Fraction>>round: numberOfWishedDecimal
    "Round the decimal part of the receiver to be limited to the number of wished decimal. Only leave a fixed amount of decimal"
   < expr: (1/3 round: 2) result: 0.33 >
    < expr: (111/100 round: 2) result: 1.11 >

    ^self asFloat round: numberOfWishedDecimal

this method was changed for case 19034 Improve comment of round:

But I think
< expr: (111/100 round: 2) result: 1.11 >

is actually not a valid pragma expression. (Squeak compiler does not allow this).

1. Do we want to allow this syntax ( I don't want)

2. how to express this "example-pragma", use literal arrays instead:
< expr: #(1/3 round: 2) result: 0.33 >

or
<expr: #(1 #/ 3 #round: 2) result: 0.33>

nicolai

---------- Forwarded message ----------
From: Pharo Issue Tracker <[hidden email]>
Date: 2016-09-07 10:45 GMT+02:00
Subject: FogBugz (Case [Issue]19057) CI and Bugtracker - Failing test: SHParserST80Test.testNumberHierarchy
To: "[hidden email]" <[hidden email]>

	Marcus Denker opened Case 19057: Failing test: SHParserST80Test.testNumberHierarchy and assigned it to Everyone: Bug in CI and Bugtracker: 1. Pharo Image • You are subscribed to this case

testNumberHierarchy

is Failing

	Priority: 5 – Fix If Time		Status: Work Needed
	Assigned to: Everyone		Milestone: Pharo6.0

Go to Case

No longer need updates? Unsubscribe from this case.

Don't want FogBugz notifications anymore? Update your preferences.

Marcus Denker-4

Re: FogBugz (Case [Issue]19057) CI and Bugtracker - Failing test: SHParserST80Test.testNumberHierarchy

On 07 Sep 2016, at 13:37, Nicolai Hess <[hidden email]> wrote:

Fraction>>round: numberOfWishedDecimal
    "Round the decimal part of the receiver to be limited to the number of wished decimal. Only leave a fixed amount of decimal"
   < expr: (1/3 round: 2) result: 0.33 >
    < expr: (111/100 round: 2) result: 1.11 >

    ^self asFloat round: numberOfWishedDecimal

this method was changed for case 19034 Improve comment of round:

ups… I did not review correctly. I thought that only the comment changed. Pragmas are not comments...

But I think
< expr: (111/100 round: 2) result: 1.11 >
is actually not a valid pragma expression. (Squeak compiler does not allow this).

1. Do we want to allow this syntax ( I don't want)

No! This would make the system quite unreadable if you add lots of those everywhere.

Marcus