Fwd: about allCallOn -> AllReferTo : issue 261

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: about allCallOn -> AllReferTo : issue 261

Stéphane Ducasse
>
> Alex
>
> I integrated your changes but apparently some tests are broken.
> Can you have a look?
>
> Tx
>
> Stef
>
>
>


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: about allCallOn -> AllReferTo : issue 261

Alexandre Bergel
Stef,

Between a 11106 (which does not contain my fix) and 11111 (which  
contains my fix), there is only one more test fail, which is not  
related to allCallOn: (but in ReleaseTest).

>> I integrated your changes but apparently some tests are broken.
>> Can you have a look?

I am not sure which test you're referring to. Among failed tests, I do  
not imediately see the one related to my fix.

I first thought that testIsUnsentMessagesIn* test would be related.  
But actually not. They were yellow before my fix was incorporated, and  
these tests indirectly use SystemNavigation>>allSendersOf: selector

Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Picture 1.png (99K) Download Attachment
Picture 2.png (110K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: about allCallOn -> AllReferTo : issue 261

Stéphane Ducasse
Ok the three systemNavigation were broken before?
We still need to fix them :)

Stef

> Stef,
>
> Between a 11106 (which does not contain my fix) and 11111 (which contains my fix), there is only one more test fail, which is not related to allCallOn: (but in ReleaseTest).
>
>>> I integrated your changes but apparently some tests are broken.
>>> Can you have a look?
>
> I am not sure which test you're referring to. Among failed tests, I do not imediately see the one related to my fix.
>
> I first thought that testIsUnsentMessagesIn* test would be related. But actually not. They were yellow before my fix was incorporated, and these tests indirectly use SystemNavigation>>allSendersOf: selector
>
> Cheers,
> Alexandre
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
> <Picture 1.png><Picture 2.png>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: about allCallOn -> AllReferTo : issue 261

Alexandre Bergel
> Ok the three systemNavigation were broken before?

Yes.

Alexandre

>>
>> Between a 11106 (which does not contain my fix) and 11111 (which  
>> contains my fix), there is only one more test fail, which is not  
>> related to allCallOn: (but in ReleaseTest).
>>
>>>> I integrated your changes but apparently some tests are broken.
>>>> Can you have a look?
>>
>> I am not sure which test you're referring to. Among failed tests, I  
>> do not imediately see the one related to my fix.
>>
>> I first thought that testIsUnsentMessagesIn* test would be related.  
>> But actually not. They were yellow before my fix was incorporated,  
>> and these tests indirectly use SystemNavigation>>allSendersOf:  
>> selector
>>
>> Cheers,
>> Alexandre
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>> <Picture 1.png><Picture 2.png>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project