Smalltalk › Pharo › Pharo Smalltalk Developers

Fwd: [pharo-core] 50248 (3d7f1f3)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

vonbecmann

Fwd: [pharo-core] 50248 (3d7f1f3)

Hi all,

it seems i have changed a method (Rectangle>>#intersect:ifNone:) that could impact in the performance of the UI. see below

---------- Forwarded message ----------
From: Nicolas Cellier <[hidden email]>
Date: Thu, Aug 20, 2015 at 1:18 PM
Subject: Re: [pharo-core] 50248 (3d7f1f3)
To: pharo-project/pharo-core <[hidden email]>

IMO, min: and max: were intentionally inlined for speed purpose, since primitive graphics objects are heavily used.
That's questionnable, but maybe still necessary on slow machines like Pi.

—
Reply to this email directly or view it on GitHub.

so, do i have to revert that change?

thanks, sorry for the inconvenience

Bernardo E.C.

Sent from a cheap desktop computer in South America.

Nicolas Cellier

Re: Fwd: [pharo-core] 50248 (3d7f1f3)

Hi Bernardo,

I would say no: don't revert anything before testing.

2015-08-20 19:56 GMT+02:00 Bernardo Ezequiel Contreras <[hidden email]>:

Hi all,

it seems i have changed a method (Rectangle>>#intersect:ifNone:) that could impact in the performance of the UI. see below

---------- Forwarded message ----------
From: Nicolas Cellier <[hidden email]>
Date: Thu, Aug 20, 2015 at 1:18 PM
Subject: Re: [pharo-core] 50248 (3d7f1f3)
To: pharo-project/pharo-core <[hidden email]>

IMO, min: and max: were intentionally inlined for speed purpose, since primitive graphics objects are heavily used.
That's questionnable, but maybe still necessary on slow machines like Pi.

—
Reply to this email directly or view it on GitHub.

so, do i have to revert that change?

thanks, sorry for the inconvenience

--
Bernardo E.C.

Sent from a cheap desktop computer in South America.

vonbecmann

Re: Fwd: [pharo-core] 50248 (3d7f1f3)

btw, thanks for reviewing the code!

On Thu, Aug 20, 2015 at 5:29 PM, Nicolas Cellier <[hidden email]> wrote:

Hi Bernardo,
I would say no: don't revert anything before testing.

2015-08-20 19:56 GMT+02:00 Bernardo Ezequiel Contreras <[hidden email]>:
Hi all,

it seems i have changed a method (Rectangle>>#intersect:ifNone:) that could impact in the performance of the UI. see below

---------- Forwarded message ----------
From: Nicolas Cellier <[hidden email]>
Date: Thu, Aug 20, 2015 at 1:18 PM
Subject: Re: [pharo-core] 50248 (3d7f1f3)
To: pharo-project/pharo-core <[hidden email]>

IMO, min: and max: were intentionally inlined for speed purpose, since primitive graphics objects are heavily used.
That's questionnable, but maybe still necessary on slow machines like Pi.

—
Reply to this email directly or view it on GitHub.

so, do i have to revert that change?

thanks, sorry for the inconvenience

--
Bernardo E.C.

Sent from a cheap desktop computer in South America.

Bernardo E.C.

Sent from a cheap desktop computer in South America.

Marcus Denker-4

Re: [pharo-core] 50248 (3d7f1f3)

In reply to this post by Nicolas Cellier

On 20 Aug 2015, at 22:29, Nicolas Cellier <[hidden email]> wrote:

Hi Bernardo,
I would say no: don't revert anything before testing.

Yes, we should benchmark… and this shows that if people write “special” fast code, they *really* need

to document this! Now with the quality assist in place, you will find people submitting improvements

for “bad” code all the time. It will be impossible to not clean if these cases are not well documented.

2015-08-20 19:56 GMT+02:00 Bernardo Ezequiel Contreras <[hidden email]>:
Hi all,

it seems i have changed a method (Rectangle>>#intersect:ifNone:) that could impact in the performance of the UI. see below

---------- Forwarded message ----------
From: Nicolas Cellier <[hidden email]>
Date: Thu, Aug 20, 2015 at 1:18 PM
Subject: Re: [pharo-core] 50248 (3d7f1f3)
To: pharo-project/pharo-core <[hidden email]>

IMO, min: and max: were intentionally inlined for speed purpose, since primitive graphics objects are heavily used.
That's questionnable, but maybe still necessary on slow machines like Pi.
—
Reply to this email directly or view it on GitHub.

so, do i have to revert that change?

thanks, sorry for the inconvenience

--
Bernardo E.C.

Sent from a cheap desktop computer in South America.